[Merge Request M71] Remove checkbox if migration dialog has only one card |
|||||||||
Issue descriptionRequesting to merge the CL removing checkbox if migration dialog has only one card. https://chromium-review.googlesource.com/c/chromium/src/+/1287434 Have manually tested successfully in Canary 72.0.3590.0. This CL is self-contained and touches some view files only related to the migration flow. The whole flow is controlled by Finch flag. This change fix the issue that there was a checkbox when migration dialog had only one card. It improves the UX since the checkbox in that case does not make sense. Thanks!
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25
How is the change looking in canary?
,
Oct 25
Tested in the latest Canary on Mac (72.0.3591.0), it is working as expected for one card case (no checkbox) and multiple card case (have checkbox) See attached screenshots.
,
Oct 25
Approving merge to M71 branch 3578 based on comment #0 and #4. Please merge ASAP, Thank you.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09dbf1ab7f9c193ef690210351703565417b2caf commit 09dbf1ab7f9c193ef690210351703565417b2caf Author: siyua <siyua@chromium.org> Date: Thu Oct 25 16:35:53 2018 Remove checkbox if migration dialog has only one card And also remove card index since we are not using index for checkbox status update. Bug: 898596 Change-Id: I60513831b0392c469d62dfd45a15719670662272 Reviewed-on: https://chromium-review.googlesource.com/c/1287434 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602144}(cherry picked from commit a68a330f7c1a210c5277219d63fd55074163afd2) Reviewed-on: https://chromium-review.googlesource.com/c/1299538 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#321} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/09dbf1ab7f9c193ef690210351703565417b2caf/chrome/browser/ui/views/autofill/local_card_migration_dialog_view.cc [modify] https://crrev.com/09dbf1ab7f9c193ef690210351703565417b2caf/chrome/browser/ui/views/autofill/migratable_card_view.cc [modify] https://crrev.com/09dbf1ab7f9c193ef690210351703565417b2caf/chrome/browser/ui/views/autofill/migratable_card_view.h
,
Oct 25
Merge complete; marking as fixed.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09dbf1ab7f9c193ef690210351703565417b2caf Commit: 09dbf1ab7f9c193ef690210351703565417b2caf Author: siyua@chromium.org Commiter: jsaul@google.com Date: 2018-10-25 16:35:53 +0000 UTC Remove checkbox if migration dialog has only one card And also remove card index since we are not using index for checkbox status update. Bug: 898596 Change-Id: I60513831b0392c469d62dfd45a15719670662272 Reviewed-on: https://chromium-review.googlesource.com/c/1287434 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602144}(cherry picked from commit a68a330f7c1a210c5277219d63fd55074163afd2) Reviewed-on: https://chromium-review.googlesource.com/c/1299538 Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/branch-heads/3578@{#321} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 31
siyua@ - Could you please provide manual reproducible steps to verify the fix from our end. Thanks...!!
,
Oct 31
Tested the issue on Windows-10, Debian Rodete and Mac OS 10.13.6 using chrome latest Beta M71-71.0.3578.30 by following steps mentioned in the original comment. Observed that remove check box is displaying as expected. Hence adding TE-Verified label. Please find the screenshot for reference. Thank you!
,
Oct 31
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by siyua@chromium.org
, Oct 24Owner: siyua@chromium.org