New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898580 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

shellcheck: Add known ebuild top-level variables

Project Member Reported by bmgordon@chromium.org, Oct 24

Issue description

ebuilds set a bunch of top-level variables without necessarily using them (they are consumed externally through portage).  This results in tons of warnings like these:

In shellcheck-0.5.0-r3.ebuild line 4:
EAPI=6
^-- SC2034: EAPI appears unused. Verify use (or export if used externally).

We currently disable SC2034 in cros lint, but it's generally a useful warning.  We could turn it back on if we add a list of known top-level ebuild variables that shouldn't be warned about.  A good starting point might be the list at https://devmanual.gentoo.org/ebuild-writing/variables/index.html
 
Additionally, the read-only variables provided by portage (e.g. P, PN, CATEGORY) could be marked as trusted and not necessary to quote.
Owner: bmgordon@chromium.org
Status: Started (was: Untriaged)

Sign in to add a comment