LoginFeedbackTest.Basic crashes under SingleProcessMash |
||
Issue descriptionAt r602359 BrowserTestBase received signal: Segmentation fault. Backtrace: #0 0x7f9f242dfeed base::debug::StackTrace::StackTrace() #1 0x7f9f23fe27fa base::debug::StackTrace::StackTrace() #2 0x000008e8bc02 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f9ef3366030 <unknown> #4 0x00000d68e794 ChromeNativeAppWindowViewsAuraAsh::ChromeNativeAppWindowViewsAuraAsh() #5 0x00000d3ad006 ChromeAppWindowClient::CreateNativeAppWindowImpl() #6 0x00000cd1a7b1 ChromeAppWindowClient::CreateNativeAppWindow() #7 0x000004db95e0 extensions::AppWindow::Init() #8 0x0000051266f8 extensions::AppWindowCreateFunction::Run() #9 0x000004e56494 ExtensionFunction::RunWithValidation() #10 0x000004e5b4a1 extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal() #11 0x000004e5a4d8 extensions::ExtensionFunctionDispatcher::Dispatch() #12 0x000004ecc91d extensions::ExtensionWebContentsObserver::OnRequest() #13 0x000004dc3222 _ZN3IPC20DispatchToMethodImplIN10extensions21AppWindowContentsImplEMS2_FvPN7content15RenderFrameHostERKNSt3__16vectorINS1_15DraggableRegionENS6_9allocatorIS8_EEEEES4_NS6_5tupleIJSB_EEEJLm0EEEEvPT_T0_PT1_OT2_NS6_16integer_sequenceImJXspT3_EEEE #14 0x000004dc3150 _ZN3IPC16DispatchToMethodIN10extensions21AppWindowContentsImplEN7content15RenderFrameHostEJRKNSt3__16vectorINS1_15DraggableRegionENS5_9allocatorIS7_EEEEENS5_5tupleIJSA_EEEEENS5_9enable_ifIXeqsZT1_sr3std10tuple_sizeINS5_5decayIT2_E4typeEEE5valueEvE4typeEPT_MSM_FvPT0_DpT1_ESP_OSH_ #15 0x000004ecd2b1 _ZN3IPC8MessageTI29ExtensionHostMsg_Request_MetaNSt3__15tupleIJ31ExtensionHostMsg_Request_ParamsEEEvE8DispatchIN10extensions28ExtensionWebContentsObserverES9_N7content15RenderFrameHostEMS9_FvPSB_RKS4_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ #16 0x000004ecc7d9 extensions::ExtensionWebContentsObserver::OnMessageReceived() #17 0x00000af3bcd6 extensions::ChromeExtensionWebContentsObserver::OnMessageReceived() #18 0x7f9f1acf392c content::WebContentsImpl::OnMessageReceived() #19 0x7f9f1a23bf6c content::RenderFrameHostImpl::OnMessageReceived() #20 0x7f9f1a8e7d73 content::RenderProcessHostImpl::OnMessageReceived() #21 0x7f9f1e1129c5 IPC::ChannelProxy::Context::OnDispatchMessage() #22 0x7f9f1e1188bf _ZN4base8internal13FunctorTraitsIMN3IPC12ChannelProxy7ContextEFvRKNS2_7MessageEEvE6InvokeIS9_RK13scoped_refptrIS4_EJS7_EEEvT_OT0_DpOT1_ #23 0x7f9f1e11881f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN3IPC12ChannelProxy7ContextEFvRKNS4_7MessageEEJRK13scoped_refptrIS6_ES9_EEEvOT_DpOT0_ #24 0x7f9f1e1187ad _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE7RunImplIRKSA_RKNSt3__15tupleIJSC_S6_EEEJLm0ELm1EEEEvOT_OT0_NSJ_16integer_sequenceImJXspT1_EEEE #25 0x7f9f1e1186ac _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE #26 0x7f9f23f9480e _ZNO4base12OnceCallbackIFvvEE3RunEv #27 0x7f9f23fe3d2a base::debug::TaskAnnotator::RunTask() #28 0x7f9f24075d88 base::MessageLoop::RunTask() #29 0x7f9f2407608b base::MessageLoop::DeferOrRunPendingTask() #30 0x7f9f240764d4 base::MessageLoop::DoWork() #31 0x7f9f24331ad9 base::MessagePumpLibevent::Run() #32 0x7f9f2407555e base::MessageLoop::Run() #33 0x7f9f24121f12 base::RunLoop::Run() #34 0x00000e7f21b0 apps::AppWindowWaiter::WaitForShown() #35 0x000002e59182 chromeos::LoginFeedbackTest_Basic_Test::RunTestOnMainThread() #36 0x000008e8a0f9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #37 0x000000b6ff2d _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_ #38 0x000000b6fe74 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_ #39 0x000008e8cfb5 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #40 0x000008e8ceec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE #41 0x000000b606fd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #42 0x000007c1125d ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #43 0x000007c0f2c8 ChromeBrowserMainParts::PreMainMessageLoopRun() #44 0x000003997956 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #45 0x7f9f19c88f1c content::BrowserMainLoop::PreMainMessageLoopRun() #46 0x7f9f18931ead _ZN4base8internal13FunctorTraitsIMN7content12ChildProcessEFvvEvE6InvokeIS5_PS3_JEEEvT_OT0_DpOT1_ #47 0x7f9f18931df4 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN7content12ChildProcessEFvvEJPS5_EEEvOT_DpOT0_ #48 0x7f9f19c8ee25 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NSF_16integer_sequenceImJXspT1_EEEE #49 0x7f9f19c8ed5c _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE #50 0x7f9f1883c7dd _ZNKR4base17RepeatingCallbackIFvvEE3RunEv #51 0x7f9f1ac6931d content::StartupTaskRunner::RunAllTasksNow() #52 0x7f9f19c84a1f content::BrowserMainLoop::CreateStartupTasks() #53 0x7f9f19c91492 content::BrowserMainRunnerImpl::Initialize() #54 0x7f9f19c7be79 content::BrowserMain() #55 0x7f9f1bf20fc0 content::RunBrowserProcessMain() #56 0x7f9f1bf23c8a content::ContentMainRunnerImpl::Run() #57 0x7f9f1bf19ddc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #58 0x7f9ef19a0841 service_manager::Main() #59 0x7f9f1bf1e6f5 content::ContentMain() #60 0x000008e896b7 content::BrowserTestBase::SetUp() #61 0x000007aa402b InProcessBrowserTest::SetUp() #62 0x000002dbc9a0 chromeos::LoginManagerTest::SetUp() #63 0x000000bbe2be _ZN7testing8internal12InvokeHelperIRKNSt3__16vectorIPN12user_manager4UserENS2_9allocatorIS6_EEEENS2_5tupleIJEEEE12InvokeMethodIN8chromeos15MockUserManagerEMSH_KFSB_vEEESB_PT_T0_RKSD_ #64 0x0000047e0232 testing::internal::HandleExceptionsInMethodIfSupported<>() #65 0x0000047c0954 testing::Test::Run() #66 0x0000047c1355 testing::TestInfo::Run() #67 0x0000047c20ff testing::TestCase::Run() #68 0x0000047d5c78 testing::internal::UnitTestImpl::RunAllTests() #69 0x0000047e9afe testing::internal::HandleSehExceptionsInMethodIfSupported<>() #70 0x0000047e1812 testing::internal::HandleExceptionsInMethodIfSupported<>() #71 0x0000047d58d7 testing::UnitTest::Run() #72 0x000007aed8e1 RUN_ALL_TESTS() #73 0x000007aeaaab base::TestSuite::Run() #74 0x0000079a2607 ChromeTestSuiteRunner::RunTestSuite() #75 0x0000079a26f3 ChromeTestLauncherDelegate::RunTestSuite() #76 0x000008f128b9 content::LaunchTests() #77 0x0000079a3a42 LaunchChromeTests() #78 0x0000079a1f4b main #79 0x7f9ef33532b1 __libc_start_main #80 0x000000aeb83a _start [1/1] LoginFeedbackTest.Basic (CRASHED) 1 test crashed: LoginFeedbackTest.Basic (../../chrome/browser/chromeos/login/ui/login_feedback_browsertest.cc:33)
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afe65cf118cec7824601a6699ada9ebed62b0992 commit afe65cf118cec7824601a6699ada9ebed62b0992 Author: James Cook <jamescook@chromium.org> Date: Thu Oct 25 17:09:36 2018 Fix feedback dialog at login screen for mash Browser code was attempting to reparent the feedback app window (owned by the browser) to the login window (owned by ash). Instead, explicitly create the feedback app window in the lock screen modal container (so it appears on top of the login screen) and make it modal (so you can't switch to the GAIA login dialog, which is in the same container). Also, don't try to access MultiUserWindowManager at the login screen, since it doesn't get created until later. This fixes the dialog under both single-process and multi-process mash. Bug: 898560 Test: browser_tests LoginFeedbackTest.Basics Change-Id: I2fe91b2f65e8817aac2a91d28ea66acb9b6a20ab Reviewed-on: https://chromium-review.googlesource.com/c/1298198 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602766} [modify] https://crrev.com/afe65cf118cec7824601a6699ada9ebed62b0992/chrome/browser/chromeos/login/ui/login_feedback.cc [modify] https://crrev.com/afe65cf118cec7824601a6699ada9ebed62b0992/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.cc [modify] https://crrev.com/afe65cf118cec7824601a6699ada9ebed62b0992/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash.h [modify] https://crrev.com/afe65cf118cec7824601a6699ada9ebed62b0992/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/afe65cf118cec7824601a6699ada9ebed62b0992/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Oct 25
|
||
►
Sign in to add a comment |
||
Comment 1 by jamescook@chromium.org
, Oct 24