New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898552 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Support more test suites with complex test cases

Project Member Reported by benjhayden@chromium.org, Oct 24

Issue description

Telemetry's system health story set creates complex test cases when uploaded to the chromeperf dashboard with two test path components like 'prefix/prefix_suffix'. V2SPA uses Descriptor to convert them back to telemetry's format 'prefix:suffix'. More test suites are using this story set, so Descriptor needs to whitelist them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/58f3fb4c4daa9edaed463fab3eeb4c552e7a6268

commit 58f3fb4c4daa9edaed463fab3eeb4c552e7a6268
Author: Ben Hayden <benjhayden@chromium.org>
Date: Fri Nov 09 19:33:30 2018

Generalize complex test cases in Descriptor.

Telemetry's system health story set creates complex test cases when uploaded to
the chromeperf dashboard with two test path components like
'prefix/prefix_suffix'. V2SPA uses Descriptor to convert them back to
telemetry's format 'prefix:suffix'. More test suites are using this story set,
so Descriptor needs to whitelist them.

Bug: chromium:898552
Change-Id: Id32800c579732af70e342c2ff465f32a9c309311
Reviewed-on: https://chromium-review.googlesource.com/c/1298002
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/58f3fb4c4daa9edaed463fab3eeb4c552e7a6268/dashboard/dashboard/common/descriptor.py
[modify] https://crrev.com/58f3fb4c4daa9edaed463fab3eeb4c552e7a6268/dashboard/dashboard/common/descriptor_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33c10c78715457aac9937c0a5b71b477233cc9da

commit 33c10c78715457aac9937c0a5b71b477233cc9da
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Nov 10 09:22:50 2018

Roll src/third_party/catapult 5d5091665700..f2c3502f7788 (9 commits)

https://chromium.googlesource.com/catapult.git/+log/5d5091665700..f2c3502f7788


git log 5d5091665700..f2c3502f7788 --date=short --no-merges --format='%ad %ae %s'
2018-11-10 nednguyen@google.com [browser_test_runner] Ensure that skipped tests have skipped expectation if typ expectation file is not used
2018-11-09 benjhayden@chromium.org Add BatchIterator for v2spa
2018-11-09 benjhayden@chromium.org Merge test suite descriptors in v2spa
2018-11-09 benjhayden@chromium.org Add RecommendedOptions to v2spa
2018-11-09 benjhayden@chromium.org Support uploading to dev_appserver.py
2018-11-09 benjhayden@chromium.org Generalize complex test cases in Descriptor.
2018-11-09 benjhayden@chromium.org Expose annotations via /api/timeseries2
2018-11-09 benjhayden@chromium.org Add tag-filter for v2spa
2018-11-08 dpranke@chromium.org Integrate test expectation-parsing code into TYP.


Created with:
  gclient setdep -r src/third_party/catapult@f2c3502f7788

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:904019 ,chromium:898552,chromium:900218, chromium:835690 
TBR=sullivan@chromium.org

Change-Id: Ic8d2d5b5c618bef91ecd2c6051a9e85ab340dab9
Reviewed-on: https://chromium-review.googlesource.com/c/1330771
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#607117}
[modify] https://crrev.com/33c10c78715457aac9937c0a5b71b477233cc9da/DEPS

Components: Speed>Dashboard

Sign in to add a comment