New issue
Advanced search Search tips

Issue 898544 link

Starred by 1 user
Status: Fixed
Owner:
mrefaat@chromium.org
Closed: Oct 24
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task
q4



Sign in to add a comment

Remove pagePlaceholder from tab

Project Member Reported by mrefaat@chromium.org, Oct 24 
This one was replaced by PagePlaceHolderTabHelper view.

Comment 1 by mrefaat@chromium.org, Oct 24

Description: Show this description

Comment 2 by mrefaat@chromium.org, Oct 24

Labels: -Pri-3 small q4 Pri-2
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9575b518495542d208f63d390d301aa0d3aea5ce

commit 9575b518495542d208f63d390d301aa0d3aea5ce
Author: mrefaat <mrefaat@chromium.org>
Date: Wed Oct 24 22:11:39 2018

[IOSTabRefactoring] Remove pagePlaceholder view.

This was replaced by the view inside PagePlaceHolderTabHelper.

Bug:  898544 
Change-Id: I077b13abcf0220100d1bb0fec4d39672b8a4fdc6
Reviewed-on: https://chromium-review.googlesource.com/c/1297459
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602483}
[modify] https://crrev.com/9575b518495542d208f63d390d301aa0d3aea5ce/ios/chrome/browser/tabs/tab.mm

Comment 4 by mrefaat@google.com, Oct 24

Status: Fixed (was: Assigned)

Comment 5 by mrefaat@chromium.org, Oct 25

Labels: -ios-tab-refactoring-cleanup S-tab-remove-obsolete-methods ios-tab-refactoring O-ios-tab-cleanup
►

Sign in to add a comment