New issue
Advanced search Search tips

Issue 898537 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Missing dependency in gn build

Project Member Reported by thakis@google.com, Oct 24

Issue description

1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1041506

2. Touch build/android/gyp/util/build_util.py

3. Run `ninja -C out\gnrel remoting-me2me-host-win-unsupported.zip `

4. Repeat steps 2 and 3 once


Expected: remoting-me2me-host-win-unsupported.zip should be rebuilt, because remoting/host/installer/win/BUILD.gn adds build_utils.py to sources in that patch.

Actual: It's not rebuilt. Instead, some CREDITS.txt change runs and then nothing happens. CREDITS.txt uses tools/licenses.py to write a depfile, so the depfile also contains build_util.py, and for some reason I don't understand toolchain.ninja doesn't list build_util.py as an input of remoting-me2me-host-win-unsupported.zip

At first I thought this might be a regression from https://bugs.chromium.org/p/chromium/issues/detail?id=843470 around restat edges, but since the dep comes in from a depfile gn can't know about it.
 

Sign in to add a comment