Don't set the fade out layer while dragging app launcher |
|||||||||
Issue descriptionDon't set the fade out layer while dragging app launcher
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecb0ae3a5db8d4888b87ced76086f97e81243a22 commit ecb0ae3a5db8d4888b87ced76086f97e81243a22 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Oct 24 20:46:23 2018 Remove fadeout mask while dragging the app launcher Bug: 898534 Test: manual: no functional/visual change Change-Id: I32aebe966f4a9fc22f51652ddf797583909ded9f Reviewed-on: https://chromium-review.googlesource.com/c/1298122 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#602439} [modify] https://crrev.com/ecb0ae3a5db8d4888b87ced76086f97e81243a22/ash/app_list/views/apps_grid_view.cc
,
Oct 24
Performance turning For 71. I'll update the test result once it hits canary.
,
Oct 25
Please provide details on testing / verification. Needed prior to merge approval. Thanks.
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25
,
Oct 25
,
Oct 30
I tested on latest canary 72.0.3953.0 (11209.0.0) and confirmed that fade out effects still works in both clamshell and tablet mode.
,
Oct 30
Approving merge to M71 Chrome OS.
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1153cf9efd87d3f85a244a3f860360e7b20d5e0 commit e1153cf9efd87d3f85a244a3f860360e7b20d5e0 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Nov 01 21:32:47 2018 Remove fadeout mask while dragging the app launcher Bug: 898534 Test: manual: no functional/visual change Change-Id: I32aebe966f4a9fc22f51652ddf797583909ded9f Reviewed-on: https://chromium-review.googlesource.com/c/1298122 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602439}(cherry picked from commit ecb0ae3a5db8d4888b87ced76086f97e81243a22) Reviewed-on: https://chromium-review.googlesource.com/c/1313285 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#463} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/e1153cf9efd87d3f85a244a3f860360e7b20d5e0/ash/app_list/views/apps_grid_view.cc
,
Nov 1
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1153cf9efd87d3f85a244a3f860360e7b20d5e0 Commit: e1153cf9efd87d3f85a244a3f860360e7b20d5e0 Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-01 21:32:47 +0000 UTC Remove fadeout mask while dragging the app launcher Bug: 898534 Test: manual: no functional/visual change Change-Id: I32aebe966f4a9fc22f51652ddf797583909ded9f Reviewed-on: https://chromium-review.googlesource.com/c/1298122 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Weidong Guo <weidongg@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602439}(cherry picked from commit ecb0ae3a5db8d4888b87ced76086f97e81243a22) Reviewed-on: https://chromium-review.googlesource.com/c/1313285 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#463} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by osh...@chromium.org
, Oct 24