New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898528 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

pixel_test exception thrown

Project Member Reported by erikc...@chromium.org, Oct 24

Issue description

This CL: https://chromium-review.googlesource.com/c/chromium/src/+/1294811/5

Failed pixel_test on the first build, but succeeded on the second

The error was fairly surprising:
https://chromium-swarm.appspot.com/task?id=40bb4bd22aa5b310&refresh=10&show_raw=1

"""
82 files remaining...
Additional test environment:
    CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
    CHROME_HEADLESS=1
    LANG=en_US.UTF-8
Command: c:\b\s\w\ir\.swarming_module_cache\vpython\bf8312\Scripts\python.exe ..\..\testing\scripts\run_gpu_integration_test_as_googletest.py ../../content/test/gpu/run_gpu_integration_test.py pixel --show-stdout --browser=release --passthrough -v --extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --dont-restore-color-profile-after-test --refimg-cloud-storage-bucket chromium-gpu-archive/reference-images --os-type win --build-revision 2f969bff5532233afff5564f947b453b5dac6be6 --test-machine-name win7_chromium_rel_ng --download-refimg-from-cloud-storage --isolated-script-test-filter gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_2DCanvasWebGL --isolated-script-test-output=c:\b\s\w\ioia_gvt\output.json --isolated-script-test-perf-output=c:\b\s\w\ioia_gvt\perftest-output.json

Traceback (most recent call last):
  File "..\..\testing\scripts\run_gpu_integration_test_as_googletest.py", line 67, in <module>
    sys.exit(main())
  File "..\..\testing\scripts\run_gpu_integration_test_as_googletest.py", line 50, in main
    return adapter.run_test()
  File "c:\b\s\w\ir\testing\scripts\common.py", line 334, in run_test
    cmd = self.generate_isolated_script_cmd()
  File "c:\b\s\w\ir\testing\scripts\common.py", line 300, in generate_isolated_script_cmd
    self.options.isolated_script_test_filter)
  File "c:\b\s\w\ir\testing\scripts\common.py", line 274, in generate_test_filter_args
    raise RuntimeError('this method is not yet implemented')
RuntimeError: this method is not yet implemented
"""

kbr -- any idea why this would happen?
 
Cc: nedngu...@google.com
Components: Internals>GPU>Testing
Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
Owner: kbr@chromium.org
Status: Started (was: Untriaged)
This was caused by the refactoring from Issue 894261. This used to work; I'll fix it now.

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72dd53f4e18900f94c849900a88ed3eb459d9996

commit 72dd53f4e18900f94c849900a88ed3eb459d9996
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Oct 24 20:56:00 2018

Implement generate_test_filter_args in GpuIntegrationTestAdapater.

Functionality was lost during a recent refactor. Tested manually.

Tbr: nednguyen@google.com
Bug:  898528 
Change-Id: Ia850e2c74e2dc353e8c18fbca8b90d3efef21908
Reviewed-on: https://chromium-review.googlesource.com/c/1298314
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602446}
[modify] https://crrev.com/72dd53f4e18900f94c849900a88ed3eb459d9996/testing/scripts/run_gpu_integration_test_as_googletest.py

Status: Fixed (was: Started)
This should be fixed now. Please reopen or file a new bug if issues persist.

Labels: Infra-Platform-Test

Sign in to add a comment