Go to NTP instead of chrome://welcome for FRE/new profiles when browser signin is forced off |
||||||
Issue descriptionChrome Version: 70.0.3538.67 OS: Win10 What steps will reproduce the problem? 1. Install a Chrome M70+, make sure that BrowserSignin=0 2. Click the Profile circle (upper right) 3. Click Manage People 4. Add a person, choose an icon, Click Blue “Add” Button 5. When Chrome Browser refreshes, it offers the user to Sign in! What is the expected result? * Do not offer the user to Sign-In when BrowserSignin=0 What happens instead? * Then user goes through Sign-in process * Sign-in doesn’t complete, there is no error why sign-in didn’t work * User is left confused
,
Oct 24
Note that it's always possible to manually navigate to chrome://welcome (the first run screen that prompts for sign in), even if BrowserSignin=0. However, to your point, we shouldn't show it by default for new profiles when browser signin is forced off. Updating the title of this bug, and cc'ing Charles as FYI since it affects FRE. This is P3.
,
Oct 25
,
Nov 13
I assume you meant SigninAllowed=0, right? Will add a condition for this on the first run.
,
Nov 13
Yes, SigninAllowed=0 >.< Thanks! Charles + Scott: you should make sure for the new FRE/welcome experience, we also are looking at the value of the SigninAllowed pref and modifying the experience accordingly. If SigninAllowed=0, then the user isn't allowed to sign in, so we should just do whatever else we'd do during FRE (e.g. setting up bookmarks). I filed Issue 904875 to track that for you.
,
Nov 13
I think this should be done in one patch. Maybe the owner of Issue 904875 should take this over. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by goanuj@chromium.org
, Oct 24