SuggestionView is riddled with business logic, so that needs to be converted to a proper MVC component.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f57bd4785eea318ceac18cf090ed21a88cb6d9d1 commit f57bd4785eea318ceac18cf090ed21a88cb6d9d1 Author: Ted Choc <tedchoc@chromium.org> Date: Wed Oct 24 22:58:24 2018 Initial internal migration for the suggestion view to MVC. This internally introduces a property model to SuggestionView and moves some of the logic to it. It also splits out the init call to primarily be operating on the model. After this the init call should be moved entirely out of the view and the binder should be pulled out too. BUG=898522 Change-Id: I5db1bb30c45cb4e63d7bfee75b2457817cfb6864 Reviewed-on: https://chromium-review.googlesource.com/c/1298213 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602511} [modify] https://crrev.com/f57bd4785eea318ceac18cf090ed21a88cb6d9d1/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/096255528e6cbfa2567f22c5648a6713450eaec5 commit 096255528e6cbfa2567f22c5648a6713450eaec5 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Oct 25 23:34:06 2018 Move infinite suggest offset tracking into the AutocompleteCoordinator. It was unnecessarily bouncing into the ListView. BUG=898522 Change-Id: I7e03bc5ded06bf992907a10bfb478fa261ce65ac Reviewed-on: https://chromium-review.googlesource.com/c/1298202 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602926} [modify] https://crrev.com/096255528e6cbfa2567f22c5648a6713450eaec5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/096255528e6cbfa2567f22c5648a6713450eaec5/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90d65da7106ef73b3d513172a054589e73351a75 commit 90d65da7106ef73b3d513172a054589e73351a75 Author: Ted Choc <tedchoc@chromium.org> Date: Fri Oct 26 00:33:39 2018 Pull out model and view binding from SuggestionView. This moves the logic into the adapter. Sets up the preliminary APIs on the View itself to allow a binder to interact with it, and slowly cleans up a few of the broken dependencies. The uphill battle goes on. BUG=898522 Change-Id: Ib8c8c00049a929af723003ad5533caf356c074f1 Reviewed-on: https://chromium-review.googlesource.com/c/1298171 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#602947} [modify] https://crrev.com/90d65da7106ef73b3d513172a054589e73351a75/chrome/android/java/res/values/ids.xml [modify] https://crrev.com/90d65da7106ef73b3d513172a054589e73351a75/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java [modify] https://crrev.com/90d65da7106ef73b3d513172a054589e73351a75/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java [add] https://crrev.com/90d65da7106ef73b3d513172a054589e73351a75/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionViewProperties.java [add] https://crrev.com/90d65da7106ef73b3d513172a054589e73351a75/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionViewViewBinder.java [modify] https://crrev.com/90d65da7106ef73b3d513172a054589e73351a75/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64 commit ebc5c1a806ba248b84da9d676d8ac2713fb9bb64 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 01 01:11:35 2018 Move more SuggestionView properties to MVC. The suggestion view no longer has direct references to any of the backend suggestion data. BUG=898522 Change-Id: Iacb03cff130d659c845e134f593f87b8416c16ae Reviewed-on: https://chromium-review.googlesource.com/c/1306350 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604471} [modify] https://crrev.com/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java [modify] https://crrev.com/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java [modify] https://crrev.com/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java [modify] https://crrev.com/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionViewProperties.java [modify] https://crrev.com/ebc5c1a806ba248b84da9d676d8ac2713fb9bb64/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionViewViewBinder.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5df8ec1223b8acd1a1b3943e15ec9abda038e14 commit e5df8ec1223b8acd1a1b3943e15ec9abda038e14 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 01 04:00:43 2018 Lazily calculate baseline shift for Android AiS. This prevents the need to pull values from the view to calculate the contents of the data. This will allow a better abstraction between model and view. BUG=898522 Change-Id: I1030e03d1e12c416c78c4d28cf469a0ff7ad842f Reviewed-on: https://chromium-review.googlesource.com/c/1306495 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604514} [modify] https://crrev.com/e5df8ec1223b8acd1a1b3943e15ec9abda038e14/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AnswerTextBuilder.java [modify] https://crrev.com/e5df8ec1223b8acd1a1b3943e15ec9abda038e14/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05f549ede37205e49c95316ae700c2340a833379 commit 05f549ede37205e49c95316ae700c2340a833379 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 01 05:26:25 2018 Slight cleanup of tail suggest padding for Android. The padding depends on the text size/paint metrics of the textview itself, so it makes sense to calculate it based on the state of the view. This also fixes RTL and a bug introduced in a previous cleanup that was applying tail suggest padding to all suggestions when showing a single tail suggest item. BUG=898522 Change-Id: I9b4a7be75b153948e6b53b8fcf3fcc804de1273a Reviewed-on: https://chromium-review.googlesource.com/c/1310715 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#604520} [modify] https://crrev.com/05f549ede37205e49c95316ae700c2340a833379/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java [modify] https://crrev.com/05f549ede37205e49c95316ae700c2340a833379/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java [modify] https://crrev.com/05f549ede37205e49c95316ae700c2340a833379/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionViewProperties.java [modify] https://crrev.com/05f549ede37205e49c95316ae700c2340a833379/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionViewViewBinder.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2bc300c5b529d004cd687955f98b410d0d446072 commit 2bc300c5b529d004cd687955f98b410d0d446072 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 01 16:46:24 2018 Move the voice suggestion provider into suggestions/ package. BUG=898522 Change-Id: Id9ef47429b19582982480ff0dcd5af78ab21b99e Reviewed-on: https://chromium-review.googlesource.com/c/1311496 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#604614} [modify] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandler.java [delete] https://crrev.com/cd9327400f4e5829b2693b19f19de9dfdfe698c8/chrome/android/java/src/org/chromium/chrome/browser/omnibox/VoiceSuggestionProvider.java [modify] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteController.java [modify] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [add] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/VoiceSuggestionProvider.java [modify] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/java_sources.gni [modify] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarVoiceRecognitionHandlerTest.java [rename] https://crrev.com/2bc300c5b529d004cd687955f98b410d0d446072/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/suggestions/VoiceSuggestionProviderTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5bc1102eac1ecd418a4cf35c8e3a53b48cb4cf commit aa5bc1102eac1ecd418a4cf35c8e3a53b48cb4cf Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 01 22:12:53 2018 Remove unused fields from Omnibox Suggestion MVC cleanups. Now all the model building no longer needs the view to build the properites, so we can just pass in the Model instead of the View. We should now be able to pull out the model building to a mediator and out of the adapter. BUG=898522 Change-Id: I5b0bff0778975bce0e5b27f9dd95c9f9385396c2 Reviewed-on: https://chromium-review.googlesource.com/c/1312560 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604721} [modify] https://crrev.com/aa5bc1102eac1ecd418a4cf35c8e3a53b48cb4cf/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dd4a144b6614d7fcf7d7eb2b56dd1440165876a commit 3dd4a144b6614d7fcf7d7eb2b56dd1440165876a Author: Ted Choc <tedchoc@chromium.org> Date: Tue Nov 06 01:34:35 2018 Extract a mediator for the Omnibox suggestions. Much of the AutocompleteCoordinator should move into the mediator, but this moves generating the model outside of the adapter. BUG=898522 Change-Id: I1d5bff329c078b616db03873145fb4dd180aa034 Reviewed-on: https://chromium-review.googlesource.com/c/1313736 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#605561} [modify] https://crrev.com/3dd4a144b6614d7fcf7d7eb2b56dd1440165876a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [add] https://crrev.com/3dd4a144b6614d7fcf7d7eb2b56dd1440165876a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [modify] https://crrev.com/3dd4a144b6614d7fcf7d7eb2b56dd1440165876a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxResultsAdapter.java [modify] https://crrev.com/3dd4a144b6614d7fcf7d7eb2b56dd1440165876a/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03cf97f6d8624109059e8ecd931dba7fcb829985 commit 03cf97f6d8624109059e8ecd931dba7fcb829985 Author: Ted Choc <tedchoc@chromium.org> Date: Tue Nov 06 21:01:01 2018 Convert omnibox suggestion list to an MVC component. This simplifies "some" of the dependencies from the AutocompleteCoordinator to the list view itself. The key handling is going to get a bit gnarly, but this is closer to being able to move the bulk of the coordinator into the existing AutocompleteMediator. NOPRESUBMIT=true BUG=898522 Change-Id: I71f6458220d4ba48c80db4aa18a3e78fe910872e Reviewed-on: https://chromium-review.googlesource.com/c/1316832 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#605818} [modify] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [modify] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java [add] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListProperties.java [add] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListViewBinder.java [modify] https://crrev.com/03cf97f6d8624109059e8ecd931dba7fcb829985/chrome/android/java_sources.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c69b61f200fd35552aaee979f3f5f12267a7646 commit 2c69b61f200fd35552aaee979f3f5f12267a7646 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 08 17:10:01 2018 Move bulk of autocomplete logic to the mediator. NOPRESUBMIT=true BUG=898522 Change-Id: I05888104ce8a6651014ee17555d1ed80fcf00615 Reviewed-on: https://chromium-review.googlesource.com/c/1324410 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#606506} [modify] https://crrev.com/2c69b61f200fd35552aaee979f3f5f12267a7646/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/2c69b61f200fd35552aaee979f3f5f12267a7646/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [modify] https://crrev.com/2c69b61f200fd35552aaee979f3f5f12267a7646/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/beabc89c3dbe797853b17276d9b4e2c8cbd95542 commit beabc89c3dbe797853b17276d9b4e2c8cbd95542 Author: Ted Choc <tedchoc@chromium.org> Date: Sat Nov 10 05:48:56 2018 Convert delete suggestion dialog to the Modal Dialog Manager. BUG=898522 Change-Id: I3a52ec99bde43584203de8bce30b448d50411061 Reviewed-on: https://chromium-review.googlesource.com/c/1318571 Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607107} [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/modaldialog/TabModalLifetimeHandler.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/searchwidget/SearchActivity.java [modify] https://crrev.com/beabc89c3dbe797853b17276d9b4e2c8cbd95542/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ef99815497ccf7bdb75e4bd98aff7b969dcb874 commit 1ef99815497ccf7bdb75e4bd98aff7b969dcb874 Author: Ted Choc <tedchoc@chromium.org> Date: Tue Nov 13 01:19:46 2018 Convert Autocomplete to a LazyConstructionPropertyMcp. BUG=898522 Change-Id: Ifd8c5748dd46e0a8417f9cd1bd80cf7f5a115965 Reviewed-on: https://chromium-review.googlesource.com/c/1330704 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#607403} [modify] https://crrev.com/1ef99815497ccf7bdb75e4bd98aff7b969dcb874/chrome/android/java/src/org/chromium/chrome/browser/modelutil/LazyConstructionPropertyMcp.java [modify] https://crrev.com/1ef99815497ccf7bdb75e4bd98aff7b969dcb874/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/1ef99815497ccf7bdb75e4bd98aff7b969dcb874/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListViewBinder.java [modify] https://crrev.com/1ef99815497ccf7bdb75e4bd98aff7b969dcb874/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java [modify] https://crrev.com/1ef99815497ccf7bdb75e4bd98aff7b969dcb874/chrome/test/android/javatests/src/org/chromium/chrome/test/util/OmniboxTestUtils.java [modify] https://crrev.com/1ef99815497ccf7bdb75e4bd98aff7b969dcb874/ui/android/java/src/org/chromium/ui/ViewProvider.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce65f3986e902f15c8c2ea6f02b5f45519cb18d2 commit ce65f3986e902f15c8c2ea6f02b5f45519cb18d2 Author: Ted Choc <tedchoc@chromium.org> Date: Tue Nov 13 19:36:36 2018 Clean up key event dispatching for Omnibox suggestions. This moves the bulk of the key handling into the view classes themselves and not the coordinator. BUG=898522 Change-Id: Ie2b517eca6d7ae9e27bc12a020880bc668897b56 Reviewed-on: https://chromium-review.googlesource.com/c/1331689 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#607704} [modify] https://crrev.com/ce65f3986e902f15c8c2ea6f02b5f45519cb18d2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java [modify] https://crrev.com/ce65f3986e902f15c8c2ea6f02b5f45519cb18d2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java [modify] https://crrev.com/ce65f3986e902f15c8c2ea6f02b5f45519cb18d2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsList.java [modify] https://crrev.com/ce65f3986e902f15c8c2ea6f02b5f45519cb18d2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListViewBinder.java [modify] https://crrev.com/ce65f3986e902f15c8c2ea6f02b5f45519cb18d2/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionView.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff5f68e7d50cae8efd8d15036abd633eab19f949 commit ff5f68e7d50cae8efd8d15036abd633eab19f949 Author: Ted Choc <tedchoc@chromium.org> Date: Thu Nov 15 01:01:48 2018 Fix hardware keyboard entry for the omnibox. This CL: https://chromium-review.googlesource.com/c/1331689 overzealously captures all key events instead of the previous logic that only handled a subset of th expected navigational keys. This restricts dispatching to the list view except for the previously expected keys. In particular, you can't type space in the current state, which is...unfortunate. BUG=898522 Change-Id: I55c055ae6f942cda833f2e3c678a458f55406741 Reviewed-on: https://chromium-review.googlesource.com/c/1336494 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#608202} [modify] https://crrev.com/ff5f68e7d50cae8efd8d15036abd633eab19f949/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/507614821484e438e319fb9c7b1140d28a8906a7 commit 507614821484e438e319fb9c7b1140d28a8906a7 Author: Ted Choc <tedchoc@chromium.org> Date: Wed Nov 21 01:40:04 2018 Fix answer in suggest async image loading in Android. When images are loaded async, it was updating the existing list of property models. The property model for the list was doing an equality check for the list. Two separate list instances with the same contents (in this case, the exact same objects), then the equality check will pass. To overcome this, we allow skipping the equality checks for object properties. BUG=898522 Change-Id: I60483d3365217b5da5d0a2cf052ac888bac1a522 Reviewed-on: https://chromium-review.googlesource.com/c/1345510 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#609884} [modify] https://crrev.com/507614821484e438e319fb9c7b1140d28a8906a7/chrome/android/java/src/org/chromium/chrome/browser/modelutil/PropertyModel.java [modify] https://crrev.com/507614821484e438e319fb9c7b1140d28a8906a7/chrome/android/java/src/org/chromium/chrome/browser/omnibox/suggestions/SuggestionListProperties.java
Comment 1 by bugdroid1@chromium.org
, Oct 24