See feature design doc (internal): https://docs.google.com/document/d/1WOeIWL1i7CYDN21plNNEFinSBa4aBI7VFV5s217ut24/edit#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a98876c5758525d75e301df5b06f173df6a309fe commit a98876c5758525d75e301df5b06f173df6a309fe Author: Eric Seckler <eseckler@chromium.org> Date: Thu Oct 25 08:32:23 2018 chrome/android: Add Developer preferences hidden behind feature flag This prepares for the addition of Tracing preferences, see design doc: https://docs.google.com/document/d/1WOeIWL1i7CYDN21plNNEFinSBa4aBI7VFV5s217ut24/edit Bug: 898512 Change-Id: I76d1c430aedf850d464c620c5a3d069a57a70bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1298014 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#602645} [add] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java/res/xml/developer_preferences.xml [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java/res/xml/main_preferences.xml [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [add] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/DeveloperPreferences.java [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/android/java_sources.gni [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/a98876c5758525d75e301df5b06f173df6a309fe/chrome/browser/android/chrome_feature_list.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0353e806c227e86965afe6678d3a9caa6d6d6ab commit a0353e806c227e86965afe6678d3a9caa6d6d6ab Author: Eric Seckler <eseckler@chromium.org> Date: Mon Oct 29 14:39:01 2018 tracing: Prepare TracingControllerAndroid for Mobile Tracing Adds support for retrieving known categories and trace buffer status on the java side. Also reenables a once flaky test. Bug: 898512 , 621956 Change-Id: I09522386587696a42d79a7d53ad5b5c314c49f3d Reviewed-on: https://chromium-review.googlesource.com/c/1299240 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603489} [modify] https://crrev.com/a0353e806c227e86965afe6678d3a9caa6d6d6ab/content/browser/android/tracing_controller_android.cc [modify] https://crrev.com/a0353e806c227e86965afe6678d3a9caa6d6d6ab/content/browser/android/tracing_controller_android.h [modify] https://crrev.com/a0353e806c227e86965afe6678d3a9caa6d6d6ab/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroid.java [modify] https://crrev.com/a0353e806c227e86965afe6678d3a9caa6d6d6ab/content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf commit 418237c5d0bdb75be33fc5ae77c8ab69f69b78cf Author: Eric Seckler <eseckler@chromium.org> Date: Tue Oct 30 08:37:06 2018 content/tracing: Expose TracingControllerAndroid publicly Adds a public TCA interface and renames implementation class to TracingControllerAndroidImpl. The public TCA will be used by a UI implemented in the chrome layer. Bug: 898512 Change-Id: Ibac5703c89adae447f2834abd86c356dcb5c1653 Reviewed-on: https://chromium-review.googlesource.com/c/1304480 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#603838} [modify] https://crrev.com/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf/content/browser/android/tracing_controller_android.cc [modify] https://crrev.com/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf/content/public/android/BUILD.gn [modify] https://crrev.com/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf/content/public/android/java/src/org/chromium/content/browser/BrowserStartupControllerImpl.java [rename] https://crrev.com/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf/content/public/android/java/src/org/chromium/content/browser/TracingControllerAndroidImpl.java [add] https://crrev.com/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf/content/public/android/java/src/org/chromium/content_public/browser/TracingControllerAndroid.java [rename] https://crrev.com/418237c5d0bdb75be33fc5ae77c8ab69f69b78cf/content/public/android/javatests/src/org/chromium/content/browser/TracingControllerAndroidImplTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4d14c859f441433e9890655f0f21e3d02ab05e3 commit c4d14c859f441433e9890655f0f21e3d02ab05e3 Author: Eric Seckler <eseckler@chromium.org> Date: Thu Nov 08 01:28:20 2018 notifications: Add areNotificationsEnabled() to NotificationManagerProxy This allows mocking of the NotificationManager in places where areNotificationsEnabled() is called. Added in preparation of the mobile tracing feature, which requires mocking this method for tests. TBR=mvanouwerkerk@chromium.org,nyquist@chromium.org Bug: 898512 Change-Id: Ic739269858970a2365ae6772f269e0aff19d4f5c Reviewed-on: https://chromium-review.googlesource.com/c/1321730 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#606272} [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxy.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdater.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/SiteChannelsManager.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotifier.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncNotificationController.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdaterTest.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/SiteChannelsManagerTest.java [modify] https://crrev.com/c4d14c859f441433e9890655f0f21e3d02ab05e3/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/notifications/MockNotificationManagerProxy.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93 commit fa5b7f9870a13aa948fe7de4b5f65b3f91965c93 Author: Eric Seckler <eseckler@chromium.org> Date: Wed Nov 14 11:39:25 2018 tracing: Add basic mobile tracing preferences Adds a simple preferences menu under the developer options menu with a button to start recording a trace. The recording is controlled via a notification. For now, the recorded trace cannot be configured or shared, we will add these features in follow up patches. See bug for design doc. Bug: 898512 Change-Id: I3a6b4dd24359f8098234ed5fbf5b6db07071a608 Binary-Size: feature implementation, strings won't be translated. Reviewed-on: https://chromium-review.googlesource.com/c/1327208 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#607957} [modify] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/res/xml/developer_preferences.xml [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/res/xml/tracing_preferences.xml [modify] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/res_template/xml/file_paths.xml [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/TracingPreferences.java [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/src/org/chromium/chrome/browser/tracing/OWNERS [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingController.java [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationManager.java [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationService.java [modify] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/java_sources.gni [add] https://crrev.com/fa5b7f9870a13aa948fe7de4b5f65b3f91965c93/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/developer/TracingPreferencesTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e53874394b9b2d4f1a031b471d064e7f6d34977c commit e53874394b9b2d4f1a031b471d064e7f6d34977c Author: Eric Seckler <eseckler@chromium.org> Date: Tue Nov 20 10:15:14 2018 tracing: Make tracing mode and categories configurable (android) Adds preferences for configuring the tracing mode and enabled tracing categories to the mobile tracing preferences. Bug: 898512 Change-Id: I23583dd24868918ce29eebce68568344b7c3c2f0 Binary-Size: feature implementation, strings will not be translated. Reviewed-on: https://chromium-review.googlesource.com/c/1340300 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#609657} [rename] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/res/xml/blank_preference_fragment_screen.xml [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/res/xml/tracing_preferences.xml [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AndroidPaymentAppsFragment.java [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPaymentMethodsFragment.java [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java [add] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/OWNERS [add] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/TracingCategoriesPreferences.java [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/TracingPreferences.java [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingController.java [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/java_sources.gni [modify] https://crrev.com/e53874394b9b2d4f1a031b471d064e7f6d34977c/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/developer/TracingPreferencesTest.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0cffda31288d0165ee3a97b4d43fcc6b7e87be48 commit 0cffda31288d0165ee3a97b4d43fcc6b7e87be48 Author: Eric Seckler <eseckler@chromium.org> Date: Wed Nov 21 14:23:40 2018 tracing: Add share trace button to mobile tracing notifications Adds functionality to share a recorded trace to the mobile tracing feature. Bug: 898512 Change-Id: I85107017abdad5ad508b18aecbba58607a004657 Reviewed-on: https://chromium-review.googlesource.com/c/1346070 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610044} [modify] https://crrev.com/0cffda31288d0165ee3a97b4d43fcc6b7e87be48/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingController.java [modify] https://crrev.com/0cffda31288d0165ee3a97b4d43fcc6b7e87be48/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationManager.java [modify] https://crrev.com/0cffda31288d0165ee3a97b4d43fcc6b7e87be48/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationService.java [modify] https://crrev.com/0cffda31288d0165ee3a97b4d43fcc6b7e87be48/chrome/android/java/strings/android_chrome_strings.grd
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ba1bbee02bbb2d4d7aa145bf1f1368066d0f394c commit ba1bbee02bbb2d4d7aa145bf1f1368066d0f394c Author: Eric Seckler <eseckler@chromium.org> Date: Wed Nov 21 15:09:08 2018 tracing: Update buffer usage in tracing notifications periodically. Also fixes the ordering of entries in the NotificationPreferences. TBR=twellington@chromium.org Bug: 898512 Change-Id: I2ad01d04a517100b3b0629c053dcd215cd2f838a Reviewed-on: https://chromium-review.googlesource.com/c/1346071 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610056} [modify] https://crrev.com/ba1bbee02bbb2d4d7aa145bf1f1368066d0f394c/chrome/android/java/res/xml/tracing_preferences.xml [modify] https://crrev.com/ba1bbee02bbb2d4d7aa145bf1f1368066d0f394c/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingController.java [modify] https://crrev.com/ba1bbee02bbb2d4d7aa145bf1f1368066d0f394c/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationManager.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24a9832f6402c6d3b41865e6aae627cd4b54aa73 commit 24a9832f6402c6d3b41865e6aae627cd4b54aa73 Author: Eric Seckler <eseckler@chromium.org> Date: Mon Dec 03 10:17:06 2018 android: Replace developer options feature flag with hidden activation Enables the developer options on <= Dev builds by default and adds a way to activate them on Beta/Stable channels via 7 taps on the chrome version in the preferences, in android-like style. Bug: 898512 Change-Id: Ife44df843e45d660485fb464209964c957a9c887 Reviewed-on: https://chromium-review.googlesource.com/c/1349309 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#613034} [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/android/java/src/org/chromium/chrome/browser/preferences/developer/DeveloperPreferences.java [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/developer/TracingPreferencesTest.java [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/24a9832f6402c6d3b41865e6aae627cd4b54aa73/chrome/browser/android/chrome_feature_list.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d503464aba5fec00db42711485377f4262dcde7 commit 2d503464aba5fec00db42711485377f4262dcde7 Author: Eric Seckler <eseckler@chromium.org> Date: Mon Dec 10 12:26:24 2018 tracing: Disable update of notification for accessibility Updating the buffer usage in the tracing notification interferes with screen readers. Since the update only updates the buffer usage, it is of limited use to screen reader users anyway, so disable it if screen readers are active. Bug: 896965, 898512 Change-Id: I1ff45f0bbef85aaa6d914e828c286db0f10d62ed Reviewed-on: https://chromium-review.googlesource.com/c/1369774 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#615096} [modify] https://crrev.com/2d503464aba5fec00db42711485377f4262dcde7/chrome/android/java/src/org/chromium/chrome/browser/tracing/TracingNotificationManager.java
Comment 1 by bugdroid1@chromium.org
, Oct 25