TopControlsSlideControllerTest.TestIntermediateSliding is flaky |
|||||
Issue descriptionTopControlsSlideControllerTest.TestIntermediateSliding is flaky. Doesn't seem related to Mash. Happens mostly on linux-chromeos-rel flakes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TopControlsSlideControllerTest.TestIntermediateSliding example failing build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8931795070477685392/+/steps/browser_tests/0/stdout failure: ../../chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc:1008: Failure Value of: seen_fractional_shown_ratio Actual: false Expected: true Stack trace: #0 0x0000021aa9bc testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000021aa389 testing::internal::AssertHelper::operator=() #2 0x0000019cb3cb (anonymous namespace)::TopControlsSlideControllerTest_TestIntermediateSliding_Test::RunTestOnMainThread() #3 0x00000476454b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x00000432ec94 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x00000432dbdc ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x000001d6d4d9 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #7 0x000002d3c8ea content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x0000030cb2d7 content::StartupTaskRunner::RunAllTasksNow() #9 0x000002d3b526 content::BrowserMainLoop::CreateStartupTasks() #10 0x000002d3ec20 content::BrowserMainRunnerImpl::Initialize() #11 0x000002d39584 content::BrowserMain() #12 0x000003f8c7a4 content::ContentMainRunnerImpl::Run() #13 0x000005f56ba0 service_manager::Main() #14 0x000003f8ac64 content::ContentMain() #15 0x000004764173 content::BrowserTestBase::SetUp() #16 0x0000042dc9be InProcessBrowserTest::SetUp()
,
Oct 24
Yes, I'm fixing this in a CL I'm working on now.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5743609504ecca4eb89ba55b26722ad76be2cb23 commit 5743609504ecca4eb89ba55b26722ad76be2cb23 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Thu Oct 25 22:14:51 2018 (Reland of reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. R=sky@chromium.org BUG=857331, 896514 , 867063, 898502 TEST=Added a new browser test. Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#600408} Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Original-Commit-Position: refs/heads/master@{#600966} Change-Id: I82713fcf642e06cd8e62342d0291ca40e4cd6ffb Reviewed-on: https://chromium-review.googlesource.com/c/1294406 Cr-Commit-Position: refs/heads/master@{#602893} [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/5743609504ecca4eb89ba55b26722ad76be2cb23/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
,
Oct 25
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27390fd98a365a3a898610371193062efb414ffb commit 27390fd98a365a3a898610371193062efb414ffb Author: Ahmed Fakhry <afakhry@chromium.org> Date: Wed Oct 31 23:29:56 2018 [Merge to M-71] (Reland of reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. TBR=sky@chromium.org BUG=857331, 896514 , 867063, 898502 TEST=Added a new browser test. (cherry picked from commit 5743609504ecca4eb89ba55b26722ad76be2cb23) Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#600408} Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Original-Original-Commit-Position: refs/heads/master@{#600966} Change-Id: I82713fcf642e06cd8e62342d0291ca40e4cd6ffb Reviewed-on: https://chromium-review.googlesource.com/c/1294406 Cr-Original-Commit-Position: refs/heads/master@{#602893} Reviewed-on: https://chromium-review.googlesource.com/c/1311934 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#440} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/browser_view.h [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h [modify] https://crrev.com/27390fd98a365a3a898610371193062efb414ffb/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27390fd98a365a3a898610371193062efb414ffb Commit: 27390fd98a365a3a898610371193062efb414ffb Author: afakhry@chromium.org Commiter: afakhry@chromium.org Date: 2018-10-31 23:29:56 +0000 UTC [Merge to M-71] (Reland of reland) top-chrome-slide: Disable the behavior when Chromevox is enabled. Users of Chromevox may need to touch explore the webpage, and for things to remain consistent, we should disable hiding top-chrome with gesture scrolls as long as Chromevox is enabled. TBR=sky@chromium.org BUG=857331, 896514 , 867063, 898502 TEST=Added a new browser test. (cherry picked from commit 5743609504ecca4eb89ba55b26722ad76be2cb23) Reviewed-on: https://chromium-review.googlesource.com/c/1284289 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#600408} Reviewed-on: https://chromium-review.googlesource.com/c/1287510 Cr-Original-Original-Commit-Position: refs/heads/master@{#600966} Change-Id: I82713fcf642e06cd8e62342d0291ca40e4cd6ffb Reviewed-on: https://chromium-review.googlesource.com/c/1294406 Cr-Original-Commit-Position: refs/heads/master@{#602893} Reviewed-on: https://chromium-review.googlesource.com/c/1311934 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#440} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Oct 24