Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=paint/invalidation/table/cached-69296.html It's been flaking for at least a week (the dashboard doesn't go back farther than that), but it seems to have gotten a lot worse recently. https://crrev.com/c/1289994 changed expectations for this test, maybe it's related? See also bug 732611 which has lots of activity in the vicinity.
For now, I'll mark the test as flaky on Mac.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a1904effc4b30cb5a8f1c3b68fdb252db8de9d86 commit a1904effc4b30cb5a8f1c3b68fdb252db8de9d86 Author: Marc Treib <treib@chromium.org> Date: Wed Oct 24 13:42:03 2018 Mark paint/invalidation/table/cached-69296.html as flaky on Mac TBR=wangxianzhu@chromium.org Bug: 898485 Change-Id: Ib0adea0db6371d32aaab5e8714246efaaca15ed4 Reviewed-on: https://chromium-review.googlesource.com/c/1297428 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602318} [modify] https://crrev.com/a1904effc4b30cb5a8f1c3b68fdb252db8de9d86/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f432a1f1ec094dabadff5dc83c96c3834f04b135 commit f432a1f1ec094dabadff5dc83c96c3834f04b135 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Oct 25 16:47:26 2018 [PE] Deflake paint/invalidation/table/cached-69296.html The test produced different results on Mac, sometimes with raster invalidations sometimes without. I'm not sure about the exact reason but I guess it is related to requestAnimationFrame (which I think should be double nested to ensure full document cycle update) and/or eventSender (event not synchronized with frame?). Now change to runAfterLayoutAndPaint (which also eases manual testing) and direct style change. Bug: 898485 Change-Id: I722737de0cd973bfdb439705eff33a2b4a48970b Reviewed-on: https://chromium-review.googlesource.com/c/1298067 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602754} [modify] https://crrev.com/f432a1f1ec094dabadff5dc83c96c3834f04b135/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/f432a1f1ec094dabadff5dc83c96c3834f04b135/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/table/cached-69296-expected.txt [rename] https://crrev.com/f432a1f1ec094dabadff5dc83c96c3834f04b135/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-69296-expected.txt [modify] https://crrev.com/f432a1f1ec094dabadff5dc83c96c3834f04b135/third_party/WebKit/LayoutTests/paint/invalidation/table/cached-69296.html [delete] https://crrev.com/2ce9d5e182ba361ba9c2e377e80d8f685420ae99/third_party/WebKit/LayoutTests/platform/mac-mac10.10/paint/invalidation/table/cached-69296-expected.txt [delete] https://crrev.com/2ce9d5e182ba361ba9c2e377e80d8f685420ae99/third_party/WebKit/LayoutTests/platform/mac-mac10.11/paint/invalidation/table/cached-69296-expected.txt [delete] https://crrev.com/2ce9d5e182ba361ba9c2e377e80d8f685420ae99/third_party/WebKit/LayoutTests/platform/mac-mac10.12/paint/invalidation/table/cached-69296-expected.txt [delete] https://crrev.com/2ce9d5e182ba361ba9c2e377e80d8f685420ae99/third_party/WebKit/LayoutTests/platform/mac-retina/paint/invalidation/table/cached-69296-expected.txt [delete] https://crrev.com/2ce9d5e182ba361ba9c2e377e80d8f685420ae99/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/table/cached-69296-expected.txt
Comment 1 by treib@chromium.org
, Oct 24