New issue
Advanced search Search tips

Issue 898479 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Dismissal of bookmark window animation is not smooth on tapping a searched bookmark

Project Member Reported by vbarig...@chromium.org, Oct 24

Issue description

App Version: 71.0.3578.21 beta
iOS Version: 11.4.1, 12.1 beta 5
Device: iPhones 8 plus (iPhones only)
URL: 

Precondition:
Have bookmark saved

Steps to reproduce:
  1.  Launch chrome beta.
  2.  Go to Menu --> Bookmarks
  3.  Search for a bookmark.
  4.  Tap on “Search” on the keyboard.
  5.  Tap on the searched bookmark.
 
Observed results:
Notice that the animation to dismiss the bookmark window is not smooth.

Expected results:
Animation should be smooth when the bookmark window is dismissed.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): NA on M70
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M71

Link to video/image: https://drive.google.com/file/d/1lsBPZ-VX8g_dEJ_T_Diw4uuw9YxLwkbY/view?usp=sharing

 
Cc: sczs@chromium.org
Owner: djean@chromium.org
Status: Assigned (was: Untriaged)
djean@ could you PTAL?
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df8ec6cc96c811c7e1b382f698e4c07ee2975a04

commit df8ec6cc96c811c7e1b382f698e4c07ee2975a04
Author: David Jean <djean@google.com>
Date: Tue Oct 30 07:26:08 2018

[ios] Fixed lingering animation on dismissing searched bookmark

Bug:  898479 
Change-Id: I7b6cd2e14381eefe476101c8f5d4c247422c5ee7
Reviewed-on: https://chromium-review.googlesource.com/c/1304493
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603820}
[modify] https://crrev.com/df8ec6cc96c811c7e1b382f698e4c07ee2975a04/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 
Version: 72.0.3603.0 Canary
Devices: iPhoneX (iOS 12.1 Beta), iPhone 7(iOS 11.4.1)

bookmark window animation dismisses smooth now, looks good

Link to video:
https://drive.google.com/file/d/1frttdiexmoE6gd3pO4nNNJjKoAeN_8qd/view?usp=sharing

Sign in to add a comment