Issue metadata
Sign in to add a comment
|
Regression : Save password key icon is not seen in omnibox.
Reported by
rp...@etouch.net,
Oct 24
|
||||||||||||||||||||||
Issue descriptionChrome version: 72.0.3590.0 (Official Build)Revision ec242826af28a2b3c3b47390ab6141cfe26fe9e7-refs/branch-heads/3590@{#1}(64-bit) OS: Mac(10.13.6) What steps will reproduce the problem? 1. Launch chrome, navigate to www.facebook.com 2. Now type any password in 'Password' field and observe in omnibox Actual Result: Save password key icon is not seen in omnibox Expected Result: Save password key icon should be seen in omnibox This is a Mac(10.13.6) specific regression issue broken in ‘M-71’ and below is the bisect info: Good build: 71.0.3574.0 (Revision: 597693) Bad build : 71.0.3575.0 (Revision: 597882) CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/71.0.3574.0..71.0.3575.0?pretty=fuller&n=10000 Suspecting: r597742 ? @orinj: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Note: 1)Unable to provide the bisect using Per revision script and Chromium bisect both hence provided the suspect from Change Log. 2)Tried per revision bisect on Windows ,Mac and Linux OS but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect" error 3)Issue is not reproducible on Chromium builds Hence unable to provide the Chromium bisect. 4)Issue is not seen on Windows(7,8,8.1,10) , Linux (14.04 LTS) OS and Mac (10.13.1,10.14.1) 5)Issue is also seen on Dev build #71.0.3578.20 Thank You..!!
,
Oct 24
,
Oct 24
,
Oct 24
I can't reproduce it on Mac Canary 72.0.3590.0. It might be dependent on the some flags. rpise@ Could you please record password manager logs? For this could you please do the following steps? 1.Open chrome://password-manager-internals in one tab 2.Open facebook in another tab and type something in a password field 3.Return back to the first tab and copy/save the content (it's Password Manager logs, no private information) and attach it to the bug
,
Oct 24
Moved self to CC and passed ownership to alancutter@ for recent changes in ManagePasswordsIconViews . It's not that I suspect the changes there directly, but they appear close to event handling that might be related. If this issue only happens on Mac, then maybe some platform-specific implementation is not behaving as expected.
,
Oct 25
With respond to comment #4: Re-tested this issue on Mac(10.13.6)using Canary build #72.0.3590.0 and the issue is still reproducible. @dvadym : Kindly find the attached Password Manager logs file for the same. Thank you.
,
Oct 25
Thanks for attached logs! I don't see anything wrong from logs in Password Manager code. rpise@ Could you please attach variations hash codes from chrome://flags? It might be because of some flag.
,
Oct 25
chrome://version/ contents may also be useful in understanding the exact Chrome environment (variations, etc.).
,
Oct 25
Sorry, in #7 I meant chrome://version not chrome://flags
,
Oct 26
Tested on Mac 72.0.3591.0 with all flags set to default. Unable to repro the bug shown in the video. The key icon appears as soon as data is entered into the password field.
,
Oct 26
With response to comment #7 and #10 : Rechecked this issue on Mac (10.13.6) using latest Canary build #72.0.3592.0 and the issue is not reproducible i.e key icon is seen in omnibox after typing in 'Password' fields. Note : I have shown the variations in attached screen cast. Attaching screen cast for the same. Thank you..!!
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
M71 Stable promotion is coming VERY soon. Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Oct 29
rpise@ is this issue still reproducible in the current beta? If yes, please copy variations (as text) to this bug (it's hard to get them from a video). It might have been fixed in stable but still available in beta or there are different variations in beta and canary instances.
,
Oct 30
With response to comment #14: Rechecked this issue on latest Beta build # 72.0.3590.0 and the issue is not reproducible with below steps : 1. Freshly launch chrome and Enter the Key chain password and click on 'Allow' button when key chain password authentication dialog box appears. 2. Now navigate to www.facebook.com and enter password in 'Password' field and observe in omnibox. Note : Just to add in Good build (71.0.3574.0) key chain password authentication dialog box did not appear for every fresh launch of Chrome.Hence there was no issue then. Kindly refer the attached screen cast for same. Thank you..!!
,
Oct 30
In addition to comment #15: Rechecked this issue on Mac (10.13.6) OS.
,
Oct 30
Sounds like this is a no repro. Thanks for double checking. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by orinj@google.com
, Oct 24