New issue
Advanced search Search tips

Issue 898462 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

The parsing and output of the AEC3 parameter for using dominant nearend is missing

Project Member Reported by peah@chromium.org, Oct 24

Issue description

The parsing and output of the AEC3 parameter for using dominant nearend is missing.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/fb5c1eca300efee691a6d1c02b78549dec498eda

commit fb5c1eca300efee691a6d1c02b78549dec498eda
Author: Per Åhgren <peah@webrtc.org>
Date: Wed Oct 24 11:38:40 2018

AEC3: Included missing parsing of config parameter


Bug:  webrtc:9912 , chromium:898462 
Change-Id: I8efb60367964d3880ba15ffd18349abd288d7307
Reviewed-on: https://webrtc-review.googlesource.com/c/107654
Commit-Queue: Per Åhgren <peah@webrtc.org>
Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25332}
[modify] https://crrev.com/fb5c1eca300efee691a6d1c02b78549dec498eda/api/audio/echo_canceller3_config_json.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaf94be85de383888ed92a877fb8dbc454d09170

commit eaf94be85de383888ed92a877fb8dbc454d09170
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 24 16:41:44 2018

Roll src/third_party/webrtc 8e6749e0dd3f..62ae178357b7 (10 commits)

https://webrtc.googlesource.com/src.git/+log/8e6749e0dd3f..62ae178357b7


git log 8e6749e0dd3f..62ae178357b7 --date=short --no-merges --format='%ad %ae %s'
2018-10-24 titovartem@webrtc.org Remove deprecated pipe field from VideoQualityTestFixtureInterface::Params
2018-10-24 mbonadei@webrtc.org Revert "Encode RTC event logs in new format."
2018-10-24 titovartem@webrtc.org Remove deprecated DefaultNetworkSimulationConfig
2018-10-24 mbonadei@webrtc.org Use checkdeps to ensure API headers don't include internal headers.
2018-10-24 titovartem@webrtc.org Remove deprecated API: NetwrokSimulationInterface.
2018-10-24 eladalon@webrtc.org Add support for optional fields in FixedLengthDeltaEncoder
2018-10-24 nisse@webrtc.org Fix w3c URL for RTCIceTransport
2018-10-24 ilnik@webrtc.org Forward audio rtp frequency to Rtcp sender and use it for SR packets
2018-10-24 terelius@webrtc.org Encode RTC event logs in new format.
2018-10-24 peah@webrtc.org AEC3: Included missing parsing of config parameter


Created with:
  gclient setdep -r src/third_party/webrtc@62ae178357b7

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:898462
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5520aeb8a451c848b3a73d41741ce1d30c606be0
Reviewed-on: https://chromium-review.googlesource.com/c/1297347
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602368}
[modify] https://crrev.com/eaf94be85de383888ed92a877fb8dbc454d09170/DEPS

Status: Fixed (was: Started)

Sign in to add a comment