New issue
Advanced search Search tips

Issue 898456 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug
Flaky-Test: external/wpt/requestidlecallback/callback-idle-periods.html



Sign in to add a comment

external/wpt/requestidlecallback/callback-idle-periods.html is flaky

Project Member Reported by Findit, Oct 24

Issue description


Flaky test: external/wpt/requestidlecallback/callback-idle-periods.html
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/5880
Test output log: https://chromium-swarm.appspot.com/task?id=40bd7de8bb24ea10
Culprit (70.0% confidence): r602150
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS81ODgwL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvWlhoMFpYSnVZV3d2ZDNCMEwzSmxjWFZsYzNScFpHeGxZMkZzYkdKaFkyc3ZZMkZzYkdKaFkyc3RhV1JzWlMxd1pYSnBiMlJ6TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20external/wpt/requestidlecallback/callback-idle-periods.html&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy1wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKgAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS81ODgwL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvWlhoMFpYSnVZV3d2ZDNCMEwzSmxjWFZsYzNScFpHeGxZMkZzYkdKaFkyc3ZZMkZzYkdKaFkyc3RhV1JzWlMxd1pYSnBiMlJ6TG1oMGJXdz0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Cc: pdr@chromium.org
Hm, that CL does look plausibly related. OTOH, the test is already marked as Timeout on Windows, see bug 666993.

Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external/wpt/requestidlecallback/callback-idle-periods.html

Summary: The test has been timing out on Win Dbg for a long time. It recently started timing out on Mac Dbg (reported here), and there are a few recent timeouts on Linux Dbg as well.
So maybe we should just change the timeout expectation from "Win" to "Debug"? Though it does seem like this CL has regressed it.

pdr@, any input? Could your CL have caused the recent timeouts?
Components: Blink>Scheduling
Labels: OS-Linux OS-Mac OS-Windows
Updating the test expectation at https://chromium-review.googlesource.com/c/chromium/src/+/1297146.

Assigning to pdr@ to investigate whether/how the "culprit" CL actually made this worse on Mac.
Cc: -pdr@chromium.org
Owner: pdr@chromium.org
Status: Started (was: Untriaged)
Looking into this now.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17293893a9023f50e31d7981237a1dc27e24ee6c

commit 17293893a9023f50e31d7981237a1dc27e24ee6c
Author: Marc Treib <treib@chromium.org>
Date: Wed Oct 24 15:01:56 2018

external/wpt/requestidlecallback/callback-idle-periods.html flakily times out in Debug

The test was previously marked as timing out on Windows. However:
- It does occasionally pass.
- It doesn't actually time out on Windows Release.
- It does time out in Debug builds on other platforms though.

TBR=pdr@chromium.org

Bug: 666993, 898456
Change-Id: I5071af34d4fdb8bed911e864b28ce81eb954fff0
Reviewed-on: https://chromium-review.googlesource.com/c/1297146
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602339}
[modify] https://crrev.com/17293893a9023f50e31d7981237a1dc27e24ee6c/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Thanks!
Taking out of the sheriff queue.
Status: Assigned (was: Started)
I'm unable to reproduce this locally (1000 runs passed) so it's difficult to say what has increased the flakiness. I suspect my patch changed timing so that the existing test flakiness started showing up on other bots. If that's true, I'd like to assign this to the original test author. It's possible that my patch has some pathological performance issues with a no-op raf loop, so I'd like to leave this assigned to me temporarily as I work through the other failures related to my change.

Sign in to add a comment