Regression :[Print Preview]Unnecessary 'All' radio button gets selected on pressing 'Enter' key from Numpad.
Reported by
rp...@etouch.net,
Oct 24
|
|||
Issue descriptionChrome version: 72.0.3590.0 (Official Build)Revision ec242826af28a2b3c3b47390ab6141cfe26fe9e7-refs/branch-heads/3590@{#1}(32/64-bit) OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.14.1,10.13.6) What steps will reproduce the problem? 1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview 2. Now click on Pages text field and press 'Enter' key from 'Numpad' and observe 'All' radio button Actual Result: 1. Unnecessary 'All' radio button gets selected on pressing 'Enter' key from Numpad 2. 'All' radio button appears selected and text caret is seen blinking in 'Pages' text field Expected Result: 'All' radio button shouldn't get selected on pressing 'Enter' key from Numpad This is regression issue broken in ‘M-71’ and below is the bisect info: Good build: 71.0.3561.0 (Revision: 593802) Bad build : 71.0.3562.0 (Revision: 594163) You are probably looking for a change made after 594074 (known good), but no later than 594081 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/240cf0f47b7d1b7c02530d01f96e070b21f5ebb5..914f0969a7737aa14faa6c496650e2c434715ceb?pretty=fuller&n=50 Suspecting: r594076 ? @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. Provided suspect through 'Chromium' bisect as unable to perform bisect using 'per-revision' bisect script 2. Tried performing 'per revision' bisect on multiple Windows,Linux and Mac machines but unable to perform the same since getting error: "RuntimeError: We don't have enough builds to bisect". 3. Issue is also seen on Dev build # 71.0.3578.20 Kindly refer attached screen cast for same. Thank you.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6bab25bb25f19fbf47223e3fa07ceb6847986620 commit 6bab25bb25f19fbf47223e3fa07ceb6847986620 Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 24 23:32:34 2018 Print Preview: Print on numpad enter Bug: 898444 Change-Id: Icadd1866dc0292993b6e52b06198363868af4a81 Reviewed-on: https://chromium-review.googlesource.com/c/1297458 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602521} [modify] https://crrev.com/6bab25bb25f19fbf47223e3fa07ceb6847986620/chrome/browser/resources/print_preview/new/app.js
,
Oct 25
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.1) using latest Canary build : 72.0.3591.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Oct 25
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/222f12d36368e8ca7cb42945e5a06f0e60cd3b39 commit 222f12d36368e8ca7cb42945e5a06f0e60cd3b39 Author: rbpotter <rbpotter@chromium.org> Date: Thu Oct 25 21:56:35 2018 Print Preview: Add tests for key event handling Bug: 898444 Change-Id: I483904f8d8f974b3354d89fd7fca581fc3dd202d Reviewed-on: https://chromium-review.googlesource.com/c/1298640 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602885} [modify] https://crrev.com/222f12d36368e8ca7cb42945e5a06f0e60cd3b39/chrome/browser/resources/print_preview/new/app.js [modify] https://crrev.com/222f12d36368e8ca7cb42945e5a06f0e60cd3b39/chrome/browser/resources/print_preview/new/link_container.js [add] https://crrev.com/222f12d36368e8ca7cb42945e5a06f0e60cd3b39/chrome/test/data/webui/print_preview/key_event_test.js [modify] https://crrev.com/222f12d36368e8ca7cb42945e5a06f0e60cd3b39/chrome/test/data/webui/print_preview/native_layer_stub.js [modify] https://crrev.com/222f12d36368e8ca7cb42945e5a06f0e60cd3b39/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/222f12d36368e8ca7cb42945e5a06f0e60cd3b39/testing/buildbot/filters/webui_polymer2_browser_tests.filter |
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, Oct 24