Update iOS version of SyncInternalsMessageHandler |
||||
Issue descriptionRecently (over the last few months), there have been a few additions to SyncInternalsMessageHandler which aren't reflected in its iOS instance yet; compare [1] to [2]. Some things the iOS version doesn't handle yet are RequestStart/Stop and TriggerRefresh. I'm not sure what exactly the corresponding buttons do right now - might be nothing, might DCHECK. I don't think there'd be any horrible effects in release builds. Still, let's try and get this fixed. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/sync_internals_message_handler.cc?rcl=a2cbe684522d3ded4e4694e0d16e9fcdc2bd15e8&l=99 [2] https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc?rcl=b836ad80bc4ca401166663002b872044d7f617f4&l=51
,
Oct 30
,
Nov 2
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57106083f6b2d6c39187c52ae8a82af4f5a6e703 commit 57106083f6b2d6c39187c52ae8a82af4f5a6e703 Author: Marc Treib <treib@chromium.org> Date: Mon Nov 05 13:08:26 2018 Update iOS version of SyncInternalsMessageHandler This adds message handlers for a few things that were added semi-recently to the non-iOS version. Also includes a few tiny cleanups to the non-iOS message handler. Bug: 898439 Change-Id: I38dc6d643c1b9ad6fd3608d8a4ed799385d7d946 Reviewed-on: https://chromium-review.googlesource.com/c/1315209 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#605308} [modify] https://crrev.com/57106083f6b2d6c39187c52ae8a82af4f5a6e703/chrome/browser/ui/webui/sync_internals_message_handler.cc [modify] https://crrev.com/57106083f6b2d6c39187c52ae8a82af4f5a6e703/chrome/browser/ui/webui/sync_internals_message_handler.h [modify] https://crrev.com/57106083f6b2d6c39187c52ae8a82af4f5a6e703/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc [modify] https://crrev.com/57106083f6b2d6c39187c52ae8a82af4f5a6e703/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h
,
Nov 5
|
||||
►
Sign in to add a comment |
||||
Comment 1 Deleted