UMA histogram Sync.InitialState broken in M70+ |
||
Issue descriptionhttps://crrev.com/c/1162174 changed SyncAuthManager::GetActiveAccountInfo() to only return a non-empty value after RegisterForAuthNotifications() has been called. Unfortunately, that happens just *after* we have recorded Sync.InitialState in ProfileSyncService::Initialize(). The consequence is that we'll always record "not signed in" simply because the active account hasn't been initialized yet.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58505ca736e7aff6c89e8f48904b028bdf088f62 commit 58505ca736e7aff6c89e8f48904b028bdf088f62 Author: Marc Treib <treib@chromium.org> Date: Wed Oct 24 10:43:07 2018 Fix UMA histogram Sync.InitialState Before SyncAuthManager::RegisterForAuthNotifications(), the active/authenticated account isn't initialized, so the histogram would always record "not signed in". So make sure we record the histogram only after registering for auth. Bug: 898430 Change-Id: I00064541cefe6cb65d5a246f12c7a8eaef469c28 Reviewed-on: https://chromium-review.googlesource.com/c/1297420 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602291} [modify] https://crrev.com/58505ca736e7aff6c89e8f48904b028bdf088f62/components/browser_sync/profile_sync_service.cc
,
Oct 24
That should fix it. We could try to merge the fix to M71, but since it's already kinda late in the cycle for a non-critical merge, and nobody seems to urgently need the histogram data, I'm inclined to just let it roll out with M72. If anyone disagrees, let me know! |
||
►
Sign in to add a comment |
||
Comment 1 by treib@chromium.org
, Oct 24