New issue
Advanced search Search tips

Issue 898423 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Implement Image Processor class using Intel VPP

Project Member Reported by hiroh@chromium.org, Oct 24

Issue description

Intel VPP which only performs pixel format conversion will be required in the future.
The class would be a derived class of ImageProcessor.
In the class, VaapiWrapper should be created without specifying mode and profile.

[1] https://cs.chromium.org/chromium/src/media/gpu/image_processor.h
 
Cc: -deanliao@google.com mcasas@chromium.org deanliao@chromium.org
First CL to introduce Vpp mode in VaapiWrapper is uploaded.
https://chromium-review.googlesource.com/c/chromium/src/+/1348869
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f429309308523dc26b0ff49c1acb2977dd5727d

commit 6f429309308523dc26b0ff49c1acb2977dd5727d
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Dec 20 04:15:24 2018

media/gpu/vaapi/VaapiWrapper: Add kVpp mode and get rid of vpp specific variables

VaapiWrapper does initializetion for VPP (Video Post Processing) in the same
VaapiWrapper instance that is created for kDecode. VaapiWrapper thus has
VAConfigID, VAContextID, VABufferID especially for VPP. We would rather process
VPP in another VaapiWrapper. kVpp mode is added for this purpose.

Bug: 898423
Test: VDA unittest on eve
Change-Id: I35d4198dc6285d356987b4b4b6e4f90bd5e59cd1
Reviewed-on: https://chromium-review.googlesource.com/c/1348869
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618106}
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_jpeg_encode_accelerator.cc
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_video_decode_accelerator.h
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_video_decode_accelerator_unittest.cc
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_wrapper.cc
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/media/gpu/vaapi/vaapi_wrapper.h
[modify] https://crrev.com/6f429309308523dc26b0ff49c1acb2977dd5727d/tools/metrics/histograms/enums.xml

Sign in to add a comment