This is a tracker bug of removing old System Tray code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f590c5d6b83d82969255f9a9405e2d881a0f7b68 commit f590c5d6b83d82969255f9a9405e2d881a0f7b68 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Oct 25 01:30:28 2018 Unified: Remove SystemTrayUnified flag. This CL removes SystemTrayUnified flag. This is the part 1 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=manual BUG= 898419 Change-Id: I7a24d57afe7d39d437a17c475e5f6be330f0351e Reviewed-on: https://chromium-review.googlesource.com/c/1297778 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#602561} [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/ash/public/cpp/ash_features.cc [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/ash/public/cpp/ash_features.h [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/ash/system/tracing_notification_controller_unittest.cc [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/ash/system/update/update_notification_controller_unittest.cc [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/chrome/browser/about_flags.cc [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/f590c5d6b83d82969255f9a9405e2d881a0f7b68/chrome/browser/flag_descriptions.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e73c24c26252c5bd2c2ce538db6fc4f8e725084 commit 3e73c24c26252c5bd2c2ce538db6fc4f8e725084 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Oct 29 02:59:55 2018 Remove SystemTrayUnified checks on chrome side. This CL removes references to IsSystemTrayUnifiedEnabled in chrome/browser/. tray_accessibility_browsertest and first_run_controller are intentionally left as the first one will be moved to ash/, and the second one will be updated in a separate CL. This is the part 2 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=trybot pass BUG= 898419 Change-Id: Ib1d046bae25a61354bba5dd8d0ce62ba938c015f Reviewed-on: https://chromium-review.googlesource.com/c/1301054 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603405} [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/chromeos/login/ui/DEPS [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/ui/ash/system_tray_client_browsertest.cc [modify] https://crrev.com/3e73c24c26252c5bd2c2ce538db6fc4f8e725084/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d013252e69b3c1576c71fe7ac203a5d750b11cc0 commit d013252e69b3c1576c71fe7ac203a5d750b11cc0 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Oct 29 03:08:37 2018 ash: Remove all IsSystemTrayUnifiedEnabled checks This CL removes all references to IsSystemTrayUnifiedEnabled in ash. Files that will be removed entirely are intentionally excluded from this CL. References from chrome/ will be removed in another CL. This is the part 2 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=trybot pass BUG= 898419 Change-Id: Ib8ce6f594ab3800bec7e5e746e126f1675fb1800 Reviewed-on: https://chromium-review.googlesource.com/c/1298943 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603407} [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/extended_desktop_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/first_run/first_run_helper.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/login/login_screen_controller_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/mojo_test_interface_factory.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/public/cpp/network_icon_image_source.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/resources/vector_icons/BUILD.gn [delete] https://crrev.com/a1c7e285bfd55d42c0e431c8a6fe6c077ae7a0bf/ash/resources/vector_icons/system_tray_battery_alert.icon [delete] https://crrev.com/a1c7e285bfd55d42c0e431c8a6fe6c077ae7a0bf/ash/resources/vector_icons/system_tray_battery_bolt.icon [delete] https://crrev.com/a1c7e285bfd55d42c0e431c8a6fe6c077ae7a0bf/ash/resources/vector_icons/system_tray_battery_unreliable.icon [delete] https://crrev.com/a1c7e285bfd55d42c0e431c8a6fe6c077ae7a0bf/ash/resources/vector_icons/system_tray_battery_x.icon [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/root_window_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/caps_lock_notification_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/caps_lock_notification_controller.h [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/cast/cast_notification_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/date/date_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/date/date_view.h [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/ime_menu/ime_list_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/message_center/arc/arc_notification_content_view_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/message_center/arc_notification_manager_delegate_impl.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/message_center/message_center_scroll_bar.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/message_center/notifier_settings_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/model/system_tray_model.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/network/network_icon.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/network/network_list.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/network/network_row_title_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/network/vpn_list_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/power/power_status.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/screen_security/screen_security_notification_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/status_area_widget.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/status_area_widget.h [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/status_area_widget_delegate.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/system_notification_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tracing_notification_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_constants.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_constants.h [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_container.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_detailed_view.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_event_filter_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_popup_item_style.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/tray/tray_popup_utils.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/unified/unified_system_tray_unittest.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/system/update/update_notification_controller.cc [modify] https://crrev.com/d013252e69b3c1576c71fe7ac203a5d750b11cc0/ash/wm/overview/window_selector_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adfc68583d725b7eeb02acad483672f37fdf0622 commit adfc68583d725b7eeb02acad483672f37fdf0622 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 30 01:36:16 2018 Unified: Remove SystemTrayItem ref in TrayItemView This CL removes SystemTrayItem dependency from TrayItemView. SystemTrayItems will be removed with old SystemTray while TrayItemViews will remain. TEST=manual BUG= 898419 Change-Id: Icd14cb942c7f33f07b198c80435a17f41908f9d8 Reviewed-on: https://chromium-review.googlesource.com/c/1304281 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603724} [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/date/tray_system_info.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/date/tray_system_info.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/network/network_tray_view.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/network/network_tray_view.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/network/tray_network.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/power/tray_power.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/power/tray_power.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/tray/tray_item_view.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/tray/tray_item_view.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/ime_mode_view.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/ime_mode_view.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/managed_device_view.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/managed_device_view.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/notification_counter_view.cc [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/notification_counter_view.h [modify] https://crrev.com/adfc68583d725b7eeb02acad483672f37fdf0622/ash/system/unified/unified_system_tray.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c356944952c7388af8967f45f6eac486382ceea commit 5c356944952c7388af8967f45f6eac486382ceea Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 30 01:44:53 2018 first_run: Remove old System Tray support. This CL removes old System Tray support in first_run tutorial. In UnifiedSystemTray, we don't have HelpStep in the tutorial, so this CL removes HelpStep related code. This is the part 2 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TBR=alemate@chromium.org TEST=trybot pass BUG= 898419 Change-Id: I97df2f9de526e0e9b443d0728a3e16e759699da5 Reviewed-on: https://chromium-review.googlesource.com/c/1301137 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#603729} [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/ash/first_run/first_run_helper.cc [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/ash/first_run/first_run_helper.h [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/ash/public/interfaces/first_run_helper.mojom [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/chromeos/first_run/chromeos_first_run_browsertest.cc [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/chromeos/first_run/first_run_controller.cc [delete] https://crrev.com/e4b9336e052b7ca8f2e944e5faa524dd3e4df743/chrome/browser/chromeos/first_run/steps/help_step.cc [delete] https://crrev.com/e4b9336e052b7ca8f2e944e5faa524dd3e4df743/chrome/browser/chromeos/first_run/steps/help_step.h [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/resources/chromeos/first_run/first_run.html [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/resources/chromeos/first_run/first_run.js [delete] https://crrev.com/e4b9336e052b7ca8f2e944e5faa524dd3e4df743/chrome/browser/resources/chromeos/first_run/help_step.html [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/resources/chromeos/first_run/step.js [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/resources/chromeos/first_run/tray_step.html [modify] https://crrev.com/5c356944952c7388af8967f45f6eac486382ceea/chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/563458d2b9d99e93af336de77d22a443f37ec089 commit 563458d2b9d99e93af336de77d22a443f37ec089 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 30 03:31:11 2018 ash: Remove NotificationTray. This CL removes NotificationTray because now it's replaced by UnifiedSystemTray. This is the part 3 of removing old System Tray (+Notification Tray) code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray I'll try to keep the number of CLs as small as possible to make the history clean, but there can be multiple CLs for both part 2 and part 3 because some of them requires nontrivial refactoring to remove the dependency to the old code. TEST=trybot pass BUG= 898419 Change-Id: I90f2904161aa453a0048947bf22bf31158d9442f Reviewed-on: https://chromium-review.googlesource.com/c/1304184 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#603773} [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/BUILD.gn [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/accessibility/key_accessibility_enabler_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/media/media_notification_view_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/session/session_controller_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/shelf/shelf_view_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/shell.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/shell.h [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/shell/window_type_launcher.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/caps_lock_notification_controller_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/message_center/arc/arc_notification_content_view_unittest.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_bubble.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_bubble.h [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_button_bar.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_button_bar.h [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/message_center/message_center_style.h [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_view.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_view.h [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_center_view_unittest.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_list_view.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_list_view.h [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/message_list_view_unittest.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/notification_tray.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/notification_tray.h [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/notification_tray_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/message_center/notifier_settings_view.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/message_center/notifier_settings_view.h [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/slidable_message_view.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/message_center/slidable_message_view.h [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/screen_layout_observer_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/status_area_widget.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/status_area_widget.h [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/tray/system_tray.cc [modify] https://crrev.com/563458d2b9d99e93af336de77d22a443f37ec089/ash/system/tray/system_tray_unittest.cc [delete] https://crrev.com/5a306bfce1055ab88722d4c29707ec1b08268a03/ash/system/tray_caps_lock_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb2a89dd86c9cb96737403cc6625c1d6ef6be295 commit cb2a89dd86c9cb96737403cc6625c1d6ef6be295 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 30 07:18:41 2018 exo: Remove UnifiedSystemTray check in test. As UnifiedSystemTray is launched and the flag is removed, we can now remove the old SystemTray related test in exo_unittests. TEST=exo_unittests BUG= 898419 Change-Id: I4843424856f1149aaf945594cad4d2dbaba33e9b Reviewed-on: https://chromium-review.googlesource.com/c/1307027 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#603818} [modify] https://crrev.com/cb2a89dd86c9cb96737403cc6625c1d6ef6be295/components/exo/client_controlled_shell_surface_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4e124ec48cedabb8e5116204edc3dc29d01d647 commit d4e124ec48cedabb8e5116204edc3dc29d01d647 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Fri Nov 02 06:15:03 2018 bluetooth: Delete deprecated TrayBluetooth code Patch to remove the no longer used TrayBluetooth code. Bug: 898419 Change-Id: I3f2393dc562a91b42345d107f6faf3292124d232 Reviewed-on: https://chromium-review.googlesource.com/c/1312137 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#604854} [modify] https://crrev.com/d4e124ec48cedabb8e5116204edc3dc29d01d647/ash/BUILD.gn [delete] https://crrev.com/d1fb11bda465e0a778c8a8d6a2c10a8c19a84348/ash/system/bluetooth/tray_bluetooth.cc [delete] https://crrev.com/d1fb11bda465e0a778c8a8d6a2c10a8c19a84348/ash/system/bluetooth/tray_bluetooth.h [modify] https://crrev.com/d4e124ec48cedabb8e5116204edc3dc29d01d647/ash/system/tray/system_tray.cc [modify] https://crrev.com/d4e124ec48cedabb8e5116204edc3dc29d01d647/ash/system/tray/system_tray.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d commit 79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Mon Nov 05 05:48:44 2018 Unified: Remove old SystemTray This CL removes all remaining old SystemTray related code. This is the part 3 of removing old System Tray code. (1) Removing the flag (2) Removing references to IsSystemTrayUnifiedEnabled() (3) Removing classes that are only used in old System Tray It's the last CL for this cleanup. TBR=oshima@chromium.org TEST=trybot pass BUG= 898419 Change-Id: Ib64a3c31f0d63221f4289b8fe66e39c05ed2d83a Reviewed-on: https://chromium-review.googlesource.com/c/1307354 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#605257} [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/BUILD.gn [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/extended_desktop_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/focus_cycler_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/login/login_screen_controller_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/login/ui/login_password_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/public/cpp/ash_features.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/public/cpp/ash_features.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/public/cpp/ash_switches.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/root_window_controller.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/root_window_controller.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/session/session_controller_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/shelf/shelf_layout_manager_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/shelf/shelf_widget.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/shelf/shelf_widget_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/shell.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/shell.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/accessibility/tray_accessibility.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/accessibility/tray_accessibility.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/audio/tray_audio.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/audio/tray_audio.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/audio/tray_audio_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/audio/volume_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/audio/volume_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/brightness/tray_brightness.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/brightness/tray_brightness.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/brightness/tray_brightness_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/brightness/unified_brightness_slider_controller.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/cast/tray_cast.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/cast/tray_cast.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/date/date_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/date/date_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/date/system_info_default_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/date/system_info_default_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/date/system_info_default_view_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/date/tray_system_info.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/date/tray_system_info.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/display_scale/scale_detailed_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/display_scale/scale_detailed_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/display_scale/scale_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/display_scale/scale_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/display_scale/tray_scale.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/display_scale/tray_scale.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/enterprise/tray_enterprise.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/enterprise/tray_enterprise.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/enterprise/tray_enterprise_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/ime/tray_ime_chromeos.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/ime/tray_ime_chromeos.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/ime/tray_ime_chromeos_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/ime_menu/ime_list_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/keyboard_brightness/tray_keyboard_brightness.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/keyboard_brightness/tray_keyboard_brightness.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/keyboard_brightness/tray_keyboard_brightness_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/media_security/multi_profile_media_tray_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/media_security/multi_profile_media_tray_item.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/media_security/multi_profile_media_tray_item_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/network/network_state_list_detailed_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/network/network_tray_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/network/tray_network.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/network/tray_network.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/network/tray_network_state_observer.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/network/tray_vpn.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/network/tray_vpn.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/night_light/tray_night_light.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/night_light/tray_night_light.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/night_light/tray_night_light_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/power/tray_power.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/power/tray_power.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/rotation/tray_rotation_lock.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/rotation/tray_rotation_lock.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/rotation/tray_rotation_lock_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_capture_tray_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_capture_tray_item.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_share_tray_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_share_tray_item.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_tray_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_tray_item.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/screen_security/screen_tray_item_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/session/tray_session_length_limit.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/session/tray_session_length_limit.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/session/tray_session_length_limit_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/status_area_widget.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/status_area_widget.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/status_area_widget_delegate.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/status_area_widget_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/supervised/tray_supervised_user.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/supervised/tray_supervised_user.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/supervised/tray_supervised_user_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tiles/tiles_default_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tiles/tiles_default_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tiles/tray_tiles.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tiles/tray_tiles.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tiles/tray_tiles_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/actionable_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/actionable_view.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/hover_highlight_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/system_menu_button.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_bubble.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_bubble.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_item.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_item_detailed_view_delegate.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_item_detailed_view_delegate.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/system_tray_notifier.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_test_api.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_test_api.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/system_tray_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/test_system_tray_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/test_system_tray_item.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/tray_background_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/tray_detailed_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/tray_detailed_view_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/tray_image_item.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/tray_image_item.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/tray_info_label.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/tray_item_more.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray/tray_item_more.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/tray_item_view.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/tray/tray_item_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray_caps_lock.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray_caps_lock.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray_tracing.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray_tracing.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/tray_tracing_unittest.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/unified/unified_detailed_view_delegate.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/system/unified/unified_system_tray.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/update/tray_update.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/update/tray_update.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/update/tray_update_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/button_from_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/button_from_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/tray_user.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/tray_user.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/tray_user_unittest.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/user_card_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/user_card_view.h [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/user_view.cc [delete] https://crrev.com/919287d0a1eda09af61b4115352269a1d256617b/ash/system/user/user_view.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/test/ash_test_base.cc [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/ash/test/ash_test_base.h [modify] https://crrev.com/79593b477c5ec0e561bc8cccc6e84ac0bb8f4e5d/components/exo/client_controlled_shell_surface_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Oct 25