Add link to layout test results to webkit_layout_tests step output |
||
Issue description1. Open https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20Leak/25668 2. Check Non-Green. 3. Look for test results for failure virtual/threaded/http/tests/devtools/tracing/timeline-misc/timeline-window-filter.js. Expected: A link to https://test-results.appspot.com/data/layout_results/WebKit_Linux_Trusty_Leak/25668/webkit_layout_tests/layout-test-results/results.html Actual: You have to check Collapsed and search for the "archive results for webkit_layout_tests" step. I suspect many Chrome developers don't know about this magic step and have a harder time dealing with layout test failures than need be. Given the link doesn't appear to contain any unknowables in it at the time of running the tests can the webkit_layout_tests step generate it as part of its output? Something hardcoded and fragile is still better than needing all sheriffs to know about the archive step.
,
Oct 25
It also doesn't exist until archive results for webkit_layout_tests completes, so I'd be reluctant to do this. "Something hardcoded and fragile" typically winds up being a maintenance headache for us before long...
,
Oct 26
Tentatively WontFixing given #2. If this is something we want to pursue in some capacity, we would do so by integrating the archival into the layout tests merge script & then adding the link to the results JSON. +nednguyen is spinning up on layout tests and would likely be involved in that.
,
Oct 29
If you want a quick hack, the recipes can also turn the "Upload to test-results" step red if webkit layout tests failed.
,
Oct 30
#4: That sounds like a good quick hack. |
||
►
Sign in to add a comment |
||
Comment 1 by nodir@google.com
, Oct 24Components: -Infra>Platform>Milo Infra>Client>Chrome