Support ctrl modifier on reload button
Reported by
jeffreyc...@gmail.com,
Oct 24
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 Safari/537.36 Steps to reproduce the problem: 1. Enable Reload button 2. Do Ctrl+Click Reload on current page 3. What is the expected behavior? New tab for current page should open in the background. This is consistent with Ctrl+Clicking links and bookmarks. What went wrong? The current page is reloaded. Did this work before? N/A Chrome version: 70.0.3538.67 Channel: stable OS Version: 10.0 Flash Version:
,
Oct 24
,
Oct 24
,
Oct 24
Thanks for filing the issue! Considering the case: Ctrl+Click Reload on current page & Ctrl + Shift + Reload Able to reproduce the issue on reported chrome version 70.0.3538.67 and on the latest canary 72.0.3589.0 using Windows 10 and ubuntu 14.04 Note: Issue isn't applicable to Mac As similar behaviour is seen from M60(60.0.3112.0) considering it as Non-Regression and marking it as Untriaged.
,
Oct 24
@1: Shift-reload has a different meaning than shift-clicking links (it does a full validation of the underlying resources). This predates click modifiers on links and so can't really be easily changed. We do support middle-clicking reload to duplicate to a new background tab. I'd be OK with doing the same thing for ctrl. Notably, ctrl-clicking the back button already does the desired thing.
,
Oct 25
,
Oct 25
I want to resolve this issue. I think this issue seems to have arisen because of masking off Shift and Ctrl flag in ReloadButton::ButtonPressed(). Shift-clicking the back button supports to open Webcontents in new window. But, shift-clicking the reload button can't work that. Is it right? If it is right, Can I patch for this issue?
,
Oct 25
,
Oct 25
We don't expect this to be a common case scenario, so we're going to WontFix at this time.
,
Oct 25
But the behaviour is available on Mac, will you be removing the Cmd+Reload functionality too? |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jeffreyc...@gmail.com
, Oct 24