Remove navigationManagerImpl from tab |
|||||||
Issue descriptionnavigationManagerImpl, this method is implemented in tab.mm and defined on private_tab.h originally the whole private_tab was meant for tests only now it's used on other places too. Remove the use of that method and remove the private_tab include from where its not needed any more.
,
Oct 24
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d commit b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d Author: mrefaat <mrefaat@chromium.org> Date: Wed Oct 24 20:10:05 2018 [IOSTabRefactoring] Remove navigationManagerImpl from tab & private_tab Use webstateImpl method for tests instead. Also remove tab_private includes where it's no longer used Bug: 620465, 898381 Change-Id: I0db31eecf93eef1f8e88aa4428f16f25ff3a03b7 Reviewed-on: https://chromium-review.googlesource.com/c/1298243 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#602426} [modify] https://crrev.com/b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d/ios/chrome/browser/tabs/tab_private.h [modify] https://crrev.com/b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d/ios/chrome/browser/tabs/tab_unittest.mm [modify] https://crrev.com/b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/b5f825b943c90f6397aa6a60eddc0a0d3ea80a1d/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm
,
Oct 24
,
Oct 24
,
Oct 24
,
Oct 25
,
Oct 29
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mrefaat@chromium.org
, Oct 24