New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898373 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Abrt in rtc::webrtc_checks_impl::FatalLog

Project Member Reported by ClusterFuzz, Oct 24

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4656698483277824

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390030581f
Crash State:
  rtc::webrtc_checks_impl::FatalLog
  CallCheckOp<rtc::webrtc_checks_impl::Val<rtc::webrtc_checks_impl::CheckArgType::
  CallCheckOp<rtc::webrtc_checks_impl::Val<rtc::webrtc_checks_impl::CheckArgType::
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=601948:601949

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4656698483277824

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 24

Cc: kwiberg@webrtc.org mflodman@webrtc.org henrika@webrtc.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 2 by ClusterFuzz, Oct 24

Cc: yvesg@webrtc.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

[Cleanup] Add missing #include. Remove useless ones. by yvesg@webrtc.org - https://webrtc.googlesource.com/src/+/988cc0870bb49c855b4547f929462eeb38186d12

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: jonasolsson@webrtc.org kkaluri@chromium.org
Components: Blink>WebRTC
Labels: M-72
Owner: jonasolsson@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "rtc_base/checks.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://webrtc.googlesource.com/src.git/+/5c3cf05788cecdc3eabda824ce29c0abb3ee0646

jonasolsson@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/e068ad62628f0c79810a6e9b43d4cb92d0ac5987

commit e068ad62628f0c79810a6e9b43d4cb92d0ac5987
Author: Jonas Olsson <jonasolsson@webrtc.org>
Date: Wed Oct 24 09:27:18 2018

Use a sufficiently large bitmask.

The fuzzer uses a bitmask to construct the field trials string.
Now that there's 33 relevant field trials it's no longer large enough, so switch to a 64-bit type.

Bug:  chromium:898373 
Change-Id: I1ea68d451ceadbd9b720079a577b573866293e4b
Reviewed-on: https://webrtc-review.googlesource.com/c/107650
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Jonas Olsson <jonasolsson@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25330}
[modify] https://crrev.com/e068ad62628f0c79810a6e9b43d4cb92d0ac5987/test/fuzzers/audio_processing_configs_fuzzer.cc

@kkaluri: No, it's not directly related to my change. A while back I refactored the RTC_CHECK implementation, and now the fuzzers think I'm responsible for every failing check.

Anyway, this was a simple issue, so I wrote a fix. I'll wait for ClusterFuzz to close the bug.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85c7c5c4d28fe3acb51b7535860f56aa394cc8d8

commit 85c7c5c4d28fe3acb51b7535860f56aa394cc8d8
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 24 12:36:14 2018

Roll src/third_party/webrtc 700b4a4e65c2..e068ad62628f (4 commits)

https://webrtc.googlesource.com/src.git/+log/700b4a4e65c2..e068ad62628f


git log 700b4a4e65c2..e068ad62628f --date=short --no-merges --format='%ad %ae %s'
2018-10-24 jonasolsson@webrtc.org Use a sufficiently large bitmask.
2018-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5e5003737d..869181c2dc (602066:602275)
2018-10-24 kron@webrtc.org Increase the UDP receive buffer for video
2018-10-24 peah@webrtc.org APM: Correct includes required for the data dumping functionality


Created with:
  gclient setdep -r src/third_party/webrtc@e068ad62628f

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG= chromium:898373 ,chromium:None,chromium:b/115713113
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic8bbee1f85f9c0855a438de32e18e7bdd45df687
Reviewed-on: https://chromium-review.googlesource.com/c/1297337
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602309}
[modify] https://crrev.com/85c7c5c4d28fe3acb51b7535860f56aa394cc8d8/DEPS

Project Member

Comment 7 by ClusterFuzz, Oct 25

ClusterFuzz has detected this issue as fixed in range 602308:602309.

Detailed report: https://clusterfuzz.com/testcase?key=4656698483277824

Fuzzer: libFuzzer_audio_processing_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Abrt
Crash Address: 0x05390030581f
Crash State:
  rtc::webrtc_checks_impl::FatalLog
  CallCheckOp<rtc::webrtc_checks_impl::Val<rtc::webrtc_checks_impl::CheckArgType::
  CallCheckOp<rtc::webrtc_checks_impl::Val<rtc::webrtc_checks_impl::CheckArgType::
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=601948:601949
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=602308:602309

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4656698483277824

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Oct 25

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4656698483277824 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9516c385386f01b6c61bfbcc03801e601a6016e7

commit 9516c385386f01b6c61bfbcc03801e601a6016e7
Author: Yves Gerey <yvesg@webrtc.org>
Date: Thu Oct 25 13:21:31 2018

[Fuzzer] Check FieldTrial bitmask size at compile time.

Rather fail at compile time than at run-time.

Bug:  chromium:898373 
Bug: webrtc:9855
Change-Id: Iaae81e04e4a8135814c1226f82d3a994de75e9ad
Reviewed-on: https://webrtc-review.googlesource.com/c/107886
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Yves Gerey <yvesg@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25364}
[modify] https://crrev.com/9516c385386f01b6c61bfbcc03801e601a6016e7/test/fuzzers/audio_processing_configs_fuzzer.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d02490f7af131ae749b857c2e6f40a260e5c725

commit 7d02490f7af131ae749b857c2e6f40a260e5c725
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Oct 25 18:07:13 2018

Roll src/third_party/webrtc 1803bb247055..6c6c9df99db6 (8 commits)

https://webrtc.googlesource.com/src.git/+log/1803bb247055..6c6c9df99db6


git log 1803bb247055..6c6c9df99db6 --date=short --no-merges --format='%ad %ae %s'
2018-10-25 benwright@webrtc.org Refactor: Renaming ssl_cert_chain to GetSSLCertificateChain()
2018-10-25 srte@webrtc.org Adds target rate to audio send stream stats.
2018-10-25 terelius@webrtc.org Normalize baseline in network delay plot to RTT/2.
2018-10-25 nisse@webrtc.org Reland "Delete CodecNamesEq, replaced with absl::EqualsIgnoreCase"
2018-10-25 srte@webrtc.org Fixes bug in AudioPriorityBitrateAllocationStrategy field trial.
2018-10-25 srte@webrtc.org Adds BitrateAllocation struct to OnBitrateUpdated.
2018-10-25 nisse@webrtc.org Delete MessageData when a message is posted to a quitting MessageQueue
2018-10-25 yvesg@webrtc.org [Fuzzer] Check FieldTrial bitmask size at compile time.


Created with:
  gclient setdep -r src/third_party/webrtc@6c6c9df99db6

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:898373
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I0182341d47f3963be08f06565296055826f97959
Reviewed-on: https://chromium-review.googlesource.com/c/1299517
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#602790}
[modify] https://crrev.com/7d02490f7af131ae749b857c2e6f40a260e5c725/DEPS

Sign in to add a comment