New issue
Advanced search Search tips

Issue 898372 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

BitmapImageTest.DecoderAndCacheMipLevels fails on all bots

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 24

Issue description

Cc: pdr@chromium.org
Labels: -Sheriff-Chromium
Owner: jdragon....@gmail.com
Status: Assigned (was: Available)
Findit located the patch crrev.com/c/1296870 as culprit. PTAL and fix the test. Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8b29925ce72cd439f2db22afacefe5f0e4c27f2

commit f8b29925ce72cd439f2db22afacefe5f0e4c27f2
Author: Yi Gu <yigu@chromium.org>
Date: Wed Oct 24 02:24:44 2018

Disable BitmapImageTest.DecoderAndCacheMipLevels

This test started to fail after crrev.com/c/1296870 which was landed
4 hours ago. Disable the test and assign the bug to the owner.

TBR=jdragon.bae@gmail.com
NOTRY=true

Bug:  898372 
Change-Id: I7b3d8ba10535caed7226b295d74537ac7e5dfeda
Reviewed-on: https://chromium-review.googlesource.com/c/1297715
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602220}
[modify] https://crrev.com/f8b29925ce72cd439f2db22afacefe5f0e4c27f2/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc

Components: Blink>Paint
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a13937d9032be67b04ae7e10e97d47aba4df5918

commit a13937d9032be67b04ae7e10e97d47aba4df5918
Author: Jaeyong Bae <jdragon.bae@gmail.com>
Date: Thu Oct 25 07:31:16 2018

Reland "Move image resources for bitmap_image_test to /testing/data"

This is a reland of 3b3248dad4c63f2d1af803d8a51a9b6e7e1a0f33

Original change's description:
> Move image resources for bitmap_image_test to /testing/data
>
> This pacth means blink/renderer/platform/graphics/bitmap_image_test.cc
> loads images from blink/renderer/platform/testing/data.
> This will more cleanly separate the unit test and layout test data.
>
> Bug:  898155 
> Change-Id: I34f582f127df6fff8634aaff66893fb27abffaaa
> Reviewed-on: https://chromium-review.googlesource.com/c/1296870
> Reviewed-by: Philip Rogers <pdr@chromium.org>
> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
> Cr-Commit-Position: refs/heads/master@{#602168}

Bug:  898155 ,  898372 
Change-Id: If7bbf42c9c03584d19931a835b77054e5fa8a6c3
Reviewed-on: https://chromium-review.googlesource.com/c/1297217
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602632}
[modify] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/graphics/bitmap_image_test.cc
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/anim_none.gif
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/animated-10color.gif
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng00-ref.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng00.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng01-ref.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng01.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng02-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng02.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng04-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng04.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng08-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng08.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng10-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng10.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng11-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng11.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng12-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng12.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng14-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng14.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng18-ref.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng18.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng19-ref.png
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/apng19.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/blue-wheel-srgb-color-profile.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/cat.jpg
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/crbug722072.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/cropped_mandrill.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-1-ul.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-2-ur.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-3-lr.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-4-lol.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-5-lu.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-6-ru.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-7-rl.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/exif-orientation-8-llo.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/gif-loop-count.gif
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/green-red-blue-yellow-animated.gif
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/green.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/green.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/icc-v2-gbr.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/lenna.bmp
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/original-cat-420-629x473.jpg
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/palatted-color-png-gamma-one-color-profile.png
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/rgb-jpeg-red.jpg
[rename] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/three-frames_loop-three-times.gif
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/webp-color-profile-lossy.webp
[add] https://crrev.com/a13937d9032be67b04ae7e10e97d47aba4df5918/third_party/blink/renderer/platform/testing/data/wrong-frame-dimensions.ico

Status: Fixed (was: Assigned)

Sign in to add a comment