New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898363 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

Create MultiDevice setup flow engagement metric

Project Member Reported by hansberry@chromium.org, Oct 24

Issue description

Create an enumerated histogram with 4 buckets: 1) “Start Page shown”, 2) “Password Page shown”, 3) “Success Page shown” and 4) "Failure page shown". 

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f66d4aea73b9215410650bded0557664f9264354

commit f66d4aea73b9215410650bded0557664f9264354
Author: Ryan Hansberry <hansberry@chromium.org>
Date: Thu Oct 25 22:16:28 2018

[CrOS MultiDevice] Create setup flow engagement metrics.

Create an enumerated histogram which emits an event each time
a different page of the MultiDevice setup flow is opened. This
allows us to determine user dropoff between subsequent pages.

Bug:  898363 
Change-Id: I7e56c0e3af71d7f78d6ef296cf1ab57e3dca5cf0
Reviewed-on: https://chromium-review.googlesource.com/c/1297456
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602894}
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_post_oobe.html
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_post_oobe.js
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/chrome/browser/ui/webui/chromeos/multidevice_setup/multidevice_setup_dialog.cc
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/chrome/test/data/webui/multidevice_setup/integration_test.js
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/f66d4aea73b9215410650bded0557664f9264354/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.js

Labels: Merge-Request-71
This change impacts a number of areas.  Can you add context regarding testing on ToT/M72 or otherwise prior to a merge?  I'd like to understand the merge risk.  

Also, this appears to be a feature rather than improving stability, and we're way past feature freeze.  True?


As discussed by Hangouts just now, this feature has been manually tested extensively, so the merge risk is low.

To your second point, this is more of a feature, yes, and the only reason we are requesting a merge so late after branch is due to the fact that M71 is the first release on which the suite we built over the past year will go live, and it was an oversight on my part to not prioritize including such a basic setup success metric earlier in development.

I apologize for the tardiness of this request, but I really hope there's still an opportunity to include this in M71. Thanks for your help with this!
Project Member

Comment 5 by sheriffbot@chromium.org, Oct 26

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Rejected-71
Hi Jesse, unless this is a P0 I'm not going to approve for M71.  Our feature freeze was some time ago...
Status: Fixed (was: Started)

Sign in to add a comment