Improve app list icon scroll performance |
||||||||
Issue descriptionThis is meta bug to track the effort. One of the factor is background blur, so we may not be able to improve a lot, but I'll look into what we can do for 71/72.
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5815fd69e4fec03d6c30364ee63a2781dc583a07 commit 5815fd69e4fec03d6c30364ee63a2781dc583a07 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Oct 25 16:04:26 2018 Reduce the texture layer in apps grid view * Remove obsolete AppListOverlay. * Create a layer for IconImageView only when needed. * Use LAYER_NOT_DRAWN for apps grid view's layer. Bug: 898352 Test: no visual/functional change Change-Id: I83467bd92879071d2ffaf00faa29829768304e60 Reviewed-on: https://chromium-review.googlesource.com/c/1298486 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#602727} [modify] https://crrev.com/5815fd69e4fec03d6c30364ee63a2781dc583a07/ash/app_list/views/app_list_item_view.cc [modify] https://crrev.com/5815fd69e4fec03d6c30364ee63a2781dc583a07/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/5815fd69e4fec03d6c30364ee63a2781dc583a07/ash/app_list/views/app_list_view.h [modify] https://crrev.com/5815fd69e4fec03d6c30364ee63a2781dc583a07/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/5815fd69e4fec03d6c30364ee63a2781dc583a07/ash/app_list/views/apps_grid_view.cc
,
Oct 31
,
Nov 1
we want this for meowth launch.
,
Nov 1
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
Per the M71 Branch Announcement: "Have your change checked into the trunk, and tested by you on either a Canary build or Dev channel release before asking for merge approval." Has this testing taken place? If so, results? If not, please test prior to the merge request. Thanks.
,
Nov 2
tested on canary 72.0.3598.0/11220.0.0 + nocturne This is part of performance turning work that we want for 71.
,
Nov 5
Merge approved for ChromeOS M71
,
Nov 5
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d926872e2913a1c3b808dfd35e01cfb5e3b9a277 commit d926872e2913a1c3b808dfd35e01cfb5e3b9a277 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Nov 05 22:36:37 2018 Reduce the texture layer in apps grid view * Remove obsolete AppListOverlay. * Create a layer for IconImageView only when needed. * Use LAYER_NOT_DRAWN for apps grid view's layer. Bug: 898352 Test: no visual/functional change Change-Id: I83467bd92879071d2ffaf00faa29829768304e60 Reviewed-on: https://chromium-review.googlesource.com/c/1298486 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602727}(cherry picked from commit 5815fd69e4fec03d6c30364ee63a2781dc583a07) Reviewed-on: https://chromium-review.googlesource.com/c/1318684 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#527} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/d926872e2913a1c3b808dfd35e01cfb5e3b9a277/ash/app_list/views/app_list_item_view.cc [modify] https://crrev.com/d926872e2913a1c3b808dfd35e01cfb5e3b9a277/ash/app_list/views/app_list_view.cc [modify] https://crrev.com/d926872e2913a1c3b808dfd35e01cfb5e3b9a277/ash/app_list/views/app_list_view.h [modify] https://crrev.com/d926872e2913a1c3b808dfd35e01cfb5e3b9a277/ash/app_list/views/app_list_view_unittest.cc [modify] https://crrev.com/d926872e2913a1c3b808dfd35e01cfb5e3b9a277/ash/app_list/views/apps_grid_view.cc
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d926872e2913a1c3b808dfd35e01cfb5e3b9a277 Commit: d926872e2913a1c3b808dfd35e01cfb5e3b9a277 Author: oshima@chromium.org Commiter: oshima@chromium.org Date: 2018-11-05 22:36:37 +0000 UTC Reduce the texture layer in apps grid view * Remove obsolete AppListOverlay. * Create a layer for IconImageView only when needed. * Use LAYER_NOT_DRAWN for apps grid view's layer. Bug: 898352 Test: no visual/functional change Change-Id: I83467bd92879071d2ffaf00faa29829768304e60 Reviewed-on: https://chromium-review.googlesource.com/c/1298486 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602727}(cherry picked from commit 5815fd69e4fec03d6c30364ee63a2781dc583a07) Reviewed-on: https://chromium-review.googlesource.com/c/1318684 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#527} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by osh...@chromium.org
, Oct 24