Forbid generation of zero-sized mipmaps in WebGL |
|||||||
Issue descriptionAfter this update to the WebGL spec and conformance suite: https://github.com/KhronosGroup/WebGL/commit/bfbe124a7bb92eed34ea7cc18694167ed66b1030 calling GenerateMipmap with zero-sized textures is forbidden in WebGL. This is causing new failures of conformance2/textures/misc/tex-mipmap-levels.html . The new restrictions need to be implemented for WebGL contexts in the validating command decoder and in ANGLE.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/319faa6f9fc6bb050759c111202dbb61ba99086d commit 319faa6f9fc6bb050759c111202dbb61ba99086d Author: Kenneth Russell <kbr@chromium.org> Date: Wed Oct 24 17:21:44 2018 Roll WebGL 6d2f3f4..0d55c88 https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6d2f3f4..0d55c88 Includes suppressions for the following failures: conformance/rendering/rendering-sampling-feedback-loop.html conformance2/textures/misc/tex-mipmap-levels.html conformance2/textures/image_bitmap_from_video/ tex-2d-rgb565-rgb-unsigned_short_5_6_5.html deqp/functional/gles3/lifetime.html deqp/functional/gles3/shaderoperator/common_functions_*.html Bug: 660844, 739604 , 766918, 849576, 886970, 890002 , 890539, 898350 , 898351 , angleproject:2832 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I85be441fa86090e5ed056a9366452248985693e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297570 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#602377} [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/DEPS [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_expectations.py [modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_revision.txt
,
Oct 26
,
Nov 27
,
Nov 27
,
Nov 28
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2 commit 83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2 Author: James Darpinian <jdarpinian@chromium.org> Date: Wed Nov 28 02:20:28 2018 WebGL: Forbid GenerateMipmap on zero-size textures This is a WebGL spec change: https://github.com/KhronosGroup/WebGL/commit/bfbe124a7bb92eed34ea7cc18694167ed66b1030 Fixes conformance2/textures/misc/tex-mipmap-levels.html Bug: chromium:898351 Change-Id: Ib20409e10bec598611be273577115a380a63b523 Reviewed-on: https://chromium-review.googlesource.com/c/1352385 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/src/libANGLE/validationES2.cpp [modify] https://crrev.com/83b2f0e8a2e09ae469fe1afd05842ee5dcfb38c2/src/libANGLE/ErrorStrings.h
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fef924a6069ee442b91c02cc1afb7e03047afcb0 commit fef924a6069ee442b91c02cc1afb7e03047afcb0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Nov 28 06:24:44 2018 Roll src/third_party/angle 3b7c9d099b0d..83b2f0e8a2e0 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/3b7c9d099b0d..83b2f0e8a2e0 git log 3b7c9d099b0d..83b2f0e8a2e0 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 jdarpinian@chromium.org WebGL: Forbid GenerateMipmap on zero-size textures Created with: gclient setdep -r src/third_party/angle@83b2f0e8a2e0 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:898351 TBR=fjhenigman@chromium.org Change-Id: I2d031595d94047c86a380c3f2ab287def933ae5d Reviewed-on: https://chromium-review.googlesource.com/c/1351137 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611576} [modify] https://crrev.com/fef924a6069ee442b91c02cc1afb7e03047afcb0/DEPS
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b1e936d9eb9ec71a2253f6b7688efcd7b1cec22 commit 3b1e936d9eb9ec71a2253f6b7688efcd7b1cec22 Author: James Darpinian <jdarpinian@chromium.org> Date: Wed Nov 28 07:28:43 2018 WebGL: Forbid GenerateMipmap on zero-size textures This is a WebGL spec change: https://github.com/KhronosGroup/WebGL/commit/bfbe124a7bb92eed34ea7cc18694167ed66b1030 Fixes conformance2/textures/misc/tex-mipmap-levels.html Bug: 898351 Change-Id: I710edd7f189d21cf080d5b775a2c8aef30ad166c Reviewed-on: https://chromium-review.googlesource.com/c/1352494 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#611586} [modify] https://crrev.com/3b1e936d9eb9ec71a2253f6b7688efcd7b1cec22/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py [modify] https://crrev.com/3b1e936d9eb9ec71a2253f6b7688efcd7b1cec22/gpu/command_buffer/service/texture_manager.cc
,
Nov 28
,
Nov 28
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kbr@chromium.org
, Oct 24