New issue
Advanced search Search tips

Issue 898350 link

Starred by 2 users
Status: Fixed
Owner:
jdarpinian@chromium.org
Closed: Dec 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 662644
issue 739604


Participants' hotlists:
webgl-conformance-all


Sign in to add a comment

Allow clearing of VERTEX_ATTRIB_ARRAY_BUFFER_BINDING

Project Member Reported by kbr@chromium.org, Oct 24 
After spec update https://github.com/KhronosGroup/WebGL/pull/2228 and most recently test update https://github.com/KhronosGroup/WebGL/pull/2731 , Chromium's WebGL implementation needs to be updated to allow clearing out of the VERTEX_ATTRIB_ARRAY_BUFFER_BINDING.

https://www.khronos.org/registry/webgl/specs/latest/1.0/#6.2

The specs of vertexAttribPointer and vertexAttribIPointer also should be updated to clarify that this is allowed.

This blocks fixing the object lifetime semantics in  Issue 739604 , since recent test changes have caused deqp/functional/gles3/lifetime.html to start failing in Chromium.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/319faa6f9fc6bb050759c111202dbb61ba99086d

commit 319faa6f9fc6bb050759c111202dbb61ba99086d
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Oct 24 17:21:44 2018

Roll WebGL 6d2f3f4..0d55c88

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/6d2f3f4..0d55c88

Includes suppressions for the following failures:

  conformance/rendering/rendering-sampling-feedback-loop.html
  conformance2/textures/misc/tex-mipmap-levels.html
  conformance2/textures/image_bitmap_from_video/
    tex-2d-rgb565-rgb-unsigned_short_5_6_5.html
  deqp/functional/gles3/lifetime.html
  deqp/functional/gles3/shaderoperator/common_functions_*.html

Bug: 660844,  739604 , 766918, 849576, 886970,  890002 , 890539,  898350 ,  898351 ,  angleproject:2832 
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng
Change-Id: I85be441fa86090e5ed056a9366452248985693e3
Reviewed-on: https://chromium-review.googlesource.com/c/1297570
Reviewed-by: James Darpinian <jdarpinian@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602377}
[modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/DEPS
[modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/319faa6f9fc6bb050759c111202dbb61ba99086d/content/test/gpu/gpu_tests/webgl_conformance_revision.txt

Comment 2 by jdarpinian@chromium.org, Nov 27

Blocking: 662644

Comment 3 by jdarpinian@chromium.org, Nov 27

Labels: webgl-conformance

Comment 4 by jdarpinian@chromium.org, Dec 21

Owner: jdarpinian@chromium.org
Status: Started (was: Assigned)
I have a fix for this.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d39b023d4d58610875682d63dde7a77caf6fd634

commit d39b023d4d58610875682d63dde7a77caf6fd634
Author: James Darpinian <jdarpinian@chromium.org>
Date: Fri Dec 21 04:26:44 2018

gpu: Allow clearing vertex attrib bindings

Our check to prohibit the use of client side arrays was too strict.
We should allow vertexAttribPointer calls with no buffer bound as long
as the pointer is NULL, because this is the only way to clear a vertex
attrib binding. See WebGL spec rationale under "No Client Side Arrays":
https://www.khronos.org/registry/webgl/specs/latest/1.0/#6.2

Fixes WebGL conformance test deqp/functional/gles3/lifetime.html.

Bug:  898350 
Change-Id: Idab69b2a41286e6018fdb71203c24b6b60b2f148
Reviewed-on: https://chromium-review.googlesource.com/c/1387460
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618456}
[modify] https://crrev.com/d39b023d4d58610875682d63dde7a77caf6fd634/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/d39b023d4d58610875682d63dde7a77caf6fd634/gpu/command_buffer/client/vertex_array_object_manager.cc

Comment 6 by jdarpinian@chromium.org, Dec 21

Status: Fixed (was: Started)
►

Sign in to add a comment