New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 898348 link

Starred by 5 users
Status: Assigned
Owner:
█ iannucci@chromium.org
Last visit > 30 days ago
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Support Python 3 experimentation

Project Member Reported by iannu...@google.com, Oct 24 
This means:
  * Build and upload cpython3 CIPD packages
    * such that they can be installed simultaneously with the cpython packages
  * Ensure that vpython works correctly with cpython3
  * Build python3 versions of wheels (thank goodness for the unicode abi fixes)

Comment 1 by iannu...@google.com, Oct 24

Components: Infra>Platform
Labels: -Pri-3 Pri-1

Comment 2 by iannu...@google.com, Oct 24

Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bc570df8ec2f9e736049d8c51ef7282fbc208c96

commit bc570df8ec2f9e736049d8c51ef7282fbc208c96
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 19:47:00 2018

[3pp] Add xzutils (py3 dep)

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I998e4b75e7bdd21e419101aee8867c471ed46def
Reviewed-on: https://chromium-review.googlesource.com/c/1297610
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18565}
[add] https://crrev.com/bc570df8ec2f9e736049d8c51ef7282fbc208c96/3pp/xzutils/install.sh
[add] https://crrev.com/bc570df8ec2f9e736049d8c51ef7282fbc208c96/3pp/xzutils/3pp.pb
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/71c5163bd47c2cc2d3530bcb9696885ab390a3fe

commit 71c5163bd47c2cc2d3530bcb9696885ab390a3fe
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 21:09:13 2018

[3pp] Split OpenSSL headers into separate package (py3 dep).

We'll need real OpenSSL for python 3 on OS X.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I2bad161194a5eb75cbada7d58b2eb74916e381f4
Reviewed-on: https://chromium-review.googlesource.com/c/1297525
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18566}
[modify] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/openssl/3pp.pb
[modify] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/cpython/3pp.pb
[add] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/openssl_headers/install.sh
[add] https://crrev.com/71c5163bd47c2cc2d3530bcb9696885ab390a3fe/3pp/openssl_headers/3pp.pb
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4c9e9b2c3ff605714ecc38f6be7a715becf08154

commit 4c9e9b2c3ff605714ecc38f6be7a715becf08154
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 24 22:25:46 2018

[3pp] Remove bogus ncurses dependency from readline.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Ie5a36dcdc825e320d0839f2c5c0cf3d917961c7b
Reviewed-on: https://chromium-review.googlesource.com/c/1297526
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18568}
[modify] https://crrev.com/4c9e9b2c3ff605714ecc38f6be7a715becf08154/3pp/readline/3pp.pb
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1

commit 8329bd7816f49d9c640cf2314bd0c69cb6dd4af1
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 25 00:58:47 2018

[3pp] Add ncursesw. Now with wiiiiiddddeee charrrsssss.

Because Python3 loooves Unicode.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I9351041f388bf7412d63274ea5aae11c1468381d
Reviewed-on: https://chromium-review.googlesource.com/c/1297689
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18569}
[add] https://crrev.com/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1/3pp/ncursesw/install.sh
[add] https://crrev.com/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1/3pp/ncursesw/3pp.pb
[add] https://crrev.com/8329bd7816f49d9c640cf2314bd0c69cb6dd4af1/3pp/ncursesw/patches/0001-Fixes-bug-where-MKfallback.sh-hangs-on-rm-rf-tmp_inf.patch
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3f350972f1a08a6b365d170833dec38dae154d18

commit 3f350972f1a08a6b365d170833dec38dae154d18
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Oct 25 21:14:32 2018

[3pp] Add texinfo.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Iacc598bf405aae27c0bfbf54d4ae73f4b1e4e171
Reviewed-on: https://chromium-review.googlesource.com/c/1298537
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18583}
[add] https://crrev.com/3f350972f1a08a6b365d170833dec38dae154d18/3pp/texinfo/3pp.pb
[add] https://crrev.com/3f350972f1a08a6b365d170833dec38dae154d18/3pp/texinfo/install.sh
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/feab5e9bc92754a23e6a3ef9eed55b29d7374c15

commit feab5e9bc92754a23e6a3ef9eed55b29d7374c15
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 01:35:12 2018

[3pp] Add help2man

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Icdf0447a21bf556f90402a8a0f51f9f727fae833
Reviewed-on: https://chromium-review.googlesource.com/c/1298538
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18587}
[add] https://crrev.com/feab5e9bc92754a23e6a3ef9eed55b29d7374c15/3pp/help2man/install.sh
[add] https://crrev.com/feab5e9bc92754a23e6a3ef9eed55b29d7374c15/3pp/help2man/3pp.pb
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/9612fd930cf2df6d374ca9586640b5527a10bbef

commit 9612fd930cf2df6d374ca9586640b5527a10bbef
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 18:09:39 2018

[3pp] Add libffi

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Id6f1f7d8a9692e4e2c385bc24e7ed67d69962201
Reviewed-on: https://chromium-review.googlesource.com/c/1298540
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18598}
[add] https://crrev.com/9612fd930cf2df6d374ca9586640b5527a10bbef/3pp/libffi/install.sh
[add] https://crrev.com/9612fd930cf2df6d374ca9586640b5527a10bbef/3pp/libffi/3pp.pb
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/39a9b0502ec980238e7dc65f5c20aefae0580494

commit 39a9b0502ec980238e7dc65f5c20aefae0580494
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 18:27:17 2018

[3pp] Add binutils

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Idcb541c6fc93d5e43f0f7a9774dcac2faa1214bb
Reviewed-on: https://chromium-review.googlesource.com/c/1298541
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18599}
[add] https://crrev.com/39a9b0502ec980238e7dc65f5c20aefae0580494/3pp/binutils/install.sh
[add] https://crrev.com/39a9b0502ec980238e7dc65f5c20aefae0580494/3pp/binutils/3pp.pb
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8f3dc7cf59ba0d58a25b16efe246784315d52e90

commit 8f3dc7cf59ba0d58a25b16efe246784315d52e90
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Oct 26 18:36:49 2018

[3pp] Disable termcap in ncursesw.

This seems to trigger a bug for ncursesw when using an extensive
fallback (compiled-in) terminfo database. Since we're compiling in the
whole known database as of ncursesw 6.0 (minus some weirdo terminals
which don't play nice with Mkfallback.sh), there's not really a need
to read the terminfo database from disk.

Also, reading the terminfo database from disk seems to trigger an
O(N^2) "conflict detection" routine inside ncurses... so this actually
speeds up launching the python interpreter too. *shrug*.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I2421ebe57d983f7728cc4372edbca066b6298551
Reviewed-on: https://chromium-review.googlesource.com/c/1300873
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18601}
[modify] https://crrev.com/8f3dc7cf59ba0d58a25b16efe246784315d52e90/3pp/ncursesw/install.sh
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fc7a75342b977b7d93d1d45439d16bb4613775c7

commit fc7a75342b977b7d93d1d45439d16bb4613775c7
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 29 19:16:03 2018

[3pp] Add libuuid.

This is one aspect of the util-linux project, but it's the only part
we need for cpython3.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I4c872a180bc0e6341bf9cd640770542098a37fd3
Reviewed-on: https://chromium-review.googlesource.com/c/1303494
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18619}
[add] https://crrev.com/fc7a75342b977b7d93d1d45439d16bb4613775c7/3pp/libuuid/install.sh
[add] https://crrev.com/fc7a75342b977b7d93d1d45439d16bb4613775c7/3pp/libuuid/3pp.pb
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/48f8231ded1714a35a870bcd690932c01e2a6522

commit 48f8231ded1714a35a870bcd690932c01e2a6522
Author: Robert Iannucci <iannucci@chromium.org>
Date: Mon Oct 29 19:37:06 2018

[3pp] Fix pip_bootstrap.

  * Add `if __name__ == '__main__'` incantation. Not sure how this got
    lost, but without it, pip_bootstrap is completely non-functional.
  * Add `-vvv` for extra debugging help.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I14a9d4482c2f601548d3877306084e03d43400f4
Reviewed-on: https://chromium-review.googlesource.com/c/1303495
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18620}
[modify] https://crrev.com/48f8231ded1714a35a870bcd690932c01e2a6522/3pp/pip_bootstrap/pip_bootstrap.py
[modify] https://crrev.com/48f8231ded1714a35a870bcd690932c01e2a6522/3pp/pip_bootstrap/3pp.pb
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/dfbd89299b642588fbd9b7b0275510fd654fc311

commit dfbd89299b642588fbd9b7b0275510fd654fc311
Author: Robert Iannucci <iannucci@chromium.org>
Date: Tue Oct 30 03:50:20 2018

[3pp] Add Python3.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 898348
Change-Id: I76e2515ee951fa921708d203ededf4ea18a96c37
Reviewed-on: https://chromium-review.googlesource.com/c/1272225
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18643}
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/gnu_version_script.txt
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/python_ssl_suffix.py
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/python_mod_gen.py
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/patches/0003-Allow-readelf-to-be-the-host-readelf-tool.patch
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/3pp.pb
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/patches/0002-Enable-manual-version-specification.patch
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/install.sh
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/python_test.py
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/patches/0001-Update-Python-to-build-static-modules.patch
[add] https://crrev.com/dfbd89299b642588fbd9b7b0275510fd654fc311/3pp/cpython3/README.md
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3504a477dc0725fe867dc66f0079c92ad06f5177

commit 3504a477dc0725fe867dc66f0079c92ad06f5177
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 19:11:11 2018

[3pp] Disable cpython3 on windows for now.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I49ef14581e530cc87125fb87629fe469960b3016
Reviewed-on: https://chromium-review.googlesource.com/c/1309090
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18700}
[modify] https://crrev.com/3504a477dc0725fe867dc66f0079c92ad06f5177/3pp/cpython3/3pp.pb
Project Member

Comment 17 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/8378afda2ed1ac364318b4d6b3038a211d7a6b54

commit 8378afda2ed1ac364318b4d6b3038a211d7a6b54
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 19:39:06 2018

[3pp] Fix pip_bootstrap to use correct abspath.

This was previously still picking up the system's version of `pip` :(.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: If4bd1e581cbea07544a4f08c6a6f917347139b52
Reviewed-on: https://chromium-review.googlesource.com/c/1310522
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18701}
[modify] https://crrev.com/8378afda2ed1ac364318b4d6b3038a211d7a6b54/3pp/cpython/install.sh
[modify] https://crrev.com/8378afda2ed1ac364318b4d6b3038a211d7a6b54/3pp/pip_bootstrap/pip_bootstrap.py
[modify] https://crrev.com/8378afda2ed1ac364318b4d6b3038a211d7a6b54/3pp/cpython3/install.sh
Project Member

Comment 18 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/634ca322988683f78a5a5714c0fb920826ad65f3

commit 634ca322988683f78a5a5714c0fb920826ad65f3
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 22:42:25 2018

[3pp] Actually, the interpreter selection was correct before.

Forgot that we can't always use the built interpreter when
cross-compiling.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I5accf243d00ea3a2cf6e2873ac4cce599e569ed5
Reviewed-on: https://chromium-review.googlesource.com/c/1311476
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18709}
[modify] https://crrev.com/634ca322988683f78a5a5714c0fb920826ad65f3/3pp/cpython/install.sh
[modify] https://crrev.com/634ca322988683f78a5a5714c0fb920826ad65f3/3pp/cpython3/install.sh
Project Member

Comment 19 by bugdroid1@chromium.org, Oct 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6ba7148b5f37a5bdca97b9a3948db359dd865aa5

commit 6ba7148b5f37a5bdca97b9a3948db359dd865aa5
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 23:05:36 2018

[3pp] Backport $PYTHONEXE from cpython3, too.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I4485f1bc52fe00a5cccc23b6347d905ae44aa286
Reviewed-on: https://chromium-review.googlesource.com/c/1311735
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18711}
[modify] https://crrev.com/6ba7148b5f37a5bdca97b9a3948db359dd865aa5/3pp/cpython/install.sh
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/63116a418913c0f2b4f6838a5c16a74f01bc7d90

commit 63116a418913c0f2b4f6838a5c16a74f01bc7d90
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Oct 31 23:59:34 2018

[3pp] Remove _tkinter from OS X modules.

TBR=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I0696c90fe6ee5d2720bb8f746280110ebe34d368
Reviewed-on: https://chromium-review.googlesource.com/c/1311739
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18715}
[modify] https://crrev.com/63116a418913c0f2b4f6838a5c16a74f01bc7d90/3pp/cpython3/install.sh
Project Member

Comment 21 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/6cba6ecc21d1ffacba3b5123c44360339851632a

commit 6cba6ecc21d1ffacba3b5123c44360339851632a
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Nov 02 06:11:57 2018

[3pp] Remove cert.pem file hack from cpython3 on mac.

This is much less hacky than the previous scheme (though the subprocess
bit is still a bit janky). I looked into calling the functions in
Security.framework directly, but it looked like a lot more code than I
was willing to deal with currently.

R=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I879c504a8d6793514b3db8ddce93260860b5810b
Reviewed-on: https://chromium-review.googlesource.com/c/1313661
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18751}
[rename] https://crrev.com/6cba6ecc21d1ffacba3b5123c44360339851632a/3pp/cpython3/python_ssl_suffix.py3
[modify] https://crrev.com/6cba6ecc21d1ffacba3b5123c44360339851632a/3pp/cpython3/install.sh
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4405276722315f47d916b3bab2418689945b05e6

commit 4405276722315f47d916b3bab2418689945b05e6
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 03 00:35:47 2018

[3pp] SSL hack version 3

Using the power of ctypes, we now load the certs directly from the OS
Keychain via Security.framework. This is a modernized version of what
the `security` tool was doing anyway (SecItemCopyMatching is the
modernized version of SecKeychainSearchCreateFromAttributes, which is
how the `security` tool does it).

Source for `security` tool (see `do_keychain_find_certificate`):
https://opensource.apple.com/source/Security/Security-58286.70.7/SecurityTool/keychain_find.c.auto.html

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I43e638f25314209b91eb5aaa94fffcd510f4b7a9
Reviewed-on: https://chromium-review.googlesource.com/c/1315835
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18773}
[modify] https://crrev.com/4405276722315f47d916b3bab2418689945b05e6/3pp/cpython3/python_ssl_suffix.py3
Project Member

Comment 23 by bugdroid1@chromium.org, Nov 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/3b0d923d5ca1e095f42e73509033c2bdedf93450

commit 3b0d923d5ca1e095f42e73509033c2bdedf93450
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 03 04:45:39 2018

[3pp] Add root certs keychain too.

This adds Apple's root certificate keychain as well. The end result of
this is that it will pick up (in order):
  * Certs defined for the current logged-in user
  * Certs defined for the "System" (i.e. sysadmins add stuff here)
  * Certs defined for the "SystemRoot" (i.e. Apple adds stuff here)

In addition, we now only load certs from the system once per process, caching
them at ssl._system_cert_pem.

This CL refactors the _attach_cacert_bundle() function to factor out the linux
and OS X paths, as they've diverged substantially.

TBR=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: Ia84af00b5257e4609b9e304d02f60559d16f8cc5
Reviewed-on: https://chromium-review.googlesource.com/c/1316421
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18782}
[modify] https://crrev.com/3b0d923d5ca1e095f42e73509033c2bdedf93450/3pp/cpython3/python_ssl_suffix.py3
Project Member

Comment 24 by bugdroid1@chromium.org, Nov 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/46b441a5dafe101672ab0b8fdd29a0ad0cba6210

commit 46b441a5dafe101672ab0b8fdd29a0ad0cba6210
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Nov 03 07:22:07 2018

[3pp/cpython3] Fixups to python_ssl_suffix.py3.

R=tandrii@chromium.org, vadimsh@chromium.org

Bug: 877775,898348
Change-Id: I39f28b3751d4495eab2018dd9edf6eab8b1c302c
Reviewed-on: https://chromium-review.googlesource.com/c/1316426
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18783}
[modify] https://crrev.com/46b441a5dafe101672ab0b8fdd29a0ad0cba6210/3pp/cpython3/python_ssl_suffix.py3
Project Member

Comment 25 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/afb73e25494edc5b251d3214095f8e0d54f33ded

commit afb73e25494edc5b251d3214095f8e0d54f33ded
Author: Robert Iannucci <iannucci@chromium.org>
Date: Thu Nov 15 22:47:09 2018

[3pp] Add lessmsi.

This will be used for cpython for windows to extract files from the .msi
installer without having to run it.

R=tandrii@chromium.org

Bug: 877775,898348
Change-Id: I3bb710bfa7c4043507badfdddc853f74d4a9fbd8
Reviewed-on: https://chromium-review.googlesource.com/c/1335178
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19031}
[add] https://crrev.com/afb73e25494edc5b251d3214095f8e0d54f33ded/3pp/lessmsi/3pp.pb
[add] https://crrev.com/afb73e25494edc5b251d3214095f8e0d54f33ded/3pp/lessmsi/fetch_win.py
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/522debceb9aeba7dbce7f811687a640656d4e8cd

commit 522debceb9aeba7dbce7f811687a640656d4e8cd
Author: Robert Iannucci <iannucci@chromium.org>
Date: Fri Nov 16 01:20:59 2018

[3pp] Add cpython support on windows.

R=tandrii@chromium.org

Change-Id: I5fbe461275e5a311161a5e8c1be676fc7ab80cf5
Bug: 877775,898348
Reviewed-on: https://chromium-review.googlesource.com/c/1318711
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19039}
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/run_remotely.sh
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython3/python_test.py
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/3pp.pb
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/git/git_test.py
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/pip_bootstrap/pip_bootstrap.py
[add] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/fetch.py
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/python_test.py
[add] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/cpython/install_win.sh
[modify] https://crrev.com/522debceb9aeba7dbce7f811687a640656d4e8cd/3pp/pip_bootstrap/3pp.pb
►

Sign in to add a comment