Combine Toolbar component into Omnibox component See discussion here: https://chromium-review.googlesource.com/c/chromium/src/+/1286756
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3dac9043d33a9989dc740a37e556d5c40d4377de commit 3dac9043d33a9989dc740a37e556d5c40d4377de Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Oct 29 17:52:34 2018 Omnibox: Combine Toolbar and Omnibox component. The "toolbar" component would be most accurately called the "location_bar" component. However, we don't have any location bars in Chrome that are not also an Omnibox. Colloquially, most users and engineers refer to the whole location bar, not just the textfield as the "Omnibox". Moreover, the toolbar model provides data that feeds both into the "Omnibox" text portion as well as the exterior "Location Bar". A followup CL will likely rename ToolbarModel to OmniboxModel. Bug: 898347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7123286da779afe6485f7c324b7fb84a72889601 Reviewed-on: https://chromium-review.googlesource.com/c/1297632 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603552} [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/about_flags.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/android/omnibox/autocomplete_controller_android.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/android/tab_android.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ssl/security_state_tab_helper.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/android/tab_model/tab_model.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/android/tab_model/tab_model.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/android/toolbar/toolbar_model_android.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/android/toolbar/toolbar_model_android.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/autofill/autofill_popup_layout_model.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/browser.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/browser.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/cocoa/touchbar/browser_window_default_touch_bar.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/omnibox/chrome_omnibox_client.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/toolbar/chrome_toolbar_model_delegate.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/toolbar/toolbar_model_unittest.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/location_bar/find_bar_icon.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/location_bar/intent_picker_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/location_bar/star_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/ui/views/page_action/zoom_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/vr/testapp/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/vr/toolbar_helper.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/chrome/test/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/DEPS [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/omnibox_edit_controller.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/omnibox_edit_model_unittest.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/omnibox_view.cc [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/test_omnibox_edit_controller.h [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/test_toolbar_model.cc [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/test_toolbar_model.h [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_field_trial.cc [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_field_trial.h [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_model.h [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_model_delegate.cc [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_model_delegate.h [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_model_impl.cc [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_model_impl.h [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/toolbar_model_impl_unittest.cc [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/find_in_page.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/http.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/https_invalid.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/https_valid.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/https_valid_in_chip.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/offline_pin.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/open_in_new.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/product.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/star.icon [rename] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/components/omnibox/browser/vector_icons/star_active.icon [delete] https://crrev.com/f3676ac54a5cda71d53915993e9ea95b406a5b3e/components/toolbar/BUILD.gn [delete] https://crrev.com/f3676ac54a5cda71d53915993e9ea95b406a5b3e/components/toolbar/DEPS [delete] https://crrev.com/f3676ac54a5cda71d53915993e9ea95b406a5b3e/components/toolbar/OWNERS [delete] https://crrev.com/f3676ac54a5cda71d53915993e9ea95b406a5b3e/components/toolbar/vector_icons/OWNERS [delete] https://crrev.com/f3676ac54a5cda71d53915993e9ea95b406a5b3e/components/toolbar/vector_icons/vector_icons.cc.template [delete] https://crrev.com/f3676ac54a5cda71d53915993e9ea95b406a5b3e/components/toolbar/vector_icons/vector_icons.h.template [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/DEPS [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/browser_view_controller_helper_unittest.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/location_bar/toolbar_model_delegate_ios.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/omnibox/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/omnibox_perftest.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/payments/BUILD.gn [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/payments/payment_request_manager.mm [modify] https://crrev.com/3dac9043d33a9989dc740a37e556d5c40d4377de/ios/chrome/browser/ui/toolbar/fullscreen/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a2922580afdd703d049b3e09e631f96e0fe74d8 commit 7a2922580afdd703d049b3e09e631f96e0fe74d8 Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Oct 29 22:40:25 2018 Omnibox: Combine ToolbarFieldTrials into OmniboxFieldTrials This CL consolidates ToolbarFieldTrials into OmniboxFieldTrials. This was enabled by the recent move of everything in the toolbar component into the omnibox component. Bug: 898347 Change-Id: Ie879a9adc28b2b56fe30d1a86d42f78a846551a4 Reviewed-on: https://chromium-review.googlesource.com/c/1303019 Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603666} [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/about_flags.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/ssl/security_state_tab_helper.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/ui/toolbar/toolbar_model_unittest.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/components/omnibox/browser/BUILD.gn [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/components/omnibox/browser/omnibox_field_trial.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/components/omnibox/browser/omnibox_field_trial.h [delete] https://crrev.com/c58a4aef82457f8295843864ae11e9071a50da53/components/omnibox/browser/toolbar_field_trial.cc [delete] https://crrev.com/c58a4aef82457f8295843864ae11e9071a50da53/components/omnibox/browser/toolbar_field_trial.h [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/components/omnibox/browser/toolbar_model_impl.cc [modify] https://crrev.com/7a2922580afdd703d049b3e09e631f96e0fe74d8/components/omnibox/browser/toolbar_model_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a26664658245f290e933714d83190496b133ea3 commit 1a26664658245f290e933714d83190496b133ea3 Author: Tommy C. Li <tommycli@chromium.org> Date: Tue Oct 30 18:58:37 2018 Omnibox: Rename ToolbarModel to LocationBarModel LocationBarModel is a much more accurate name for this class than ToolbarModel. We didn't use OmniboxModel because it may be confused with OmniboxEditModel. TBR=sky@chromium.org Bug: 898347 Change-Id: I845e36fc58e4f8f4b951b83379bb355a4d718e9d Reviewed-on: https://chromium-review.googlesource.com/c/1306837 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603977} [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java/src/org/chromium/chrome/browser/toolbar/LocationBarModel.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java/src/org/chromium/chrome/browser/widget/findinpage/FindToolbar.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/java_sources.gni [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarLayoutTest.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxTest.java [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/LocationBarModelTest.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/android/junit/src/org/chromium/chrome/browser/toolbar/ToolbarSecurityIconTest.java [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/BUILD.gn [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/omnibox/autocomplete_controller_android.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/policy/policy_auditor.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/tab_android.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/vr/vr_gl_thread.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/vr/vr_gl_thread.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/vr/vr_shell.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/android/vr/vr_shell.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/chromeos/login/ui/simple_web_view_dialog.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/extensions/extension_util.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/android/tab_model/tab_model.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/android/tab_model/tab_model.h [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/android/toolbar/location_bar_model_android.cc [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/android/toolbar/location_bar_model_android.h [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/ui/android/toolbar/toolbar_model_android.cc [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/ui/android/toolbar/toolbar_model_android.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/browser.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/browser.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/browser_commands.cc [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/browser_location_bar_model_delegate.cc [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/browser_location_bar_model_delegate.h [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/ui/browser_toolbar_model_delegate.cc [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/ui/browser_toolbar_model_delegate.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/extensions/hosted_app_menu_model.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/omnibox/chrome_omnibox_client.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/omnibox/chrome_omnibox_edit_controller.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.cc [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/toolbar/chrome_location_bar_model_delegate.h [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/toolbar/location_bar_model_unittest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/toolbar/toolbar_actions_model.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/location_bar/location_bar_view.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/location_bar/location_bar_view.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/location_bar/location_icon_view.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/media_router/presentation_receiver_window_view.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/media_router/presentation_receiver_window_view.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/omnibox/omnibox_view_views.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/page_action/zoom_view.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/ui/views/toolbar/toolbar_view.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/browser_ui_interface.h [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/location_bar_helper.cc [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/location_bar_helper.h [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/model/location_bar_state.cc [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/model/location_bar_state.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/model/model.h [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/vr/model/toolbar_state.cc [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/vr/model/toolbar_state.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/test/mock_browser_ui_interface.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/test/ui_pixel_test.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/test/ui_pixel_test.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/testapp/vr_test_context.cc [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/vr/toolbar_helper.cc [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/chrome/browser/vr/toolbar_helper.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/ui.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/ui.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/ui_pixeltest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/vr_web_contents_observer.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/browser/vr/vr_web_contents_observer.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/chrome/test/BUILD.gn [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/BUILD.gn [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/location_bar_model.h [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/location_bar_model_delegate.cc [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/location_bar_model_delegate.h [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/location_bar_model_impl.cc [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/location_bar_model_impl.h [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/location_bar_model_impl_unittest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/omnibox_edit_controller.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/omnibox_edit_controller.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/omnibox_edit_model.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/omnibox_edit_model_unittest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/omnibox_pedal_unittest.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/omnibox_view.cc [add] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/test_location_bar_model.cc [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/test_location_bar_model.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/test_omnibox_edit_controller.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/omnibox/browser/test_omnibox_edit_controller.h [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/components/omnibox/browser/test_toolbar_model.cc [delete] https://crrev.com/a65c275f7d38431493d126c7d1b7815769a04a84/components/omnibox/browser/toolbar_model_delegate.cc [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/search_engines/template_url_service.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/components/security_state/core/security_state.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/browser_view_controller_helper_unittest.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/browser_view_controller_unittest.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/BUILD.gn [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/location_bar_coordinator.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/location_bar_coordinator_unittest.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/location_bar_mediator.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/location_bar_mediator.mm [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/location_bar_model_delegate_ios.h [rename] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/location_bar/location_bar_model_delegate_ios.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/ntp/new_tab_page_controller.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/omnibox/location_bar_delegate.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/omnibox/web_omnibox_edit_controller_impl.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/omnibox_perftest.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/payments/payment_request_manager.h [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/payments/payment_request_manager.mm [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/toolbar/DEPS [modify] https://crrev.com/1a26664658245f290e933714d83190496b133ea3/ios/chrome/browser/ui/toolbar/toolbar_coordinator_delegate.h
This is done now.
Comment 1 by bugdroid1@chromium.org
, Oct 29