FATAL:web_state_impl.mm(694)] Check failed: equalOrigins. Origin mismatch. URL: https://www.cnn.com Last committed: chrome://newtab/ |
||
Issue descriptionAfter the latest non-native NTP changes. 1) Enable non-native NTP 2) Tap on a content suggestion 3) Tap back. #0 0x000000010fe11a74 in base::debug::BreakDebugger() at base/debug/debugger_posix.cc:274 #1 0x000000010fb2cc36 in logging::LogMessage::~LogMessage() at base/logging.cc:876 #2 0x000000010fb294f5 in logging::LogMessage::~LogMessage() at base/logging.cc:586 #3 0x000000010e5b9976 in web::WebStateImpl::GetCurrentURL(web::URLVerificationTrustLevel*) const at ios/web/web_state/web_state_impl.mm:694 #4 0x0000000113f9b5ea in password_manager::GetPageURLAndCheckTrustLevel(web::WebState*, GURL*) at components/password_manager/ios/password_form_helper.mm:40 #5 0x000000010e9109eb in ::-[PasswordController webState:didLoadPageWithSuccess:](web::WebState *, BOOL) at ios/chrome/browser/passwords/password_controller.mm:280 #6 0x000000010e5c86f3 in web::WebStateObserverBridge::PageLoaded(web::WebState*, web::PageLoadCompletionStatus) at ios/web/web_state/web_state_observer_bridge.mm:94 #7 0x000000010e5b3fad in web::WebStateImpl::OnPageLoaded(GURL const&, bool) at ios/web/web_state/web_state_impl.mm:270 #8 0x000000010e49b07d in ::-[CRWWebController didFinishWithURL:loadSuccess:context:](const GURL &, BOOL, const web::NavigationContextImpl *) at ios/web/web_state/ui/crw_web_controller.mm:2209 #9 0x000000010e49a899 in ::-[CRWWebController loadCompleteWithSuccess:forNavigation:](BOOL, WKNavigation *) at ios/web/web_state/ui/crw_web_controller.mm:2166 #10 0x000000010e4ab2a7 in ::-[CRWWebController handleLoadError:forNavigation:](NSError *, WKNavigation *) at ios/web/web_state/ui/crw_web_controller.mm:3153 #11 0x000000010e4c0a58 in ::-[CRWWebController webView:didFailProvisionalNavigation:withError:](WKWebView *, WKNavigation *, NSError *) at ios/web/web_state/ui/crw_web_controller.mm:4754
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88a6b6f7ef15cec191f01c941b78655ebe8ebe47 commit 88a6b6f7ef15cec191f01c941b78655ebe8ebe47 Author: Justin Cohen <justincohen@google.com> Date: Wed Nov 07 04:10:08 2018 [ios] Set document url in -didFailProvisionalNavigation. When navigating back to an error page -loadErrorPageForNavigationItem will immediately begin loading and _documentURL may not match the lastCommittedURL. Instead, set this in -didFailProvisionalNavigation. Bug: 898339 Change-Id: I32bff4cce27c97adde395a3e64ddb58b18bd0593 Reviewed-on: https://chromium-review.googlesource.com/c/1319173 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#605956} [modify] https://crrev.com/88a6b6f7ef15cec191f01c941b78655ebe8ebe47/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/88a6b6f7ef15cec191f01c941b78655ebe8ebe47/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Jan 3
I don't hit this DCHECK anymore. Could be fixed by https://chromium-review.googlesource.com/c/1362000 or some other recent CLs. |
||
►
Sign in to add a comment |
||
Comment 1 by sczs@chromium.org
, Oct 24