New issue
Advanced search Search tips

Issue 898332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Metrics Exceptions

Project Member Reported by dgarr...@chromium.org, Oct 23

Issue description

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8931835604144204560

https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8931835604144204560/+/steps/PreCQLauncher/0/stdout


16:01:01: ERROR: Caught an exception while running ('GaugeMetric',).('set',)((7, {'status': 'None', 'subtype': 'speculative'}), fields={})
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/ts_mon_config.py", line 337, in _CallMetric
    **message.method_kwargs)
TypeError: set() got multiple values for keyword argument 'fields'
16:01:01: ERROR: Caught an exception while running ('GaugeMetric',).('set',)((8, {'status': 'fail', 'subtype': 'speculative'}), fields={})
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/ts_mon_config.py", line 337, in _CallMetric
    **message.method_kwargs)
TypeError: set() got multiple values for keyword argument 'fields'
16:01:01: ERROR: Caught an exception while running ('GaugeMetric',).('set',)((119, {'status': 'fully-verified', 'subtype': 'speculative'}), fields={})
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/ts_mon_config.py", line 337, in _CallMetric
    **message.method_kwargs)
TypeError: set() got multiple values for keyword argument 'fields'
16:01:01: ERROR: Caught an exception while running ('GaugeMetric',).('set',)((9, {'status': 'inflight', 'subtype': 'speculative'}), fields={})
Traceback (most recent call last):
  File "/b/swarming/w/ir/cache/cbuild/repository/chromite/lib/ts_mon_config.py", line 337, in _CallMetric
    **message.method_kwargs)
 
Cc: dchan@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8324c9d3b46574df30087091fc2242d9912b7f7b

commit 8324c9d3b46574df30087091fc2242d9912b7f7b
Author: Dhanya Ganesh <dhanyaganesh@chromium.org>
Date: Thu Nov 08 08:48:11 2018

precq-launcher: move fields from args to kwargs

The PreCQLaucher stage has been throwing up errors because
'fields' argument is in args instead of kwargs. We should caution
every metric call against sending fields in args.

BUG= chromium:898332 
TEST=run_tests

Change-Id: I225bc049eefb1b82328c86f954cb18737919e3f2
Reviewed-on: https://chromium-review.googlesource.com/1321035
Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org>
Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Mike Nichols <mikenichols@chromium.org>

[modify] https://crrev.com/8324c9d3b46574df30087091fc2242d9912b7f7b/cbuildbot/stages/sync_stages.py

Sign in to add a comment