New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898327 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Explore Sites Fetcher does not send up the version token

Project Member Reported by dewittj@google.com, Oct 23

Issue description

This prevents the server from sending the cached response, and increases data usage for all clients.

 
Labels: M-71
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12e3ef3836eb72606da3dcb753dc83b208004a78

commit 12e3ef3836eb72606da3dcb753dc83b208004a78
Author: Justin DeWitt <dewittj@chromium.org>
Date: Wed Oct 24 18:24:44 2018

[EoS] Send up the existing version_token (if any) when requesting the catalog.

This fixes a TODO where we weren't requesting that the server send us an
empty catalog when we have already downloaded the current version.

Bug: 898327
Change-Id: I39c0911a71947ac553ef224830d97fcdd39eed3d
Reviewed-on: https://chromium-review.googlesource.com/c/1297607
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602402}
[modify] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/BUILD.gn
[modify] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[add] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/android/explore_sites/get_version_task.cc
[add] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/android/explore_sites/get_version_task.h
[add] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/browser/android/explore_sites/get_version_task_unittest.cc
[modify] https://crrev.com/12e3ef3836eb72606da3dcb753dc83b208004a78/chrome/test/BUILD.gn

Labels: Merge-Request-71
Project Member

Comment 4 by sheriffbot@chromium.org, Oct 25

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Cc: benmason@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d73f6a2abce7f7db383e1086340ad11cafd8a663

commit d73f6a2abce7f7db383e1086340ad11cafd8a663
Author: Justin DeWitt <dewittj@chromium.org>
Date: Tue Oct 30 22:34:39 2018

[EoS] Send up the existing version_token (if any) when requesting the catalog.

This fixes a TODO where we weren't requesting that the server send us an
empty catalog when we have already downloaded the current version.

Bug: 898327
Change-Id: I39c0911a71947ac553ef224830d97fcdd39eed3d
Reviewed-on: https://chromium-review.googlesource.com/c/1297607
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602402}(cherry picked from commit 12e3ef3836eb72606da3dcb753dc83b208004a78)
Reviewed-on: https://chromium-review.googlesource.com/c/1308611
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#425}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/BUILD.gn
[modify] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/android/explore_sites/explore_sites_service_impl_unittest.cc
[add] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/android/explore_sites/get_version_task.cc
[add] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/android/explore_sites/get_version_task.h
[add] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/browser/android/explore_sites/get_version_task_unittest.cc
[modify] https://crrev.com/d73f6a2abce7f7db383e1086340ad11cafd8a663/chrome/test/BUILD.gn

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d73f6a2abce7f7db383e1086340ad11cafd8a663

Commit: d73f6a2abce7f7db383e1086340ad11cafd8a663
Author: dewittj@chromium.org
Commiter: dewittj@chromium.org
Date: 2018-10-30 22:34:39 +0000 UTC

[EoS] Send up the existing version_token (if any) when requesting the catalog.

This fixes a TODO where we weren't requesting that the server send us an
empty catalog when we have already downloaded the current version.

Bug: 898327
Change-Id: I39c0911a71947ac553ef224830d97fcdd39eed3d
Reviewed-on: https://chromium-review.googlesource.com/c/1297607
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602402}(cherry picked from commit 12e3ef3836eb72606da3dcb753dc83b208004a78)
Reviewed-on: https://chromium-review.googlesource.com/c/1308611
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#425}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment