Issue metadata
Sign in to add a comment
|
Mac Regression: Chrome Signin permanently breaks if a user ever resets their default keychains |
||||||||||||||||||||||
Issue descriptionChrome Version : 72.0.3589.0 OS Version: OS X 10.13.6 full details: ~ https://crbug.com/891219#c11 What steps will reproduce the problem? 0. Be signed in to chrome. 1. Open /Applications/Utilities/Keychain Access 2. Open Preferences from menubar 3. Click "Reset My Default Keychains" 4. Restart Chrome, note sync is "paused" 5. Signin. 6. Restart Chrome. (or Reboot machine and start Chrome). What is the expected result? The account details and auth cookies should be remembered after step 5. What happens instead of that? They are not. Two possible ways to recover from this: - rm -r ~/Library/Application\ Support/Google/Chrome[\ Canary] - Launch chrome from Terminal.app with --disable-features=PreventEncryptionKeyOverwrites Neither of these are end user-accessible. We need a way for Mac users to recover from this situation. Note errors go like [1553:24835:1018/103058.121558:ERROR:gcm_store_impl.cc(920)] Failed to restore security token. [1553:775:1018/103059.600162:ERROR:account_tracker.cc(240)] AccessTokenFetched error: Invalid credentials (1). [1553:775:1018/103059.914851:ERROR:data_type_manager_impl.cc(37)] Passwords cryptographer error was encountered: [1553:31491:1018/103104.952831:ERROR:external_policy_data_updater.cc(263)] The fetched data doesn't match the expected hash. [1553:775:1018/103057.957460:VERBOSE1:mutable_profile_oauth2_token_service_delegate.cc(353)] MutablePO2TS::MutablePO2TS [1553:27663:1018/103057.995709:VERBOSE1:token_service_table.cc(155)] Loaded tokens: result = 3 ; number of tokens loaded = 1 [1553:24835:1018/103058.121558:ERROR:gcm_store_impl.cc(920)] Failed to restore security token. [1553:775:1018/103059.600162:ERROR:account_tracker.cc(240)] AccessTokenFetched error: Invalid credentials (1). [1553:775:1018/103059.600208:WARNING:account_tracker.cc(190)] Failed to get UserInfo for 110394850730314802119 [1553:775:1018/103059.634004:VERBOSE1:mutable_profile_oauth2_token_service_delegate.cc(415)] MutablePO2TS::UpdateAuthError. Error: 1 account_id=110394850730314802119 [1553:775:1018/103059.913429:VERBOSE1:mutable_profile_oauth2_token_service_delegate.cc(446)] MutablePO2TS::RefreshTokenIsAvailable [1553:775:1018/103059.913511:VERBOSE1:mutable_profile_oauth2_token_service_delegate.cc(389)] Request for token has been rejected due to persistent error #1 [1553:775:1018/103059.913862:VERBOSE1:mutable_profile_oauth2_token_service_delegate.cc(415)] MutablePO2TS::UpdateAuthError. Error: 1 account_id=110394850730314802119 [1553:775:1018/103059.914851:ERROR:data_type_manager_impl.cc(37)] Passwords cryptographer error was encountered:
,
Oct 24
,
Oct 25
What feature will you disable?
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/966a2278390e40f0ad9394c0d4e53c89ae50e3f4 commit 966a2278390e40f0ad9394c0d4e53c89ae50e3f4 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Thu Oct 25 19:14:28 2018 Disable feature "PreventEncryptionKeyOverwrites". PreventEncryptionKeyOverwrites prevents the encryption key on Mac to be recreated when it was already there before. DeleteCorruptedPasswords cleans the broken passwords automatically and kinda depends on PreventEncryptionKeyOverwrites. RecoverPasswordsForSyncUsers is launched in M70 and to be superseded by DeleteCorruptedPasswords. Bug: 898325 Change-Id: I61b7318405bef8beb017b0e6b51cb4b171c17131 Reviewed-on: https://chromium-review.googlesource.com/c/1299163 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#602823} [modify] https://crrev.com/966a2278390e40f0ad9394c0d4e53c89ae50e3f4/components/os_crypt/os_crypt_features_mac.cc [modify] https://crrev.com/966a2278390e40f0ad9394c0d4e53c89ae50e3f4/components/password_manager/core/browser/password_syncable_service_unittest.cc [modify] https://crrev.com/966a2278390e40f0ad9394c0d4e53c89ae50e3f4/components/password_manager/core/common/password_manager_features.cc
,
Oct 26
I'd like to merge r602823 to M71. It disables the feature that we don't plan to launch in M71.
,
Oct 26
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
Approving merge to M71 branch 3578 based on comment #5. Please merge ASAP so we can pick it up for next week beta. Thank you.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0b261ad68132d28742b67af3ef0d1bcea96d1cd commit b0b261ad68132d28742b67af3ef0d1bcea96d1cd Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Oct 29 10:52:27 2018 Disable feature "PreventEncryptionKeyOverwrites". PreventEncryptionKeyOverwrites prevents the encryption key on Mac to be recreated when it was already there before. DeleteCorruptedPasswords cleans the broken passwords automatically and kinda depends on PreventEncryptionKeyOverwrites. RecoverPasswordsForSyncUsers is launched in M70 and to be superseded by DeleteCorruptedPasswords. TBR=vasilii@chromium.org (cherry picked from commit 966a2278390e40f0ad9394c0d4e53c89ae50e3f4) Bug: 898325 Change-Id: I61b7318405bef8beb017b0e6b51cb4b171c17131 Reviewed-on: https://chromium-review.googlesource.com/c/1299163 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602823} Reviewed-on: https://chromium-review.googlesource.com/c/1304438 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#367} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/b0b261ad68132d28742b67af3ef0d1bcea96d1cd/components/os_crypt/os_crypt_features_mac.cc [modify] https://crrev.com/b0b261ad68132d28742b67af3ef0d1bcea96d1cd/components/password_manager/core/browser/password_syncable_service_unittest.cc [modify] https://crrev.com/b0b261ad68132d28742b67af3ef0d1bcea96d1cd/components/password_manager/core/common/password_manager_features.cc
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0b261ad68132d28742b67af3ef0d1bcea96d1cd Commit: b0b261ad68132d28742b67af3ef0d1bcea96d1cd Author: vasilii@chromium.org Commiter: vasilii@chromium.org Date: 2018-10-29 10:52:27 +0000 UTC Disable feature "PreventEncryptionKeyOverwrites". PreventEncryptionKeyOverwrites prevents the encryption key on Mac to be recreated when it was already there before. DeleteCorruptedPasswords cleans the broken passwords automatically and kinda depends on PreventEncryptionKeyOverwrites. RecoverPasswordsForSyncUsers is launched in M70 and to be superseded by DeleteCorruptedPasswords. TBR=vasilii@chromium.org (cherry picked from commit 966a2278390e40f0ad9394c0d4e53c89ae50e3f4) Bug: 898325 Change-Id: I61b7318405bef8beb017b0e6b51cb4b171c17131 Reviewed-on: https://chromium-review.googlesource.com/c/1299163 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602823} Reviewed-on: https://chromium-review.googlesource.com/c/1304438 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#367} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 29
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vasi...@chromium.org
, Oct 24