New issue
Advanced search Search tips

Issue 898309 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 832354
Owner:
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Activity log placeholder page implementation

Project Member Reported by kelvinjiang@chromium.org, Oct 23

Issue description

Implement a placeholder for the activity log page, hidden under a command line flag. Redirect the user back to the details page if they try to access the activity log without the flag

Design doc: https://docs.google.com/document/d/12c6Tf5g4SBINipwA5QIS96OJXx249yLyU5FIvUzV2uc/edit?usp=sharing


 
Mergedinto: 832354
Status: Duplicate (was: Started)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace

commit 2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace
Author: Kelvin Jiang <kelvinjiang@chromium.org>
Date: Fri Oct 26 19:50:50 2018

[Extensions] Add an activity log page (placeholder page)

Add a placeholder page to show an activity log for an extension, hidden behind the
"enable-extension-activity-logging" command line flag, and accessible via
chrome://extensions/?id=<extension_id>. If the flag is disabled and a user
navigates to the page, redirect to the extensions details page.

Bug:  898309 
Change-Id: Ib0f50487c323e8c07d6fddcd57df3b8e5477cfc6
Reviewed-on: https://chromium-review.googlesource.com/c/1295296
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603176}
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/app/md_extensions_strings.grdp
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/BUILD.gn
[add] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/activity_log.html
[add] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/activity_log.js
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/extensions_resources.grd
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/manager.js
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/resources/md_extensions/navigation_helper.js
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/test/data/webui/extensions/cr_extensions_browsertest.js
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/test/data/webui/extensions/detail_view_test.js
[modify] https://crrev.com/2ee44ad39f1fbfb32e1d66003d8c6252e31c5ace/chrome/test/data/webui/extensions/manager_test.js

Sign in to add a comment