New issue
Advanced search Search tips

Issue 898289 link

Starred by 1 user
Status: Assigned
Owner:
davidri...@chromium.org
Cc:
pwang@chromium.org
allenwebb@chromium.org
metzman@chromium.org
infe...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain



Sign in to add a comment

Allow custom fuzzer flags for virglrenderer

Project Member Reported by manojgupta@chromium.org, Oct 23 
virglrenderer explicitly adds -fsanitize=address to its build flags for fuzzing.
https://github.com/freedesktop/virglrenderer/blob/master/tests/fuzzer/Makefile.am#L14

Because of this, any other sanitizer config that is incompatible with asan can't be used e.g. msan can't be enabled for virglrenderer.


Is there a way to make the fuzzer using the sanitizer flags passed by ebuild? Maybe break AM_FLAGS in two parts (AM_FLAGS_COMMON and FUZZER_FLAGS) and the FUZZER_FLAGS could be overridden in ebuild?
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c3c03dbf4056fe371044ebdf66ff33c53d5731ba

commit c3c03dbf4056fe371044ebdf66ff33c53d5731ba
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Jan 10 21:58:44 2019

chromium-os-fuzzers: Mask virglrenderer fuzzer in msan builds.

virglrenderer fuzzer Makefile is hardcoding asan via
"-fsanitize=address" which is incompatible with msan.

Exclude virglrenderer from msan fuzzing builds till the hardcoded flags
are fixed.

BUG=chromium:898289
BUG=chromium:920355

TEST=./build_packages target-fuzzers work with USE=msan.

Change-Id: I96a3589e7759e235c10b6f0ee9e81ac8a6d1df0f
Reviewed-on: https://chromium-review.googlesource.com/1404138
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>

[modify] https://crrev.com/c3c03dbf4056fe371044ebdf66ff33c53d5731ba/virtual/chromium-os-fuzzers/chromium-os-fuzzers-1.ebuild
[rename] https://crrev.com/c3c03dbf4056fe371044ebdf66ff33c53d5731ba/virtual/chromium-os-fuzzers/chromium-os-fuzzers-1-r25.ebuild

Comment 2 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment