Missing LGTM to a file that's been owned by reviewers |
||||
Issue descriptionI was trying to submit a CL when I've gained LGTMed from all of the owner. https://chromium-review.googlesource.com/c/chromium/src/+/1283474/18 But I was notified that LGTM is missed from the owner of chrome/common/page_load_metrics/page_load_metrics.mojom file. Yet, from the UI, all of the files have turned light green, which means all of the owners have LGTMed.
,
Oct 24
https://chromium.googlesource.com/chromium/src/+/b1f203fb50db2ab7008b851b4c4b986f4ea6a2cd/chrome/common/page_load_metrics/OWNERS#3 says "set noparent" for mojom files, so uses https://chromium.googlesource.com/chromium/src/+/b1f203fb50db2ab7008b851b4c4b986f4ea6a2cd/ipc/SECURITY_OWNERS neither Gayane nor Bryan is a security reviewer, so I don't see anything wrong
,
Oct 24
I think there is still a bug. The Gerrit GUI showed all of files have been approved by owners. I guess Gerrit didn't realize that it should also look at. per-file *.mojom=file://ipc/SECURITY_OWNERS
,
Oct 24
CQ doesn't deal with owners whatsoever. The "Gerrit GUI" is a chrome extension we don't support.
,
Oct 24
Whoops sorry, that's from Chromite Butler. Thanks!
,
Oct 28
See also https://crbug.com/886394 |
||||
►
Sign in to add a comment |
||||
Comment 1 by maxlg@chromium.org
, Oct 23