Issue metadata
Sign in to add a comment
|
CSS graytext is not rendering correctly in latest Chrome in macOS 10.14 Mojave
Reported by
david.ho...@gmail.com,
Oct 23
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 Safari/537.36 Example URL: https://embed.plnkr.co/IglxZCGZBAN3iA0A4Oys/ Steps to reproduce the problem: 1. Load the example site https://embed.plnkr.co/IglxZCGZBAN3iA0A4Oys/ 2. Notice that the rendered style is not "graying" out properly (text is black and button is not appearing disabled) What is the expected behavior? Button should be restyled to appear that it is not clickable What went wrong? When a button gets the "disabled" attribute applied, previously a default "graytext" style was applied. Now, while the style is applied (per the "computed styles" pane) there is no obvious difference in visual appearance of an enabled and disabled button. This worked properly in previous versions of macOS and renders correctly in Safari 12.0 but seems to also be broken in Firefox as well Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? N/A Does this work in other browsers? No Firefox 63.0 Chrome version: 70.0.3538.67 Channel: stable OS Version: OS X 10.14.0 Flash Version:
,
Oct 24
david.hocky@ Thanks for the issue... Unable to reproduce the issue on reported chrome version 70.0.3538.67 using Mac 10.13.6. Attaching screen-cast for reference. Steps: --------- 1. Launched reported chrome 2. Navigated the URL "https://embed.plnkr.co/IglxZCGZBAN3iA0A4Oys/" As we are Observed that the Button is not clickable and seen same as safari @Reporter: Request you to retry this issue with fresh profile without any extensions & apps or reset all the flags and let us know if issue still persists. Thanks.!
,
Oct 24
phanindra.mandapaka@chromium.org thanks for reaching out. i will give this a try. just a small clarification, this was also working for me on 10.13.x (High Sierra) it only broke after upgrading to 10.14.x (Mojave). Could you let me know if you are still unable to reproduce in 10.14?
,
Oct 24
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
david.hocky@ Thanks for the update. Able to reproduce the issue on Mac OS 10.14(Mojave) on the latest Stable 70.0.3538.77 and the latest Canary 72.0.3591.0. Issue is not reproducible on Mac OS 10.13.3, Windows 10 and Ubuntu 17.10. Attached is the screen shot for reference. This is a Non-Regression issue as this is observed from M-60 chrome builds. Hence marking this as Untriaged for further updates from Dev. Thanks..
,
Oct 26
,
Oct 26
Who has a Mac with 10.14 on it? As far as I know we can't install that yet.
,
Oct 26
We Mac VMWare images at http://go/mac-litterbox.
,
Oct 26
ellyjones@, does the Mac team have any idea what might have changed in Mac 10.14 to affect theme settings? From memory we draw the buttons and other theme elements with OS primitives, so it's likely they need updating in some way.
,
Oct 29
Over to lgrey@.
,
Oct 29
Looks like the system color changes introduced for dark mode broke how we interpret NSColor.disabledControlTextColor. I'm surprised we haven't seen any other breakages like that (and I imagine it might get worse when we allow actual dark mode).
,
Oct 29
,
Oct 29
Correction: it's the actual change to the color's value that mattered: we're ignoring alpha when translating system colors in Blink's layout theme on Mac.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36de6d6adeb99fb05f79daab1868568f4cca367c commit 36de6d6adeb99fb05f79daab1868568f4cca367c Author: Leonard Grey <lgrey@chromium.org> Date: Wed Oct 31 02:02:30 2018 Mac: Take alpha channel into account when reading system colors in Blink Bug: 898278 Change-Id: I24ae7ef4e8accd54244dfd09721fa376dadfba34 Reviewed-on: https://chromium-review.googlesource.com/c/1305498 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#604111} [modify] https://crrev.com/36de6d6adeb99fb05f79daab1868568f4cca367c/third_party/blink/renderer/core/layout/layout_theme_mac.mm
,
Nov 1
Able to reproduce this issue on Mac OS 10.14 on the reported version 70.0.3538.67 and the issue is fixed on the latest M-72 build 72.0.3598.0. On navigating to the above given URL, can observe that the Button is grey in color and is not clickable. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Nov 1
,
Nov 5
The NextAction date has arrived: 2018-11-05
,
Nov 6
Thanks for the quick triage and fix to this issue! Looking forward to the GA release
,
Dec 4
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by swarnasree.mukkala@chromium.org
, Oct 24