New issue
Advanced search Search tips

Issue 898276 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Test that all addresses without CFI information are function prolog

Project Member Reported by ssid@google.com, Oct 23

Issue description

Context: comment thread at https://chromium-review.googlesource.com/c/chromium/src/+/1265560#message-cc790779746126dd0a9bbf5ffbef3fafb6428d27

The code in this CL assumes that all of the addresses without CFI information are function prologs.

1. Try to make pseudo-CFI for the <0.1% of stuff not covered that is not a prologue. To make the assumptions more solid. This experiment might cause size regression on the CFI tables.

2. Compile time test: disassemble the whole library, collect uncovered offsets, check they are at function beginning and only contain a whitelist of instructions. Figure out if the test can be written on chrome side or breakpad side for unwind rule coverage.

 

Sign in to add a comment