New issue
Advanced search Search tips

Issue 898257 link

Starred by 4 users
Status: Fixed
Owner:
andreasbutler@google.com
Closed: Nov 30
Cc:
dmu...@chromium.org
costan@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Implementation of IndexedDB transaction explicit commit()

Project Member Reported by andreasbutler@google.com, Oct 23 
There is interbrowser agreement to implement an explicit commit() API call for IndexedDB transactions to allow developers to forego the IndexedDB autocommit logic when desired. This bug tracks the implementation of an explicit commit() function to the IndexedDB.Transaction interface.

Explainer: https://andreas-butler.github.io/idb-transaction-commit/EXPLAINER
Spec change: https://github.com/w3c/IndexedDB/pull/242
Design Doc: go/idb-explicit-commit

Comment 1 by andreasbutler@google.com, Oct 23

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/291c54a787f81c358ee1d3786c488f48b3fd3ab8

commit 291c54a787f81c358ee1d3786c488f48b3fd3ab8
Author: Andreas Butler <andreasbutler@google.com>
Date: Fri Nov 30 00:34:26 2018

[IndexedDB]: Implement explicit commit() in renderer

Implementing an explicit commit function for the IndexedDB Transaction API.
The addition of this API allows developers to preempt IndexedDB's autocommit
functionality by sending their own explicit commit signal.

Explainer: https://andreas-butler.github.io/idb-transaction-commit/EXPLAINER
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=898257
Change-Id: I5e8bdc697052139d014757408d9a7f2b6367655b
Reviewed-on: https://chromium-review.googlesource.com/c/1300055
Commit-Queue: Andreas Butler <andreasbutler@google.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612474}
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/content/browser/indexed_db/indexed_db_transaction.cc
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/renderer/modules/indexeddb/idb_transaction.cc
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/renderer/modules/indexeddb/idb_transaction.h
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/renderer/modules/indexeddb/idb_transaction.idl
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/renderer/platform/runtime_enabled_features.json5
[add] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit-throw.any.js
[add] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/external/wpt/IndexedDB/idb-explicit-commit.any.js
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/external/wpt/IndexedDB/support-promises.js
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/external/wpt/IndexedDB/support.js
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/291c54a787f81c358ee1d3786c488f48b3fd3ab8/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

Comment 3 by andreasbutler@google.com, Nov 30

Status: Fixed (was: Assigned)
►

Sign in to add a comment