dlcservice: exit when idle |
|||||
Issue descriptionMake dlcservice activate on-demand(dbus signal, etc.). 1. make sure dlcservice does not store any temporary internal states. 2. implement activation mechanisms.
,
Nov 14
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/5f0b2ba56969cc1ed802144661ab46bf9e94dc83 commit 5f0b2ba56969cc1ed802144661ab46bf9e94dc83 Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Nov 28 03:14:13 2018 imageloader/system_api/dlcservice: move constants to system_api Dlc-A and Dlc-B are API parameters and are used by dlcservice. So let's move them to system_api so it can be shared. BUG=chromium:898255 TEST=precq Change-Id: I0c94e6b33178a466d4da5422e6862702388b3664 Reviewed-on: https://chromium-review.googlesource.com/1351677 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> [modify] https://crrev.com/5f0b2ba56969cc1ed802144661ab46bf9e94dc83/system_api/dbus/service_constants.h [modify] https://crrev.com/5f0b2ba56969cc1ed802144661ab46bf9e94dc83/dlcservice/dlc_service_dbus_adaptor.cc [modify] https://crrev.com/5f0b2ba56969cc1ed802144661ab46bf9e94dc83/imageloader/dlc.cc
,
Nov 29
,
Dec 5
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
,
Today
(3 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/46e94b9490ee0c892cbe75551d4610cad6a3bdc6 commit 46e94b9490ee0c892cbe75551d4610cad6a3bdc6 Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Jan 23 05:05:17 2019 dlcservice: on-demand service activation We change dlcservice to be a short-lived process and activated on-demand via D-Bus method call. When activated on-demand, we skip the initialization phase which mounts all installed DLC module images. This CL does: 1. add load_installed FLAG to dlcservice binary. 2. modify .conf file to support parameters. 3. add *.service file for d-bus activation and call upstart with load_installed option. 4. Schedule a shutdown event after service start or at each API method exit. 5. unittest. BUG=chromium:898255 TEST=Unittest, manual testing on DUT: 1) start dlcservice, 2) start dlcservice PARAMS=--load_installed=false 3) start dlcservice PARAMS=--load_installed=true, (error message is present in syslog). 4) dlcservice_util --list CQ-DEPEND=CL:1409850 Change-Id: I586b01a481f0f309896becaf737dfd9a01261f2c Reviewed-on: https://chromium-review.googlesource.com/1409782 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor.cc [add] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/org.chromium.DlcService.service [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor.h [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/main.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service.h [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor_test.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlcservice.conf
,
Today
(3 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9e3383109a4fe893eb14946cc6c3b9f1f6f495fb commit 9e3383109a4fe893eb14946cc6c3b9f1f6f495fb Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Jan 23 05:05:17 2019 dlcservice: install .service file We support on-demand activation of dlcservice via d-bus. BUG=chromium:898255 TEST=emerge-kefka dlcservice CQ-DEPEND=CL:1409782 Change-Id: I98072a8e070e524ae0e0185ba01566a826eb9263 Reviewed-on: https://chromium-review.googlesource.com/1409850 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/9e3383109a4fe893eb14946cc6c3b9f1f6f495fb/chromeos-base/dlcservice/dlcservice-9999.ebuild
,
Today
(2 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/46e94b9490ee0c892cbe75551d4610cad6a3bdc6 commit 46e94b9490ee0c892cbe75551d4610cad6a3bdc6 Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Jan 23 05:05:17 2019 dlcservice: on-demand service activation We change dlcservice to be a short-lived process and activated on-demand via D-Bus method call. When activated on-demand, we skip the initialization phase which mounts all installed DLC module images. This CL does: 1. add load_installed FLAG to dlcservice binary. 2. modify .conf file to support parameters. 3. add *.service file for d-bus activation and call upstart with load_installed option. 4. Schedule a shutdown event after service start or at each API method exit. 5. unittest. BUG=chromium:898255 TEST=Unittest, manual testing on DUT: 1) start dlcservice, 2) start dlcservice PARAMS=--load_installed=false 3) start dlcservice PARAMS=--load_installed=true, (error message is present in syslog). 4) dlcservice_util --list CQ-DEPEND=CL:1409850 Change-Id: I586b01a481f0f309896becaf737dfd9a01261f2c Reviewed-on: https://chromium-review.googlesource.com/1409782 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor.cc [add] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/org.chromium.DlcService.service [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor.h [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/main.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service.h [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor_test.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlcservice.conf
,
Today
(2 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9e3383109a4fe893eb14946cc6c3b9f1f6f495fb commit 9e3383109a4fe893eb14946cc6c3b9f1f6f495fb Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Jan 23 05:05:17 2019 dlcservice: install .service file We support on-demand activation of dlcservice via d-bus. BUG=chromium:898255 TEST=emerge-kefka dlcservice CQ-DEPEND=CL:1409782 Change-Id: I98072a8e070e524ae0e0185ba01566a826eb9263 Reviewed-on: https://chromium-review.googlesource.com/1409850 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/9e3383109a4fe893eb14946cc6c3b9f1f6f495fb/chromeos-base/dlcservice/dlcservice-9999.ebuild
,
Today
(2 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/46e94b9490ee0c892cbe75551d4610cad6a3bdc6 commit 46e94b9490ee0c892cbe75551d4610cad6a3bdc6 Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Jan 23 05:05:17 2019 dlcservice: on-demand service activation We change dlcservice to be a short-lived process and activated on-demand via D-Bus method call. When activated on-demand, we skip the initialization phase which mounts all installed DLC module images. This CL does: 1. add load_installed FLAG to dlcservice binary. 2. modify .conf file to support parameters. 3. add *.service file for d-bus activation and call upstart with load_installed option. 4. Schedule a shutdown event after service start or at each API method exit. 5. unittest. BUG=chromium:898255 TEST=Unittest, manual testing on DUT: 1) start dlcservice, 2) start dlcservice PARAMS=--load_installed=false 3) start dlcservice PARAMS=--load_installed=true, (error message is present in syslog). 4) dlcservice_util --list CQ-DEPEND=CL:1409850 Change-Id: I586b01a481f0f309896becaf737dfd9a01261f2c Reviewed-on: https://chromium-review.googlesource.com/1409782 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Amin Hassani <ahassani@chromium.org> [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor.cc [add] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/org.chromium.DlcService.service [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor.h [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/main.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service.h [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlc_service_dbus_adaptor_test.cc [modify] https://crrev.com/46e94b9490ee0c892cbe75551d4610cad6a3bdc6/dlcservice/dlcservice.conf
,
Today
(2 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9e3383109a4fe893eb14946cc6c3b9f1f6f495fb commit 9e3383109a4fe893eb14946cc6c3b9f1f6f495fb Author: Xiaochu Liu <xiaochu@chromium.org> Date: Wed Jan 23 05:05:17 2019 dlcservice: install .service file We support on-demand activation of dlcservice via d-bus. BUG=chromium:898255 TEST=emerge-kefka dlcservice CQ-DEPEND=CL:1409782 Change-Id: I98072a8e070e524ae0e0185ba01566a826eb9263 Reviewed-on: https://chromium-review.googlesource.com/1409850 Commit-Ready: Xiaochu Liu <xiaochu@chromium.org> Tested-by: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/9e3383109a4fe893eb14946cc6c3b9f1f6f495fb/chromeos-base/dlcservice/dlcservice-9999.ebuild |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by xiaochu@chromium.org
, Oct 23