New issue
Advanced search Search tips

Issue 898248 link

Starred by 1 user
Status: Verified
Owner:
shaktisahu@chromium.org
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Downloads-Home-Rework


Sign in to add a comment

[Downloads Home] Single image in a section doesn't span full width

Project Member Reported by shaktisahu@chromium.org, Oct 23 
Single image in a section doesn't span full width even for phones
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2c3bec1776a889f42b0f8e7889f70e1a6f7b31

commit cc2c3bec1776a889f42b0f8e7889f70e1a6f7b31
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Oct 23 17:55:22 2018

Download Home : Fixed a bug where full width images don't span full

Fixed a bug where images don't go beyond 300dp on phones even on portrait
which was introduced in CL :
https://chromium-review.googlesource.com/c/chromium/src/+/1282203

Bug:  898248 
Change-Id: Ie749bfc3ebbbee8c861466d37c5742348591b90b
Reviewed-on: https://chromium-review.googlesource.com/c/1295870
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602016}
[modify] https://crrev.com/cc2c3bec1776a889f42b0f8e7889f70e1a6f7b31/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListView.java

Comment 2 by shaktisahu@chromium.org, Oct 23

Labels: Merge-Request-71
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 24

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by cr-audit...@appspot.gserviceaccount.com, Oct 24

Labels: -Merge-Approved-71 Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/202f9003e0633f0a8da12752d31601717ff09786

Commit: 202f9003e0633f0a8da12752d31601717ff09786
Author: shaktisahu@chromium.org
Commiter: shaktisahu@chromium.org
Date: 2018-10-24 20:31:40 +0000 UTC

Download Home : Fixed a bug where full width images don't span full

Fixed a bug where images don't go beyond 300dp on phones even on portrait
which was introduced in CL :
https://chromium-review.googlesource.com/c/chromium/src/+/1282203

Bug:  898248 
Change-Id: Ie749bfc3ebbbee8c861466d37c5742348591b90b
Reviewed-on: https://chromium-review.googlesource.com/c/1295870
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602016}(cherry picked from commit cc2c3bec1776a889f42b0f8e7889f70e1a6f7b31)
Reviewed-on: https://chromium-review.googlesource.com/c/1298360
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#302}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Comment 5 by shaktisahu@chromium.org, Oct 24

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 24

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/202f9003e0633f0a8da12752d31601717ff09786

commit 202f9003e0633f0a8da12752d31601717ff09786
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Wed Oct 24 20:31:40 2018

Download Home : Fixed a bug where full width images don't span full

Fixed a bug where images don't go beyond 300dp on phones even on portrait
which was introduced in CL :
https://chromium-review.googlesource.com/c/chromium/src/+/1282203

Bug:  898248 
Change-Id: Ie749bfc3ebbbee8c861466d37c5742348591b90b
Reviewed-on: https://chromium-review.googlesource.com/c/1295870
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602016}(cherry picked from commit cc2c3bec1776a889f42b0f8e7889f70e1a6f7b31)
Reviewed-on: https://chromium-review.googlesource.com/c/1298360
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#302}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/202f9003e0633f0a8da12752d31601717ff09786/chrome/android/java/src/org/chromium/chrome/browser/download/home/list/DateOrderedListView.java

Comment 7 by krav...@chromium.org, Oct 31

Status: Verified (was: Fixed)
Verified with - 71.0.3578.31 build
Screenshot_20181031-113610_Chrome Beta.jpg
454 KB View Download
►

Sign in to add a comment