New issue
Advanced search Search tips

Issue 898245 link

Starred by 1 user
Status: Assigned
Owner:
einbinder@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools compatibility versioning

Project Member Reported by einbinder@chromium.org, Oct 23 
As the number of hacks in devtools_compatibility.js keeps growing, we should only apply the hacks that are needed for the version of devtools being run. This will remove the need for hacks to be both forwards and backwards compatible.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b0b9b5fd0e6518dfe39199c1555927f17ca4e8b

commit 4b0b9b5fd0e6518dfe39199c1555927f17ca4e8b
Author: Joel Einbinder <einbinder@chromium.org>
Date: Wed Oct 24 01:29:09 2018

DevTools: Pass the remoteVersion into devtools_compatibility.js

This does the backend part of adding the remoteVersion into the query
string. A follow up will use the remoteVersion to selectively apply
only parts of the compatibility script.

Bug: 898245
Change-Id: I2130e951a0368b4d565bfdc2bb03e2d327c2569f
Reviewed-on: https://chromium-review.googlesource.com/c/1297236
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602210}
[modify] https://crrev.com/4b0b9b5fd0e6518dfe39199c1555927f17ca4e8b/chrome/browser/devtools/device/devtools_device_discovery.cc
[modify] https://crrev.com/4b0b9b5fd0e6518dfe39199c1555927f17ca4e8b/chrome/browser/devtools/device/devtools_device_discovery.h
[modify] https://crrev.com/4b0b9b5fd0e6518dfe39199c1555927f17ca4e8b/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/4b0b9b5fd0e6518dfe39199c1555927f17ca4e8b/chrome/browser/ui/webui/devtools_ui.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89ed1da2c8dde2a5c415fb5688c05b7bcfc7cf94

commit 89ed1da2c8dde2a5c415fb5688c05b7bcfc7cf94
Author: Joel Einbinder <einbinder@chromium.org>
Date: Tue Oct 30 01:59:53 2018

DevTools: Selectively apply devtools_compatibility.js for remote version

This patch uses the remoteVersion of the devtools being run to apply
only the fixes that are needed.

Additionally, use of the /deep/ selector is swapped out for injecting
a stylesheet in every shadow root.

Bug: 898245
Change-Id: I311ab48d88434d821fedb279d81b2ab9a7f8c94d
Reviewed-on: https://chromium-review.googlesource.com/c/1299914
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603733}
[modify] https://crrev.com/89ed1da2c8dde2a5c415fb5688c05b7bcfc7cf94/third_party/blink/renderer/devtools/front_end/devtools_compatibility.js
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20f041d246f785b4cc4713bb6d58db4a0952c5e2

commit 20f041d246f785b4cc4713bb6d58db4a0952c5e2
Author: Joel Einbinder <einbinder@chromium.org>
Date: Fri Nov 02 20:52:27 2018

DevTools: Correctly return the major version in devtools_compatibility

Bug: 898245
Change-Id: I591cecc162cb86d5925ec67b4bbe6b12cd72a0c2
Reviewed-on: https://chromium-review.googlesource.com/c/1313830
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605045}
[modify] https://crrev.com/20f041d246f785b4cc4713bb6d58db4a0952c5e2/third_party/blink/renderer/devtools/front_end/devtools_compatibility.js
►

Sign in to add a comment