New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 898234 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

remove OS_CHROMEOS #ifdefs for DRM graphics

Project Member Reported by spang@chromium.org, Oct 23

Issue description

The DRM graphics platform in chrome is now used by products other than Chrome OS such as Google's display assistant devices.

We should remove the remaining Chrome OS #ifdefs where possible, so that we have equivalent functionality and predictable behavior across builds.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97b0a4e0d017ca07ec3e2cbb35a63860c29bdcdf

commit 97b0a4e0d017ca07ec3e2cbb35a63860c29bdcdf
Author: Michael Spang <spang@chromium.org>
Date: Tue Oct 23 19:23:40 2018

Whitelist dmabuf sync ioctl on all linux platforms

This ioctl is used to synchronize zero copy GPU uploads. Non-Chrome OS
builds are starting to be able to use this capability (wayland on linux
desktop, non-CrOS DRM platform builds) so whitelist it more broadly.

Bug:  898234 ,  864914 
Test: chrome --enable-zero-copy --enable-native-gpu-memory-buffers
  on http://media.24ways.org/2009/15/space.html w/ fps counter

Change-Id: I449d5deddd48abff65a7f7add9c3b990f8d208e3
Reviewed-on: https://chromium-review.googlesource.com/c/1297085
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602049}
[modify] https://crrev.com/97b0a4e0d017ca07ec3e2cbb35a63860c29bdcdf/services/service_manager/sandbox/linux/bpf_renderer_policy_linux.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47adc8782b8bebb98edd0fe58c6c4a2e5bbc3e2e

commit 47adc8782b8bebb98edd0fe58c6c4a2e5bbc3e2e
Author: Michael Spang <spang@chromium.org>
Date: Tue Oct 23 20:44:58 2018

ozone: drm: Remove OS_CHROMEOS #ifdefs around vulkan code

This uses some deprecated Intel mesa APIs but isn't actually Chrome OS
specific. Remove it to minimize Chrome OS #ifdefs.

Bug:  898234 
Test: compile
Change-Id: I855e734646e0ff7b57150cf9d342156ea5a693aa
Reviewed-on: https://chromium-review.googlesource.com/c/1297239
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602078}
[modify] https://crrev.com/47adc8782b8bebb98edd0fe58c6c4a2e5bbc3e2e/ui/ozone/platform/drm/gpu/gbm_surface_factory.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment