New issue
Advanced search Search tips

Issue 898220 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Some inconsistencies and problems in DevTools with dark theme

Reported by surenenf...@gmail.com, Oct 23

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.67 Safari/537.36

Steps to reproduce the problem:
1.  Open some website, for example www.facebook.com
2.  Open DevTools window (Ctrl+Shift+I)
3.  In DevTools settings (F1) set the theme to dark mode if it's not dark
4.  Switch to "Memory" tab
5.  Look at the difference between selected and not selected radio buttons under "Select profiling type"
6.  Take heap snapshot
7.  In "Constructor" tree pane expand "(string)" or any other node which has many children
8.  Scroll down until you see three buttons saying something like "Show after" / "Show before" / "Show all"
9.  Also look at "Summary" and "All objects" dropdown menus
10. Switch to "Audits" tab
11. Click on "Run audits" and wait until everything finishes
12. Look at the audits' dropdown menu

What is the expected behavior?
The radio button states (5) should be more distinguishable.
The buttons' texts (8) should be more distinguishable.
It makes sense for the dropdown menus (9, 12) to be consistent with dark theme.

What went wrong?
This is purely a UI theme issue, not a functional bug.

The radio button states (Capture1.PNG) aren't that distinguishable.
The buttons' texts (Capture2.PNG) aren't that distinguishable and can hurt eyes.
The dropdown menus (Capture3.png, Capture4.png) aren't consistent with dark theme, a minor issue though.

Did this work before? N/A 

Chrome version: 70.0.3538.67  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
Capture1.PNG
15.8 KB View Download
Capture2.PNG
8.3 KB View Download
Capture3.png
12.1 KB View Download
Capture4.png
5.7 KB View Download
Labels: Needs-Triage-M70
Cc: phanindra.mandapaka@chromium.org
Labels: Triaged-ET Target-72 M-72 FoundIn-71 FoundIn-70 FoundIn-72 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
surenenfiajyan@ Thanks for filling the issue..

Able to reproduce the issue on reported chrome version 70.0.3538.67 also on latest chrome 72.0.3589.0 using Mac 10.13.6, Ubuntu 14.04, and Windows 10.  
 
Same behavior is seen on M60(60.0.3112.113) hence considering it as non-regression and marking it as Untriaged.

Thanks! 
Found another couple of minor issues (though I'm not sure): in the bottom dock window hamburger menu and and in "Sources" ">>" menu.
Capture1.png
6.9 KB View Download
Capture2.png
15.1 KB View Download
Labels: Hotlist-DesktopUIConsider
Labels: Group-Dark_Mode
Components: -UI Platform>DevTools
Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)
Routing to lgrey for initial assessment.
Labels: -Hotlist-DesktopUIConsider Hotlist-DesktopUITriaged
Owner: ----
Status: Untriaged (was: Assigned)
I think this is dev tools internal dark mode, orthogonal to the WIP system dark mode work for macOS 10.14/Windows 10, so unassigning (please reassign if I misunderstood).
Owner: einbinder@chromium.org
Status: Assigned (was: Untriaged)
Labels: -M-72 -Target-72 M-73 Target-73

Sign in to add a comment