New issue
Advanced search Search tips

Issue 898215 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Oct 30
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature



Sign in to add a comment

CSS: :is has been renamed to :where

Project Member Reported by ericwilligers@chromium.org, Oct 23 
The functional pseudo-class like :matches() with 0 specificity
is now named :where().
https://github.com/w3c/csswg-drafts/issues/2143#issuecomment-432303830

Blink currently has the pseudo-class implemented as :is.

When we change the name to :where, we can contribute tests to WPT.

Comment 1 by ericwilligers@chromium.org, Oct 23

Owner: ericwilligers@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/1296606
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c

commit e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Wed Oct 24 08:47:59 2018

CSS: rename :is to :where

The functional pseudo-class like :matches() with 0 specificity
is now named :where().
https://drafts.csswg.org/selectors/#zero-matches

BUG= 898215 

Change-Id: Ic4d3feccc2fca566e54bb0076b4248b7958788c2
Reviewed-on: https://chromium-review.googlesource.com/c/1296606
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602278}
[rename] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/WebKit/LayoutTests/fast/css/invalidation/where.html
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/css_selector.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/css_selector.h
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/css_selector_list.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/css_selector_list.h
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/parser/css_selector_parser.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/parser/css_selector_parser_test.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/rule_feature_set.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/rule_feature_set_test.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/rule_set_test.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/css/selector_checker.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/frame/use_counter_test.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/core/inspector/inspector_trace_events.cc
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/e4a8dda8926d36a02e3f3bc3d20d839bb71ede5c/tools/metrics/histograms/enums.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f238b3610dc3d363e115e342fae56ce0178968f2

commit f238b3610dc3d363e115e342fae56ce0178968f2
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Mon Oct 29 15:43:02 2018

CSS: Move :where test to WPT

https://drafts.csswg.org/selectors-4/#zero-matches

BUG= 898215 

Change-Id: I262b0ea290b340b634c6c4ffe98fa425bcff2b84
Reviewed-on: https://chromium-review.googlesource.com/c/1303356
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603506}
[rename] https://crrev.com/f238b3610dc3d363e115e342fae56ce0178968f2/third_party/WebKit/LayoutTests/external/wpt/css/selectors/invalidation/where.html

Comment 4 by ericwilligers@chromium.org, Oct 30

Status: Fixed (was: Started)
►

Sign in to add a comment