New issue
Advanced search Search tips

Issue 898213 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Chromevox EditingTest.RichTextSelectByLine fails if font hinting configuration changes

Project Member Reported by jamescook@chromium.org, Oct 23

Issue description

This test fails in the step that extends text selection by a line:

https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs?rcl=b2a3ef6c2798e9e5708719d703dc5bd4a144feac&l=473

It passes if you override the font hinting for the test binary in the Linux system-wide font config:

https://cs.chromium.org/chromium/src/base/test/fontconfig_util_linux.cc?rcl=7ff31fb76bb12166f1aebaff387705b0fc155b17&l=39

We used to be able to do this because chromevox_tests was its own binary. We can't do it when the Chromevox tests are part of browser_tests.

Either way, this test shouldn't be sensitive to font hinting.

 
This was sort of what I was concerned with. It indicates that ChromeVox should probably have its own test target, since it is trying to test the surrounding environment. Pulling chromevox into browser tests would limit our ability to test chromevox end to end in the future.

Editing tests are always going to be sensitive to layout and that's actually good because that's what we're really testing.

The problem appears to be the width of "fi" in "first" vs. "se" in "second". Changing the test to use "123" and "456" makes things pass, because you can rely on digits having the same width.

I doubt the test actually want to assert that going down by 1 line from "fi" puts you at a particular character position in the string "second".

Cc: sky@chromium.org
+sky re comment #1

Owner: jamescook@chromium.org
Status: Started (was: Untriaged)
I have a fix.

The test puts a text cursor after the second character of the phrase "first line" then goes down by a line and relies on the caret appearing after the second character of "second line". This depends on the exact character widths, but isn't important to the test.

No other chromevox tests appear to be sensitive to font config.
I doubt the test actually want to assert that going down by 1 line from "fi" puts you at a particular character position in the

I don't it does either, but it does want to have a sane baseline. If we actually incorrectly report the selection (which happens more often than you'd expect), we would want to catch that.

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1380ad16565e3009b4b87269f98551da753a2ddc

commit 1380ad16565e3009b4b87269f98551da753a2ddc
Author: James Cook <jamescook@chromium.org>
Date: Thu Oct 25 00:51:19 2018

Fold chromevox_tests into browser_tests

chromevox_tests compiles and links all of chrome, so folding into
browser_tests will save work on the bots. It will also give coverage
for SingleProcessMash and other projects that run browser_tests with
optional flags.

Rename the tests to start with ChromeVox to make them easier to run
with --gtest_filter (thanks to dtseng for a CL that did the rename).

Fix ChromeVoxEditingTest.RichTextSelectByLine so it isn't sensitive
to exact font widths and remove chromevox_tests fontconfig override.

Bug:  892179 ,  898213 
Test: browser_tests

Change-Id: Ia23c8f4c237677d299bbe774cf3191654974a56b
Reviewed-on: https://chromium-review.googlesource.com/c/1294811
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602543}
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/base/test/fontconfig_util_linux.cc
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/BUILD.gn
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_input_handler_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/braille/pan_strategy_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/live_regions_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/navigation_manager_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/chromevox/injected/user_commands_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/aria_util_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/braille_text_handler_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/braille_util_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/command_store_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/content_editable_extractor_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/cursor_selection_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/dom_util_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/editable_text_area_shadow_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/editable_text_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/find_util_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/key_sequence_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/page_selection_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/selection_util_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/common/spannable_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/i_search_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/log_store_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/recovery_strategy_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/cvox2/background/tree_walker_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/host/chrome/braille_integration_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background_test.extjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/character_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/group_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/layout_line_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/object_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/sentence_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/structural_line_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/table_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/chromevox/walkers/word_walker_test.unitjs
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/browser/resources/chromeos/select_to_speak/BUILD.gn
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/chrome/test/BUILD.gn
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/docs/accessibility/chromevox.md
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/docs/accessibility/tests.md
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/1380ad16565e3009b4b87269f98551da753a2ddc/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)

Sign in to add a comment